[issue26187] sqlite3 trace callback prints duplicate line

[Berker Peksag]

Berker Peksag added the comment:

Thanks, Anish and Aviv!

--
resolution:  -> fixed
stage: patch review -> resolved
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue26187] sqlite3 trace callback prints duplicate line

[Berker Peksag]

Berker Peksag added the comment:


New changeset 0e6cb2ea624570ed08c354f1ed1f595dab4192d6 by Berker Peksag (Aviv 
Palivoda) in branch 'master':
bpo-26187: Test that set_trace_callback() is not called multiple times (GH-461)
https://github.com/python/cpython/commit/0e6cb2ea624570ed08c354f1ed1f595dab4192d6


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue26187] sqlite3 trace callback prints duplicate line

[Aviv Palivoda]

Changes by Aviv Palivoda :


--
pull_requests: +384

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue26187] sqlite3 trace callback prints duplicate line

[Berker Peksag]

Changes by Berker Peksag :


--
stage: test needed -> patch review

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue26187] sqlite3 trace callback prints duplicate line

[Anish Shah]

Changes by Anish Shah :


--
pull_requests: +360

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue26187] sqlite3 trace callback prints duplicate line

[Anish Shah]

Anish Shah added the comment:

I can work on this.

--
nosy: +anish.shah

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue26187] sqlite3 trace callback prints duplicate line

[Berker Peksag]

Berker Peksag added the comment:

It would be nice to add a test case to 
https://github.com/python/cpython/blob/86a670543ff97d52fd9b8ca0477f8b6d27ee946d/Lib/sqlite3/test/hooks.py#L204
 before closing this.

--
nosy: +berker.peksag
stage:  -> test needed
versions: +Python 3.7 -Python 3.4, Python 3.6

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue26187] sqlite3 trace callback prints duplicate line

[Aviv Palivoda]

Aviv Palivoda added the comment:

This issue will be resolved when we change the sqlite3_prepare to 
sqlite3_prepare_v2. So there should be a dependency on issue 9303.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue26187] sqlite3 trace callback prints duplicate line

[Aviv Palivoda]

New submission from Aviv Palivoda:

I am running the following script:

--
>>> import sqlite3
>>> import os
>>> import time
>>> con1 = sqlite3.connect("/tmp/test.db")
>>> con2 = sqlite3.connect("/tmp/test.db")
>>> con1.set_trace_callback(print)
>>> cur = con1.cursor()
>>> cur.execute("create table test(a)")
create table test(a)

>>> con2.execute("create table test2(a)")

>>> cur.execute("insert into test(a) values(1)")
BEGIN 
insert into test(a) values(1)
insert into test(a) values(1)

>>> for a in con1.execute("select * from test"):
... print("result:", a)
... 
select * from test
result: (1,)
---

As you can see i get duplicate traceback print of the "insert into test(a) 
values(1)" line. The duplicate print has no effect on the actual db.

I have tested this both on python 3.4.3 and 3.6.0a0 on ubuntu14.04

--
components: Extension Modules
messages: 258874
nosy: ghaering, palaviv
priority: normal
severity: normal
status: open
title: sqlite3 trace callback prints duplicate line
type: behavior
versions: Python 3.4, Python 3.6

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com