[issue26280] ceval: Optimize list[int] (subscript) operation similarly to CPython 2.7

[Guido van Rossum]

Guido van Rossum  added the comment:

Way to go Irit!--
--Guido (mobile)

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue26280] ceval: Optimize list[int] (subscript) operation similarly to CPython 2.7

[Irit Katriel]

Change by Irit Katriel :


--
resolution:  -> fixed
stage: patch review -> resolved
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue26280] ceval: Optimize list[int] (subscript) operation similarly to CPython 2.7

[Mark Shannon]

Mark Shannon  added the comment:


New changeset 641345d636320a6fca04a5271fa4c4c5ba3e5437 by Irit Katriel in 
branch 'main':
bpo-26280: Port BINARY_SUBSCR to PEP 659 adaptive interpreter (GH-27043)
https://github.com/python/cpython/commit/641345d636320a6fca04a5271fa4c4c5ba3e5437


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue26280] ceval: Optimize list[int] (subscript) operation similarly to CPython 2.7

[Pablo Galindo Salgado]

Pablo Galindo Salgado  added the comment:

Here is my previous attempt at this, for reference:

https://github.com/python/cpython/pull/9853

--
nosy: +pablogsal

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue26280] ceval: Optimize list[int] (subscript) operation similarly to CPython 2.7

[Irit Katriel]

Change by Irit Katriel :


--
versions: +Python 3.11 -Python 3.6

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue26280] ceval: Optimize list[int] (subscript) operation similarly to CPython 2.7

[Irit Katriel]

Change by Irit Katriel :


--
pull_requests: +25602
stage: needs patch -> patch review
pull_request: https://github.com/python/cpython/pull/27043

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue26280] ceval: Optimize list[int] (subscript) operation similarly to CPython 2.7

[Irit Katriel]

Irit Katriel  added the comment:

Sure, I'll have a look.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue26280] ceval: Optimize list[int] (subscript) operation similarly to CPython 2.7

[Guido van Rossum]

Guido van Rossum  added the comment:

Very much so. Irit, do you want to give it a try? (Note there are helpful 
instructions now in Python/adaptive.md.)

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue26280] ceval: Optimize list[int] (subscript) operation similarly to CPython 2.7

[Irit Katriel]

Irit Katriel  added the comment:

This looks like a case of specialization.

--
nosy: +Mark.Shannon, gvanrossum, iritkatriel

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue26280] ceval: Optimize list[int] (subscript) operation similarly to CPython 2.7

[Jim Fasarakis-Hilliard]

Changes by Jim Fasarakis-Hilliard :


--
nosy: +Jim Fasarakis-Hilliard

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue26280] ceval: Optimize list[int] (subscript) operation similarly to CPython 2.7

[STINNER Victor]

Changes by STINNER Victor :


--
title: ceval: Optimize list -> ceval: Optimize list[int] (subscript) operation 
similarly to CPython 2.7

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue26280] ceval: Optimize list[int] (subscript) operation similarly to CPython 2.7

[Zach Byrne]

Zach Byrne added the comment:

Here's a patch that looks likes Victor's from the duplicate, but with tuples 
covered as well. I ran some straight forward micro benchmarks but haven't 
bothered running the benchmark suite yet. Unsurprisingly, optimized paths are 
faster, and the others take a penalty.

[0]byrnez@byrnez-laptop:~/git/python$ ./python.orig -m timeit -s "l = 
[1,2,3,4,5,6]" "l[3]"
1000 loops, best of 3: 0.0306 usec per loop
[0]byrnez@byrnez-laptop:~/git/python$ ./python -m timeit -s "l = [1,2,3,4,5,6]" 
"l[3]"
1000 loops, best of 3: 0.0243 usec per loop

[0]byrnez@byrnez-laptop:~/git/python$ ./python.orig -m timeit -s "l = 
(1,2,3,4,5,6)" "l[3]"
1000 loops, best of 3: 0.0291 usec per loop
[0]byrnez@byrnez-laptop:~/git/python$ ./python -m timeit -s "l = (1,2,3,4,5,6)" 
"l[3]"
1000 loops, best of 3: 0.0241 usec per loop

[0]byrnez@byrnez-laptop:~/git/python$ ./python.orig -m timeit -s "l = 
'asdfasdf'" "l[3]"
1000 loops, best of 3: 0.034 usec per loop
[0]byrnez@byrnez-laptop:~/git/python$ ./python -m timeit -s "l = 'asdfasdf'" 
"l[3]"
1000 loops, best of 3: 0.0366 usec per loop

[0]byrnez@byrnez-laptop:~/git/python$ ./python.orig -m timeit -s "l = 
[1,2,3,4,5,6]" "l[:3]"
1000 loops, best of 3: 0.124 usec per loop
[0]byrnez@byrnez-laptop:~/git/python$ ./python -m timeit -s "l = [1,2,3,4,5,6]" 
"l[:3]"
1000 loops, best of 3: 0.125 usec per loop

--
Added file: http://bugs.python.org/file41939/subscr1.patch

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue26280] ceval: Optimize list[int] (subscript) operation similarly to CPython 2.7

[STINNER Victor]

STINNER Victor added the comment:

Oh, I just created a duplicate with a patch for list[int]: issue #26301.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue26280] ceval: Optimize list[int] (subscript) operation similarly to CPython 2.7

[STINNER Victor]

Changes by STINNER Victor :


--
title: ceval: Optimize [] operation similarly to CPython 2.7 -> ceval: Optimize 
list[int] (subscript) operation similarly to CPython 2.7

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com