[issue2632] performance problem in socket._fileobject.read

Gregory P. Smith [EMAIL PROTECTED] added the comment: committed to release25-maint in r64754. -- resolution: - fixed status: open - closed ___ Python tracker [EMAIL PROTECTED] http://bugs.python.org/issue2632 ___

[issue2632] performance problem in socket._fileobject.read

Antoine Pitrou [EMAIL PROTECTED] added the comment: If it's fixed in 2.6 and 3.0, it shouldn't be release blocker anymore, now should it? ___ Python tracker [EMAIL PROTECTED] http://bugs.python.org/issue2632 ___

[issue2632] performance problem in socket._fileobject.read

Benjamin Peterson [EMAIL PROTECTED] added the comment: Well, it's a release blocker for 2.5.3. -- nosy: +benjamin.peterson ___ Python tracker [EMAIL PROTECTED] http://bugs.python.org/issue2632 ___

[issue2632] performance problem in socket._fileobject.read

Ralf Schmitt [EMAIL PROTECTED] added the comment: Can we get the fix for release25-maint? It will not get worse than the current state is. ___ Python tracker [EMAIL PROTECTED] http://bugs.python.org/issue2632 ___

[issue2632] performance problem in socket._fileobject.read

Gregory P. Smith [EMAIL PROTECTED] added the comment: I'm going to let the committed change bake in Python trunk for a beta release or two before backporting it to release25-maint. __ Tracker [EMAIL PROTECTED] http://bugs.python.org/issue2632

[issue2632] performance problem in socket._fileobject.read

Changes by Georg Brandl [EMAIL PROTECTED]: -- priority: critical - release blocker __ Tracker [EMAIL PROTECTED] http://bugs.python.org/issue2632 __ ___ Python-bugs-list mailing

[issue2632] performance problem in socket._fileobject.read

Barry A. Warsaw [EMAIL PROTECTED] added the comment: Bumping this down to critical for the alpha release. It should be release blocker for the first beta. -- nosy: +barry priority: release blocker - critical __ Tracker [EMAIL PROTECTED]

[issue2632] performance problem in socket._fileobject.read

Ralf Schmitt [EMAIL PROTECTED] added the comment: the above easy_install now works for me. thanks. __ Tracker [EMAIL PROTECTED] http://bugs.python.org/issue2632 __ ___ Python-bugs-list

[issue2632] performance problem in socket._fileobject.read

Raghuram Devarakonda [EMAIL PROTECTED] added the comment: Similar problem is reported in #2760. __ Tracker [EMAIL PROTECTED] http://bugs.python.org/issue2632 __ ___ Python-bugs-list

[issue2632] performance problem in socket._fileobject.read

Gregory P. Smith [EMAIL PROTECTED] added the comment: I'm glad i put that assert in... The problem occurs due to a mixture of fixed size reads followed by unbounded readlines on an unbuffered _fileobject. A case that the code currently doesn't handle. I'm fixing it.

[issue2632] performance problem in socket._fileobject.read

Gregory P. Smith [EMAIL PROTECTED] added the comment: The bug introduced in r62627 has been fixed in r62744. __ Tracker [EMAIL PROTECTED] http://bugs.python.org/issue2632 __ ___

[issue2632] performance problem in socket._fileobject.read

Gregory P. Smith [EMAIL PROTECTED] added the comment: I fixed the min vs max use that Ralf noted and have submitted this as r62627. all tests pass for me but I believe it deserves a wider audience and testing outside of just the test suite. could those who reported the original problems (both

[issue2632] performance problem in socket._fileobject.read

Changes by Gregory P. Smith [EMAIL PROTECTED]: -- priority: critical - release blocker __ Tracker [EMAIL PROTECTED] http://bugs.python.org/issue2632 __ ___ Python-bugs-list

[issue2632] performance problem in socket._fileobject.read

Changes by Matthias Klose [EMAIL PROTECTED]: -- nosy: +doko __ Tracker [EMAIL PROTECTED] http://bugs.python.org/issue2632 __ ___ Python-bugs-list mailing list Unsubscribe:

[issue2632] performance problem in socket._fileobject.read

Gregory P. Smith [EMAIL PROTECTED] added the comment: available for an easy side by side review here: http://codereview.appspot.com/212 Also, yes I think you're right Ralf. With these changes I should be able to return that to a max() within the while True: for sized reads and things will

[issue2632] performance problem in socket._fileobject.read

Ralf Schmitt [EMAIL PROTECTED] added the comment: (I think the twisted issue your talking about is: http://twistedmatrix.com/trac/ticket/1079) Your patch still contains this code: recv_size = min(rbufsize, left) data = self._sock.recv(recv_size) This is IMHO

[issue2632] performance problem in socket._fileobject.read

Gregory P. Smith [EMAIL PROTECTED] added the comment: Twisted fixed their problem for issue 1092502 by making recv()ed data short lived by putting it into a StringIO for buffering. I've attached a patch that does that for the socket module -and- gets rid of any possibility of doing tiny size

[issue2632] performance problem in socket._fileobject.read

Changes by Forest Wilkinson [EMAIL PROTECTED]: -- nosy: +forest __ Tracker [EMAIL PROTECTED] http://bugs.python.org/issue2632 __ ___ Python-bugs-list mailing list Unsubscribe:

[issue2632] performance problem in socket._fileobject.read

Ralf Schmitt [EMAIL PROTECTED] added the comment: However it should be fixed in release25-maint. Can anyone install curt's patch? It does what the original fix intended to do. __ Tracker [EMAIL PROTECTED] http://bugs.python.org/issue2632

[issue2632] performance problem in socket._fileobject.read

Antoine Pitrou [EMAIL PROTECTED] added the comment: As A.M. Kuchling said in the other bug :), there is no need to fix 2.5.2 as the offending change is posterior to the release. By the way, somewhat really ought to close either this bug or #2601, discussing things in parallel in two different