[issue26353] IDLE: Saving Shell should not add \n

Zackery Spytz added the comment: Thank you, Terry, for modifying the PR and merging it. -- nosy: +ZackerySpytz ___ Python tracker ___

[issue26353] IDLE: Saving Shell should not add \n

Change by Terry J. Reedy : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker ___

[issue26353] IDLE: Saving Shell should not add \n

miss-islington added the comment: New changeset 8ce1a9ce038d1a5fda03ae76964002857a2a52f9 by Miss Islington (bot) in branch '3.8': bpo-26353: IDLE adds an unneeded newline when saving a shell window (GH-17103) https://github.com/python/cpython/commit/8ce1a9ce038d1a5fda03ae76964002857a2a52f9

[issue26353] IDLE: Saving Shell should not add \n

miss-islington added the comment: New changeset 177b12682cad7edf9cdea91382acc4232c0167e6 by Miss Islington (bot) in branch '3.7': bpo-26353: IDLE adds an unneeded newline when saving a shell window (GH-17103) https://github.com/python/cpython/commit/177b12682cad7edf9cdea91382acc4232c0167e6

[issue26353] IDLE: Saving Shell should not add \n

Change by miss-islington : -- pull_requests: +16625 pull_request: https://github.com/python/cpython/pull/17119 ___ Python tracker ___

[issue26353] IDLE: Saving Shell should not add \n

Terry J. Reedy added the comment: New changeset c8b53dc3d8f721ed8519aa5a35530a42fbfb9424 by Terry Jan Reedy (Zackery Spytz) in branch 'master': bpo-26353: IDLE adds an unneeded newline when saving a shell window (GH-17103)

[issue26353] IDLE: Saving Shell should not add \n

Change by miss-islington : -- pull_requests: +16624 pull_request: https://github.com/python/cpython/pull/17118 ___ Python tracker ___

[issue26353] IDLE: Saving Shell should not add \n

Terry J. Reedy added the comment: Zachary determined that the issue is that writing calls iomenu.IOBinding.fixlastline, which unconditionally adds \n at the end if there is one. That is not needed for the Shell and wrong when it ends with a prompt, which is the normal case. --

[issue26353] IDLE: Saving Shell should not add \n

Change by Zackery Spytz : -- keywords: +patch pull_requests: +16609 stage: test needed -> patch review pull_request: https://github.com/python/cpython/pull/17103 ___ Python tracker

[issue26353] IDLE: Saving Shell should not add \n

Changes by Terry J. Reedy : -- assignee: -> terry.reedy components: +IDLE ___ Python tracker ___

[issue26353] IDLE: Saving Shell should not add \n

New submission from Terry J. Reedy: When one saves the IDLE Shell window, at least when the cursor is at the prompt, \n is added, so that >>> | changes to >>> | This seems wrong. It does not happen in editor windows. I should check Output Windows. -- messages: 260205 nosy: