[issue26359] CPython build options for out-of-the box performance

Changes by Donald Stufft : -- pull_requests: +1048 ___ Python tracker ___ ___

[issue26359] CPython build options for out-of-the box performance

STINNER Victor added the comment: It seems like it's not possible to install Python configured with --enable-optimizations: see my issue #29641, "make install failure when using ./configure --enable-optimizations. -- ___ Python tracker

[issue26359] CPython build options for out-of-the box performance

Gregory P. Smith added the comment: per comments in issue28032 the new configure flag has been renamed from --with-optimizations to --enable-optimizations in all branches it was added to: remote: notified python-check...@python.org of incoming changeset c0ea81315fb6 remote: notified

[issue26359] CPython build options for out-of-the box performance

Gregory P. Smith added the comment: see https://bugs.python.org/issue28032 for flaws with --with-optimizations builds. -- ___ Python tracker ___

[issue26359] CPython build options for out-of-the box performance

Roundup Robot added the comment: New changeset 8567bc2876af by Gregory P. Smith in branch '2.7': document --with-optimizations in the README for issue26359. https://hg.python.org/cpython/rev/8567bc2876af -- ___ Python tracker

[issue26359] CPython build options for out-of-the box performance

Roundup Robot added the comment: New changeset e1987bf14148 by Gregory P. Smith in branch '3.5': document --with-optimizations in the README for issue26359. https://hg.python.org/cpython/rev/e1987bf14148 New changeset 4afb12077e08 by Gregory P. Smith in branch 'default': document

[issue26359] CPython build options for out-of-the box performance

Ned Deily added the comment: Thanks for the new option. Perhaps the top-level README should be updated to mention --with-optimizations? -- nosy: +ned.deily versions: +Python 3.5, Python 3.6 ___ Python tracker

[issue26359] CPython build options for out-of-the box performance

Changes by Gregory P. Smith : -- resolution: -> fixed stage: -> resolved status: open -> closed ___ Python tracker ___

[issue26359] CPython build options for out-of-the box performance

Roundup Robot added the comment: New changeset bc28cbd49070 by Gregory P. Smith in branch '2.7': Issue #26359: Add the --with-optimizations flag. https://hg.python.org/cpython/rev/bc28cbd49070 -- ___ Python tracker

[issue26359] CPython build options for out-of-the box performance

Changes by Gregory P. Smith : -- assignee: -> gregory.p.smith ___ Python tracker ___ ___

[issue26359] CPython build options for out-of-the box performance

Brett Cannon added the comment: Leaving this open in case someone wants to backport to 2.7. -- versions: -Python 3.5, Python 3.6 ___ Python tracker ___

[issue26359] CPython build options for out-of-the box performance

Roundup Robot added the comment: New changeset 1e61cc86df03 by Brett Cannon in branch '3.5': Issue #26359: Add the --with-optimizations flag. https://hg.python.org/cpython/rev/1e61cc86df03 New changeset f9b52b31f1b4 by Brett Cannon in branch 'default': Merge for #26359

[issue26359] CPython build options for out-of-the box performance

Roundup Robot added the comment: New changeset b4b73473ecc6 by Brett Cannon in branch 'default': Issue #26359: Add the --with-optimizations configure flag. https://hg.python.org/cpython/rev/b4b73473ecc6 -- nosy: +python-dev ___ Python tracker

[issue26359] CPython build options for out-of-the box performance

Changes by Brett Cannon : Removed file: http://bugs.python.org/file44411/issue26359.diff ___ Python tracker ___

[issue26359] CPython build options for out-of-the box performance

Brett Cannon added the comment: Patch with the missing Makefile.pre.in part :P -- Added file: http://bugs.python.org/file44412/issue26359.diff ___ Python tracker

[issue26359] CPython build options for out-of-the box performance

Brett Cannon added the comment: Here is modification of Greg's patch to turn off LTO under OS X since LTO+PGO do not get along under El Capitan. -- Added file: http://bugs.python.org/file44411/issue26359.diff ___ Python tracker

[issue26359] CPython build options for out-of-the box performance

Gregory P. Smith added the comment: Minor edit to avoid printing the message about --with-optimizations when doing a --with-pydebug build. otherwise this patch works well on Ubuntu xenial 16.04 amd64. >From discussions in the CPython Core Sprint room today - we've agreed that we >should

[issue26359] CPython build options for out-of-the box performance

Brett Cannon added the comment: So if I enable this manually, I get various test failures from modules on OS X El Capitan with the same type of failure: [ 95/398] test_bytes Traceback (most recent call last): File "/Users/brettcannon/Repositories/python/cpython/3.5/Lib/runpy.py", line 193,

[issue26359] CPython build options for out-of-the box performance

Changes by Brett Cannon : -- assignee: brett.cannon -> dependencies: +CPython fails to build modules with LLVM LTO on Mac OS X ___ Python tracker

[issue26359] CPython build options for out-of-the box performance

Brett Cannon added the comment: Just FYI, Alecsandru, I plan on applying your patches this week or next, so if you can just double-check they still apply cleanly that would be great. -- ___ Python tracker

[issue26359] CPython build options for out-of-the box performance

Alecsandru Patrascu added the comment: The patches in discussions are the v02 ones. -- ___ Python tracker ___

[issue26359] CPython build options for out-of-the box performance

Alecsandru Patrascu added the comment: I've updated the patch for 2.7 branch to contain the LTO part merged by Gregory. -- Added file: http://bugs.python.org/file43142/cpython2_with_optimizations_v02.patch ___ Python tracker

[issue26359] CPython build options for out-of-the box performance

Changes by Brett Cannon : -- assignee: -> brett.cannon ___ Python tracker ___ ___

[issue26359] CPython build options for out-of-the box performance

Alecsandru Patrascu added the comment: Hello Brett, I saw that there was no other activity on this issue so far. Can you please update this, as I do not have rights? -- ___ Python tracker

[issue26359] CPython build options for out-of-the box performance

Brett Cannon added the comment: Just leave a comment next week in the issue if no one else beats me to the issue (I'm at OSCON so I don't have time to commit until May 24 at the earliest). -- ___ Python tracker

[issue26359] CPython build options for out-of-the box performance

Alecsandru Patrascu added the comment: Brett, I tried to add you in the "assigned to", but I do not have any rights to update those :( -- ___ Python tracker

[issue26359] CPython build options for out-of-the box performance

Alecsandru Patrascu added the comment: I've attached a cleaner version for CPython 3 and one for CPython 2. The problem with CPython 2 is that Gregory did not yet merged the LTO on this branch (#25702), but as soon as he does it, I'll post updated patches. Regards, Alecsandru --

[issue26359] CPython build options for out-of-the box performance

Changes by Alecsandru Patrascu : Added file: http://bugs.python.org/file42872/cpython3_with_optimizations_v02.patch ___ Python tracker

[issue26359] CPython build options for out-of-the box performance

Changes by Alecsandru Patrascu : Added file: http://bugs.python.org/file42871/cpython2_with_optimizations_v01.patch ___ Python tracker

[issue26359] CPython build options for out-of-the box performance

Brett Cannon added the comment: The patch LGTM but I'm not a configure/make expert. Anyone else want to have a look? Alecsandru, if no one takes a look within the next week then just assign the issue to me. -- ___ Python tracker

[issue26359] CPython build options for out-of-the box performance

Alecsandru Patrascu added the comment: I've added the --with-optimizations option to configure, for CPython3 only at this point. If it looks good I'll create a version also for CPython2. -- Added file: http://bugs.python.org/file42576/cpython3_with_optimizations_v01.patch

[issue26359] CPython build options for out-of-the box performance

Alecsandru Patrascu added the comment: That sounds like a good idea and plan, to have everything enabled with just one dedicated configure flag. I can work on this and post the patches as soon as they are done. Thank you -- ___ Python tracker

[issue26359] CPython build options for out-of-the box performance

Gregory P. Smith added the comment: --with-optimizations seems fine. As does having the final thing the Makefile prints out when run from a configuration that did not specify any of --with-pgo, --with-lto, --with-pydebug, or --with-optimizations be to echo message reminding people to

[issue26359] CPython build options for out-of-the box performance

Brett Cannon added the comment: What if we added a --with-optimizations flag to build --with-pgo, --with-lto, and avoid having to run `make` twice thanks to `make`/`make profileopt`? That way the default build is still quick and reasonable but gain a simple way to use the right flags and

[issue26359] CPython build options for out-of-the box performance

Steve Dower added the comment: FWIW, I'm also against enabling it by default due to the extended build time. There are plenty of reasons to build Python with the non-debug ABI that don't require extended optimizations. Production builds are the exception I believe, not the rule. --

[issue26359] CPython build options for out-of-the box performance

Alecsandru Patrascu added the comment: Maybe that end users are lazy and want to type just `make` and let things happen magically behind the scenes :-) -- ___ Python tracker

[issue26359] CPython build options for out-of-the box performance

Stefan Krah added the comment: Not acceptable, I'm afraid. See #25702. I'm not sure why it is considered so bothersome to type --with-pgo and --with-lto for the rare case of a real production build. -- ___ Python tracker

[issue26359] CPython build options for out-of-the box performance

Alecsandru Patrascu added the comment: Hello Victor, Indeed, the best outcome is to have PGO, LTO, etc enabled by default when running ./configure && make, for production level. I also feel that they should be on by default, if only developers would use the debug version. Do you think that

[issue26359] CPython build options for out-of-the box performance

STINNER Victor added the comment: Sorry, I don't understand this issue. I don't think that we need 3 flavors: debug, devel and release. We already have debug (--with-pydebug) and release, and IMHO debug is what developers should use. I like the idea of using the best optimizers options *by

[issue26359] CPython build options for out-of-the box performance

Changes by Alecsandru Patrascu : -- nosy: +brett.cannon, gregory.p.smith, lemburg, pitrou, r.david.murray, scoder, skrah, steve.dower, zach.ware ___ Python tracker

[issue26359] CPython build options for out-of-the box performance

Changes by SilentGhost : -- nosy: +haypo ___ Python tracker ___ ___ Python-bugs-list

[issue26359] CPython build options for out-of-the box performance

New submission from Alecsandru Patrascu: Hello, This is Alecsandru from the Dynamic Scripting Languages Optimization Team at Intel Corporation. I would like to submit a patch as a response to the discussion thread opened in Python-Dev

[issue26359] CPython build options for out-of-the box performance

Changes by Alecsandru Patrascu : Added file: http://bugs.python.org/file41919/cpython3_pgo_default-v02.patch ___ Python tracker