[issue26390] hashlib's pbkdf2_hmac documentation "rounds" does not match source

Changes by Martin Panter : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker ___

[issue26390] hashlib's pbkdf2_hmac documentation "rounds" does not match source

Roundup Robot added the comment: New changeset 7609aaf180b4 by Martin Panter in branch '3.5': Issue #26390: Fix and test pbkdf2_hmac() parameter names https://hg.python.org/cpython/rev/7609aaf180b4 New changeset a74420677e6b by Martin Panter in branch 'default': Issue #26390: Merge

[issue26390] hashlib's pbkdf2_hmac documentation "rounds" does not match source

Martin Panter added the comment: Here is an updated patch. I also fixed the hash_name parameter, some more minor offences in the documentation, and added a test case. -- Added file: http://bugs.python.org/file42002/pbkdf2_6.patch ___ Python tracker

[issue26390] hashlib's pbkdf2_hmac documentation "rounds" does not match source

Daan Bakker added the comment: Good catch. I updated that reference now from rounds to iterations as well. -- Added file: http://bugs.python.org/file41969/pbkdf2_5.patch ___ Python tracker

[issue26390] hashlib's pbkdf2_hmac documentation "rounds" does not match source

Martin Panter added the comment: Thanks for the patch. The documentation still mentions *rounds* in one place, which I presume was meant to be a direct reference to the parameter. -- nosy: +martin.panter stage: -> patch review versions: -Python 3.4

[issue26390] hashlib's pbkdf2_hmac documentation "rounds" does not match source

New submission from Daan Bakker: The documentation for pbkdf2_hmac at https://docs.python.org/3/library/hashlib.html uses the "rounds" keyword: hashlib.pbkdf2_hmac(name, password, salt, rounds, dklen=None) However, the actual source code uses "iterations". No-one has probably noticed it