[issue26609] Wrong request target in test_httpservers.py

[Martin Panter]

Martin Panter added the comment:

Thanks for the patch

--
resolution:  -> fixed
stage: patch review -> resolved
status: open -> closed
versions: +Python 2.7, Python 3.5

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue26609] Wrong request target in test_httpservers.py

[Roundup Robot]

Roundup Robot added the comment:

New changeset 4f64b1c87a56 by Martin Panter in branch '2.7':
Issue #26609: Fix up Python 2 port
https://hg.python.org/cpython/rev/4f64b1c87a56

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue26609] Wrong request target in test_httpservers.py

[Roundup Robot]

Roundup Robot added the comment:

New changeset 0e19f421dc9e by Martin Panter in branch '3.5':
Issue #26609: Fix HTTP server tests to request an absolute URL path
https://hg.python.org/cpython/rev/0e19f421dc9e

New changeset 34ebf79acd78 by Martin Panter in branch 'default':
Issue #26609: Merge HTTP tests from 3.5
https://hg.python.org/cpython/rev/34ebf79acd78

New changeset 2691f81a89a7 by Martin Panter in branch '2.7':
Issue #26609: Fix HTTP server tests to request an absolute URL path
https://hg.python.org/cpython/rev/2691f81a89a7

--
nosy: +python-dev

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue26609] Wrong request target in test_httpservers.py

[Xiang Zhang]

Xiang Zhang added the comment:

Get the slash prefixed path in Setup() is a good idea. I change the patch. I 
retain self.tempdir_name so we can use it in a test for no leading slash. The 
case creating index.html is OK with self.tempdir_name since we have changed our 
working directory to basetempdir.

I didn't think about compatibility but I know it's important. So rejecting the 
invalid request-targets is not a good idea to me now.

--
Added file: 
http://bugs.python.org/file42369/request_target_in_test_httpservers_v2.patch

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue26609] Wrong request target in test_httpservers.py

[Martin Panter]

Martin Panter added the comment:

Perhaps tempdir_name could get the slash prefixed in setUp() rather than in 
every test. There is one case that creates index.html which could probably be 
changed to use self.tempdir, and then the rest could be renamed to say 
self.base_url.

Rejecting requests that do not start with a slash could be a compatibility 
problem. Do you think potential security benefits (i.e. having unexpected 
variations on the format of the URL) outweigh that?

Either way, it would be good to retain a test without a slash.

--
stage:  -> patch review

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue26609] Wrong request target in test_httpservers.py

[Xiang Zhang]

New submission from Xiang Zhang:

When requesting a resource from an origin server, the request-target in request 
line should always starts with a back slash. But in SimpleHTTPServerTestCase in 
test_httpservers.py, almost all the requests are sent without the back slash 
though the handler handles it well. The request lines are like 'GET tmpX 
HTTP/1.1'. I add the back slashes.

Maybe in SimpleHTTPRequestHandler, we should reject such invalid 
request-targets and then return BAD_REQUEST. And then issue2254 won't happen.

--
components: Library (Lib)
files: request_target_in_test_httpservers.patch
keywords: patch
messages: 262171
nosy: martin.panter, xiang.zhang
priority: normal
severity: normal
status: open
title: Wrong request target in test_httpservers.py
versions: Python 3.6
Added file: 
http://bugs.python.org/file42243/request_target_in_test_httpservers.patch

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com