[issue2661] Mapping tests cannot be passed by user implementations

Change by Cheryl Sabella : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed versions: +Python 3.9 -Python 2.7, Python 3.2, Python 3.3 ___ Python tracker _

[issue2661] Mapping tests cannot be passed by user implementations

miss-islington added the comment: New changeset 6af230359e57122708247dac970e05e05529cde6 by Miss Islington (bot) (Walter Dörwald) in branch 'master': bpo-2661: Make mapping tests better usable for custom mapping classes. (GH-11157) https://github.com/python/cpython/commit/6af230359e5712270824

[issue2661] Mapping tests cannot be passed by user implementations

Walter Dörwald added the comment: OK, I've created the pull request (11157). -- ___ Python tracker ___ ___ Python-bugs-list mailing l

[issue2661] Mapping tests cannot be passed by user implementations

Change by Walter Dörwald : -- pull_requests: +10390 stage: needs patch -> patch review ___ Python tracker ___ ___ Python-bugs-list mai

[issue2661] Mapping tests cannot be passed by user implementations

Change by Mark Lawrence : -- nosy: -BreamoreBoy ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.

[issue2661] Mapping tests cannot be passed by user implementations

Serhiy Storchaka added the comment: Walter, do you mind to create a PR? -- nosy: +serhiy.storchaka ___ Python tracker ___ ___ Python

[issue2661] Mapping tests cannot be passed by user implementations

Walter Dörwald added the comment: Here is a patch that implements suggestion 2 and 3. -- keywords: +patch Added file: http://bugs.python.org/file35800/mapping-tests.diff ___ Python tracker __

[issue2661] Mapping tests cannot be passed by user implementations

Mark Lawrence added the comment: @Walter/Raymond as there is still no patch for this issue do you want to leave it open just in case anybody wants to work on it, move it to langushing, close it or what? -- nosy: +BreamoreBoy ___ Python tracker

[issue2661] Mapping tests cannot be passed by user implementations

Éric Araujo added the comment: > I think it would be great to test the stdlib’s mapping classes against common > tests grep told me that most of them already do. Sorry for the noise, it’s late/soon here. -- ___ Python tracker

[issue2661] Mapping tests cannot be passed by user implementations

Éric Araujo added the comment: I think it would be great to test the stdlib’s mapping classes against common tests; there is a patch to add more MutableMapping methods to dbm classes for example, and it was not trivial to get good test coverage. Not sure about the status of the module though,

[issue2661] Mapping tests cannot be passed by user implementations

Walter Dörwald added the comment: Any custom mapping class should have a repr test anyway, so IMHO it doesn't matter whether the base test has a repr test or not. The suggested fixes for TestMappingProtocol.test_fromkeys() and TestHashMappingProtocol.test_mutatingiteration() sound OK however.

[issue2661] Mapping tests cannot be passed by user implementations

Raymond Hettinger added the comment: Walter, this is your code. Care to incorporate any of David's ideas? David, for my own code, the usual technique for something like test_repr() is to subclass TestHashMappingProtocol and override the test method with a customized test_repr() method. --

[issue2661] Mapping tests cannot be passed by user implementations

Changes by Antoine Pitrou : -- nosy: +rhettinger ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.pyt

[issue2661] Mapping tests cannot be passed by user implementations

Changes by Daniel Diniz : -- components: +Tests priority: -> normal versions: +Python 3.1 -Python 3.0 ___ Python tracker ___ ___ Pytho

[issue2661] Mapping tests cannot be passed by user implementations

New submission from David Anderson <[EMAIL PROTECTED]>: Some test cases in Lib/test/mapping_tests.py are problematic for users wishing to test their own implementations of the mapping protocol: - TestHashMappingProtocol.test_repr() requires the user implementations to look like a dict when rep