[issue26664] Misuse of $ in activate.fish of venv

László Károlyi added the comment: +1 here, broken on homebrew cpython > 3.5.1 (a.k.a. 3.5.2) -- nosy: +karolyi ___ Python tracker ___

[issue26664] Misuse of $ in activate.fish of venv

Xiang Zhang added the comment: Since the bug is fixed, we can also close issue26348. -- ___ Python tracker ___

[issue26664] Misuse of $ in activate.fish of venv

Brett Cannon added the comment: I wish it was a two-click fix. It's actually a fix-in-3.5-then-test-then-update-Misc/NEWS-then-commit-then-merge-then-verify-again-then-commit-then-push-then-update-the-issue (IOW it's about 8 separate steps). -- ___

[issue26664] Misuse of $ in activate.fish of venv

erdban fed added the comment: > Activation doesn't "load" the Python interpreter in the venv; all it does is > tweak shell variables to put the interpreter in venv early on PATH. I'm aware. > You have to realize that ... I know it's often a thankless task and that mistakes can and do happen.

[issue26664] Misuse of $ in activate.fish of venv

Tin Tvrtković added the comment: Thanks for dealing with this, Brett, your efforts are appreciated. :) On Thu, Jun 30, 2016 at 9:24 PM Brett Cannon wrote: > > Brett Cannon added the comment: > > Activation doesn't "load" the Python interpreter in the venv; all it does

[issue26664] Misuse of $ in activate.fish of venv

Brett Cannon added the comment: Activation doesn't "load" the Python interpreter in the venv; all it does is tweak shell variables to put the interpreter in venv early on PATH. I personally never use the activate.* scripts and simply directly execute the Python interpreter, e.g.

[issue26664] Misuse of $ in activate.fish of venv

erdban fed added the comment: > Two, this is not a release blocker. Python itself continues to function > properly with this bug and it doesn't prevent you from working with a venv > under fish (but I recognize it's an annoyance). If you can't load the venv, I think that pretty definitely

[issue26664] Misuse of $ in activate.fish of venv

Brett Cannon added the comment: Two things. One, sorry for not getting to this before 3.5.1 got out. It simply slipped off my radar thanks to various other issues that I've been dealing with. It's obviously now fixed. Two, this is not a release blocker. Python itself continues to function

[issue26664] Misuse of $ in activate.fish of venv

Roundup Robot added the comment: New changeset 8d7bde14d7a4 by Brett Cannon in branch 'default': Merge from 3.5 for issue #26664 https://hg.python.org/cpython/rev/8d7bde14d7a4 -- nosy: +python-dev ___ Python tracker

[issue26664] Misuse of $ in activate.fish of venv

Changes by Brett Cannon : -- title: find a bug in activate.fish of venv of cpython3.6 -> Misuse of $ in activate.fish of venv ___ Python tracker