[issue26763] Update PEP-8 regarding binary operators

[Chris Angelico]

Chris Angelico added the comment:

Typo fixed in peps repo.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue26763] Update PEP-8 regarding binary operators

[Guido van Rossum]

Guido van Rossum added the comment:

OK, maybe @chrisa can fix the typo.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue26763] Update PEP-8 regarding binary operators

[Martín Gaitán]

Martín Gaitán added the comment:

There is a typo on "reseach" instead of "research"

--
nosy: +Martín Gaitán

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue26763] Update PEP-8 regarding binary operators

[Barry A. Warsaw]

Changes by Barry A. Warsaw :


--
nosy: +barry

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue26763] Update PEP-8 regarding binary operators

[Guido van Rossum]

Guido van Rossum added the comment:

I propose to keep the somewhat questionable examples in the PEP as an
illustration of the idea that style is debatable and cannot be reduced to
fixed rules.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue26763] Update PEP-8 regarding binary operators

[Ian Lee]

Ian Lee added the comment:

> Aren't there many other examples in the PEP that need to be adjusted, since 
> we're changing the style not just for 'and' and 'or' but for all binary 
> operators?

Admittedly I'd only looked in that one section last night, but I just went 
through the PEP and didn't see any other when I just went through the entire 
PEP now...

> I also think the PEP needs some language about the previous style being still 
> acceptable as long as it's being used consistently (Knuth notwithstanding), 
> and an acceptable compromise style where and/or go at the start of the line 
> but other binary operators stay at the end.

I'd updated my branch on GitHub [1] but Guido, you beat me to the update while 
I was typing this message!

> I don't like the way "):" is indented in that example.

Honestly I don't either, I just like it more than artificially pushing the 
other lines forward a space. Personally, I'm not a fan of the current change 
either which puts the raise in line with the condition logic for the `if`::

if (width == 0
and height == 0
and color == 'red'
and emphasis == 'strong'
or highlight > 100):
raise ValueError("sorry, you lose")


My preference is to actually break that logic up and avoid the wrapping in the 
first place, as in [2]. Which in this particular class has the side benefit of 
that value being used again in the same function anyways.

I'm starting to realize that Brandon Rhodes really had a big impact on my ideas 
of styling as I've been learning Python these past few years, as this was 
another one style I'm stealing from that same talk [3].

> I've updated the PEP...

Great, thanks! I've created a ticket in pycodestyle [4] to update the style 
checker, which in turn will fix the flake8 error downstream once I get around 
(hopefully before PyCon) to releasing pycodestyle 1.8.0

[1] https://github.com/python/peps/compare/master...IanLee1521:issue26763
[2] 
https://github.com/python/peps/commit/0c790e7b721bd13ad12ab9e6f6206836f398f9c4
[3] 
http://rhodesmill.org/brandon/slides/2012-11-pyconca/#naming-intermediate-values
[4] https://github.com/PyCQA/pycodestyle/issues/498

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue26763] Update PEP-8 regarding binary operators

[Guido van Rossum]

Guido van Rossum added the comment:

I've updated the PEP with some more permissive language, mentioning Knuth's 
recommendation but allowing the old style because it's been recommended (and 
followed, and enforced) for decades. I've intentionally not updated other 
examples in the PEP to follow suit.

--
resolution:  -> fixed
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue26763] Update PEP-8 regarding binary operators

[Guido van Rossum]

Guido van Rossum added the comment:

> Changing indentation level based on operator precedence is acceptable?

I think that's a matter of personal taste and I don't think the PEP needs to 
have an opinion on it.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue26763] Update PEP-8 regarding binary operators

[INADA Naoki]

INADA Naoki added the comment:

On Fri, Apr 15, 2016 at 11:31 PM, Guido van Rossum 
wrote:

>
> Guido van Rossum added the comment:
>
> I don't like the way "):" is indented in that example.

Me too.
I haven't know about this PEP8 update.
https://github.com/python/peps/commit/843b7d2cdb954dc0aa5ea70f140db2bd42943e1f

> I propose:
>
> if ((width == 0
>  and height == 0
>  and color == 'red'
>  and emphasis == 'strong')
> or highlight > 100):
>
>
Looks better to me.  But how about this?

if (width == 0
and height == 0
and color == 'red'
and emphasis == 'strong'
or highlight > 100):

Changing indentation level based on operator precedence is acceptable?

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue26763] Update PEP-8 regarding binary operators

[Guido van Rossum]

Guido van Rossum added the comment:

I don't like the way "):" is indented in that example. I propose:

if ((width == 0
 and height == 0
 and color == 'red'
 and emphasis == 'strong')
or highlight > 100):

Aren't there many other examples in the PEP that need to be adjusted, since 
we're changing the style not just for 'and' and 'or' but for all binary 
operators?

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue26763] Update PEP-8 regarding binary operators

[Guido van Rossum]

Guido van Rossum added the comment:

I also think the PEP needs some language about the previous style being still 
acceptable as long as it's being used consistently (Knuth notwithstanding), and 
an acceptable compromise style where and/or go at the start of the line but 
other binary operators stay at the end.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue26763] Update PEP-8 regarding binary operators

[INADA Naoki]

INADA Naoki added the comment:

How about recommend using parentheses to avoid different level operators have 
same indent level?

ok:
if (width == 0
and height == 0
and color == 'red'
and emphasis == 'strong'
or highlight > 100
):
...

better:
if ((width == 0
 and height == 0
 and color == 'red'
 and emphasis == 'strong')
or highlight > 100
):

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue26763] Update PEP-8 regarding binary operators

[Berker Peksag]

Berker Peksag added the comment:

Please don't create a pull request on GitHub (python/peps is read-only). 
Attaching wrap-before-binary-operator.patch is enough.

--
nosy: +berker.peksag
stage:  -> patch review

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue26763] Update PEP-8 regarding binary operators

[INADA Naoki]

INADA Naoki added the comment:

Roundup doesn't link to Github's branch comparing URL correctly.
How about just create pull request on Github?

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue26763] Update PEP-8 regarding binary operators

[INADA Naoki]

INADA Naoki added the comment:

https://github.com/python/peps/compare/master...IanLee1521:issue26763

--
nosy: +naoki

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue26763] Update PEP-8 regarding binary operators

[Chris Angelico]

Changes by Chris Angelico :


--
nosy: +Rosuav

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue26763] Update PEP-8 regarding binary operators

[Ian Lee]

Ian Lee added the comment:

Link to GitHub branch with the patch as a commit [1].

[1] https://github.com/python/peps/compare/master...IanLee1521:issue26763

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue26763] Update PEP-8 regarding binary operators

[Ian Lee]

Ian Lee added the comment:

Discussion link missing from msg263453: 
https://mail.python.org/pipermail/python-ideas/2016-April/039774.html

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue26763] Update PEP-8 regarding binary operators

[Ian Lee]

New submission from Ian Lee:

Following up from discussion on python-ideas [1] about updating PEP-8 regarding 
wrapping lines before rather than after binary operators.

--
files: wrap-before-binary-operator.patch
keywords: patch
messages: 263453
nosy: IanLee1521, gvanrossum
priority: normal
severity: normal
status: open
title: Update PEP-8 regarding binary operators
type: enhancement
Added file: http://bugs.python.org/file42463/wrap-before-binary-operator.patch

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com