[issue26783] test_os.WalkTests.test_walk_topdown don't test fwalk and Bytes

[Roundup Robot]

Roundup Robot added the comment:

New changeset e44a2dc62c11 by Serhiy Storchaka in branch '3.5':
Issue #26783: test_os.WalkTests.test_walk_topdown did't test fwalk and bytes.
https://hg.python.org/cpython/rev/e44a2dc62c11

New changeset be96434b8777 by Serhiy Storchaka in branch 'default':
Issue #26783: test_os.WalkTests.test_walk_topdown did't test fwalk and bytes.
https://hg.python.org/cpython/rev/be96434b8777

--
nosy: +python-dev

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue26783] test_os.WalkTests.test_walk_topdown don't test fwalk and Bytes

[Serhiy Storchaka]

Changes by Serhiy Storchaka :


--
resolution:  -> fixed
stage: commit review -> resolved
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue26783] test_os.WalkTests.test_walk_topdown don't test fwalk and Bytes

[Serhiy Storchaka]

Serhiy Storchaka added the comment:

The patch LGTM. Thank you Aviv.

--
assignee:  -> serhiy.storchaka
nosy: +serhiy.storchaka
stage:  -> commit review
type:  -> behavior
versions: +Python 3.5

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue26783] test_os.WalkTests.test_walk_topdown don't test fwalk and Bytes

[Aviv Palivoda]

New submission from Aviv Palivoda:

test_walk_topdown call os.walk directly instead of using self.walk. This test 
currently run 3 time's while checking the same thing. The test should use 
self.walk to check fwalk and Bytes as well.

--
components: Tests
files: os-test-walk-topdown-use-self-walk.patch
keywords: patch
messages: 263558
nosy: loewis, palaviv
priority: normal
severity: normal
status: open
title: test_os.WalkTests.test_walk_topdown don't test fwalk and Bytes
versions: Python 3.6
Added file: 
http://bugs.python.org/file42492/os-test-walk-topdown-use-self-walk.patch

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com