[issue26851] android compilation and link flags

Changes by Donald Stufft : -- pull_requests: +932 ___ Python tracker ___ ___

[issue26851] android compilation and link flags

Xavier de Gaye added the comment: > Just tried. With my packaging scripts, CPython on ARM is compiled with > -mfloat-abi=softfp -mfpu=vfpv3-d16 while libffi not. test_ctypes pass as > usual. This works as expected, '-mfloat-abi=softfp' and the default '-mfloat-abi=soft' use the same ABI [1]:

[issue26851] android compilation and link flags

Chi Hsuan Yen added the comment: > Note that the system libffi must also be compiled with these same flags Just tried. With my packaging scripts, CPython on ARM is compiled with -mfloat-abi=softfp -mfpu=vfpv3-d16 while libffi not. test_ctypes pass as usual. Maybe ctypes test suite is not

[issue26851] android compilation and link flags

Xavier de Gaye added the comment: In the code review Victor asked the following question: > I'm a little bit surprised that you need to pass so much options which are > specific to the platform. GCC doesn't have a generic option "hello, please > compile for my architecture?" ARM defines two

[issue26851] android compilation and link flags

Xavier de Gaye added the comment: Latest patch committed with the following simplification: BASECFLAGS and LDFLAGS are now set for armv7 at the same place, as suggested by Martin in msg271518. -- resolution: -> fixed stage: patch review -> resolved status: open -> closed

[issue26851] android compilation and link flags

Roundup Robot added the comment: New changeset fa2bc63e64c6 by Xavier de Gaye in branch '3.6': Issue #26851: Set Android compilation and link flags. https://hg.python.org/cpython/rev/fa2bc63e64c6 New changeset af363b5200ff by Xavier de Gaye in branch 'default': Issue #26851: Merge 3.6.

[issue26851] android compilation and link flags

Changes by Xavier de Gaye : -- versions: +Python 3.6 ___ Python tracker ___ ___

[issue26851] android compilation and link flags

Xavier de Gaye added the comment: This new patch fixes the following: * Use BASECFLAGS instead of CCSHARED. * '-march=armv7-a' is not set in BASECFLAGS anymore as this is redundant: this option is already set in the configure command line or is implicitly set by the the first component of the

[issue26851] android compilation and link flags

Xavier de Gaye added the comment: See also the clang cross compilation documentation at http://clang.llvm.org/docs/CrossCompilation.html. -- versions: +Python 3.7 -Python 3.6 ___ Python tracker

[issue26851] android compilation and link flags

Changes by Chi Hsuan Yen : -- nosy: +Chi Hsuan Yen ___ Python tracker ___ ___

[issue26851] android compilation and link flags

Xavier de Gaye added the comment: Yes, the packager must use appropriately either CFLAGS CPPFLAGS [1] and LDFLAGS, or CC. I am using: CC="clang --sysroot=$(SYSROOT) -target $(TARGET) -gcc-toolchain $(GCC_TOOLCHAIN)". [1] See issue 27453, for the remaining problem upon using CPPFLAGS.

[issue26851] android compilation and link flags

Martin Panter added the comment: Where is the code that sets the clang -target argument, or gcc -march? Is it hidden away somewhere in the autoconf code? Do you manually set it with ‘./configure CFLAGS="-target . . ." ’? -- ___ Python tracker

[issue26851] android compilation and link flags

Xavier de Gaye added the comment: > I am still curious what configures the preprocessor to set __ARM_ARCH to 7 (I > guess the clang -target argument?) Yes, the -target clang argument or the -march gcc argument. > and why we can’t set LDFLAGS at the same time or place. Is it just more >

[issue26851] android compilation and link flags

Martin Panter added the comment: All the bits that I understand look okay now. :) I am still curious what configures the preprocessor to set __ARM_ARCH to 7 (I guess the clang -target argument?), and why we can’t set LDFLAGS at the same time or place. Is it just more convenient this way?

[issue26851] android compilation and link flags

Xavier de Gaye added the comment: New patch. The sed commands used to evaluate ANDROID_API_LEVEL and _arm_arch do not need to discard comment lines and empty lines in the output of the preprocessor. -- Added file: http://bugs.python.org/file43893/build-flags_4.patch

[issue26851] android compilation and link flags

Xavier de Gaye added the comment: Thanks for the suggestion, I won't include them anymore in patches then. -- ___ Python tracker ___

[issue26851] android compilation and link flags

STINNER Victor added the comment: Note: build-flags_3.patch includes configure.ac and configure. Usually, we suggest to not included generated files (configure) in patches, but push them when the patch is ready. -- ___ Python tracker

[issue26851] android compilation and link flags

Xavier de Gaye added the comment: The first 'build-flags_3.patch' file that was uploaded did not get a review button because ssh://h...@hg.python.org/cpython was down at that time. The second upload has been successfull ! -- ___ Python tracker

[issue26851] android compilation and link flags

Changes by Xavier de Gaye : Added file: http://bugs.python.org/file43878/build-flags_3.patch ___ Python tracker ___

[issue26851] android compilation and link flags

Xavier de Gaye added the comment: Thanks for the review and the suggestions Martin :) New patch. -- Added file: http://bugs.python.org/file43875/build-flags_3.patch ___ Python tracker

[issue26851] android compilation and link flags

Martin Panter added the comment: I left some suggestions and questions on the code review. -- ___ Python tracker ___

[issue26851] android compilation and link flags

Changes by Xavier de Gaye : -- nosy: +twouters ___ Python tracker ___ ___ Python-bugs-list

[issue26851] android compilation and link flags

New submission from Xavier de Gaye: The attached patch: * Sets the recommended android compilation flags, see: http://developer.android.com/ndk/guides/standalone_toolchain.html#abi. Note that the android toolchains already set the -fpic flag, as shown with: arm-linux-androideabi-gcc