[issue27015] subprocess.CalledProcessError's repr changes based on kwargs, and doesn't unpickle

[Nick Coghlan]

Nick Coghlan  added the comment:

Reviewing Rémi's page made me realise that a big part of the root cause here is 
pickle support in exceptions predating the introduction of `__getnewargs__` and 
`__getnewargs_ex__`.

--
nosy: +ncoghlan

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue27015] subprocess.CalledProcessError's repr changes based on kwargs, and doesn't unpickle

[Nick Coghlan]

Change by Nick Coghlan :


--
pull_requests:  -11260

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue27015] subprocess.CalledProcessError's repr changes based on kwargs, and doesn't unpickle

[Nick Coghlan]

Change by Nick Coghlan :


--
pull_requests:  -11261

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue27015] subprocess.CalledProcessError's repr changes based on kwargs, and doesn't unpickle

[Rémi Lapeyre]

Rémi Lapeyre  added the comment:

I tried to fix the issue, the attached PR solves the issue of saving the kwargs 
and unpickling the exception but I was not able to fix a regression I caused in 
test_memory_error_in_PyErr_PrintEx.

--
versions: +Python 3.6, Python 3.7, Python 3.8

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue27015] subprocess.CalledProcessError's repr changes based on kwargs, and doesn't unpickle

[Rémi Lapeyre]

Change by Rémi Lapeyre :


--
keywords: +patch, patch, patch
pull_requests: +11260, 11261, 11262
stage:  -> patch review

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue27015] subprocess.CalledProcessError's repr changes based on kwargs, and doesn't unpickle

[Rémi Lapeyre]

Change by Rémi Lapeyre :


--
keywords: +patch, patch
pull_requests: +11260, 11261
stage:  -> patch review

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue27015] subprocess.CalledProcessError's repr changes based on kwargs, and doesn't unpickle

[Rémi Lapeyre]

Change by Rémi Lapeyre :


--
keywords: +patch
pull_requests: +11260
stage:  -> patch review

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue27015] subprocess.CalledProcessError's repr changes based on kwargs, and doesn't unpickle

[Rémi Lapeyre]

Change by Rémi Lapeyre :


--
nosy: +remi.lapeyre

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue27015] subprocess.CalledProcessError's repr changes based on kwargs, and doesn't unpickle

[Serhiy Storchaka]

Serhiy Storchaka added the comment:

This is a problem not only with CalledProcessError, but with all custom 
exceptions with overridden __init__. BaseException.__new__ saves positional 
arguments as the "args" attribute, but ignores keyword arguments. repr() and 
pickle use "args".

--
nosy: +astrand, gregory.p.smith, serhiy.storchaka

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue27015] subprocess.CalledProcessError's repr changes based on kwargs, and doesn't unpickle

[Taywee]

New submission from Taywee:

When using kwargs to construct a CalledProcessError, the repr doesn't show 
those args, and using kwargs also breaks pickling:

>>> import pickle; from subprocess import CalledProcessError
>>> CalledProcessError(2, 'foo')
CalledProcessError(2, 'foo')
>>> CalledProcessError(2, 'foo').returncode
2
>>> CalledProcessError(2, 'foo').cmd
'foo'
>>> CalledProcessError(returncode=2, cmd='foo')
CalledProcessError()
>>> CalledProcessError(returncode=2, cmd='foo').returncode
2
>>> CalledProcessError(returncode=2, cmd='foo').cmd
'foo'
>>> pickle.loads(pickle.dumps(CalledProcessError(2, 'foo')))
CalledProcessError(2, 'foo')
>>> pickle.loads(pickle.dumps(CalledProcessError(returncode=2, cmd='foo')))
Traceback (most recent call last):
  File "", line 1, in 
TypeError: __init__() missing 2 required positional arguments: 'returncode' and 
'cmd'
>>>

--
components: Library (Lib)
messages: 265482
nosy: Taywee
priority: normal
severity: normal
status: open
title: subprocess.CalledProcessError's repr changes based on kwargs, and 
doesn't unpickle
type: behavior
versions: Python 3.4, Python 3.5

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com