[issue27033] Change the decode_data default in smtpd to False

R. David Murray added the comment: Yes. Thanks, Serhiy. -- resolution: -> fixed stage: commit review -> resolved status: open -> closed ___ Python tracker ___ _

[issue27033] Change the decode_data default in smtpd to False

Serhiy Storchaka added the comment: Can this issue be closed? -- ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue27033] Change the decode_data default in smtpd to False

Roundup Robot added the comment: New changeset 71813a05e488 by Serhiy Storchaka in branch 'default': Issue #27033: Removed unnecessary the bool calls. https://hg.python.org/cpython/rev/71813a05e488 -- ___ Python tracker

[issue27033] Change the decode_data default in smtpd to False

R. David Murray added the comment: Python uses duck typing, though. Maybe someone is depending on those public attributes not getting coerced to boolean. Probably not, granted, since they are newish, but a python programmer might expect the value to get passed through. I'm of two minds abou

[issue27033] Change the decode_data default in smtpd to False

Roundup Robot added the comment: New changeset 9abde519cc1e by Serhiy Storchaka in branch 'default': Improved docs for issue27033. Based on comments by R. David Murray. https://hg.python.org/cpython/rev/9abde519cc1e -- ___ Python tracker

[issue27033] Change the decode_data default in smtpd to False

Serhiy Storchaka added the comment: Since these arguments are saved for multiple testing, it is worth to ensure that every test returns consistent result. For public attribute there is additional benefit, it looks as boolean. -- ___ Python tracker

[issue27033] Change the decode_data default in smtpd to False

R. David Murray added the comment: What reasons? It's not a big deal, but like I say it isn't our normal style. -- ___ Python tracker ___ ___

[issue27033] Change the decode_data default in smtpd to False

R. David Murray added the comment: Oh, I forgot to say that the revisions look good to me. -- ___ Python tracker ___ ___ Python-bugs-l

[issue27033] Change the decode_data default in smtpd to False

Serhiy Storchaka added the comment: Addressed other David's comment. -- Added file: http://bugs.python.org/file43051/smtpd_decode_data_false_doc3.patch ___ Python tracker ___ ___

[issue27033] Change the decode_data default in smtpd to False

Serhiy Storchaka added the comment: Thank you for your review David. Updated patch addresses your doc comments. As for bool calls, I think there are reasons to do this. -- Added file: http://bugs.python.org/file43050/smtpd_decode_data_false_doc2.patch __

[issue27033] Change the decode_data default in smtpd to False

R. David Murray added the comment: No problem. I use 'commit review' as an indication that a committer should do a final review...before that, triage or general community people can be doing the reviews, then triage can move it to commit review to request the final review before commit. What

[issue27033] Change the decode_data default in smtpd to False

Serhiy Storchaka added the comment: Oh, sorry, I understood this as a sign that you already made a review and don't have comments. I was surprised that you made this silently. Here is a patch that adds an entry in the porting section of What's New. Please also check changes in the smtpd docume

[issue27033] Change the decode_data default in smtpd to False

R. David Murray added the comment: Um, I changed to to commit review because I was planning to review it. I don't expect to find any problems, but I'm surprised you committed it. There does need to be a whatsnew entry, and specifically something in the porting section, since this is a behavio

[issue27033] Change the decode_data default in smtpd to False

Barry A. Warsaw added the comment: aiosmtpd already defaults decode_data to False. We should consider pulling this into 3.6 (not just for this reason of course). http://aiosmtpd.readthedocs.io/en/latest/ -- ___ Python tracker

[issue27033] Change the decode_data default in smtpd to False

Changes by Serhiy Storchaka : -- resolution: -> fixed stage: commit review -> resolved status: open -> closed ___ Python tracker ___

[issue27033] Change the decode_data default in smtpd to False

Roundup Robot added the comment: New changeset a31b9f353346 by Serhiy Storchaka in branch 'default': Issue #27033: The default value of the decode_data parameter for https://hg.python.org/cpython/rev/a31b9f353346 -- ___ Python tracker

[issue27033] Change the decode_data default in smtpd to False

Changes by R. David Murray : -- components: +email ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail

[issue27033] Change the decode_data default in smtpd to False

Changes by R. David Murray : -- stage: patch review -> commit review ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscr

[issue27033] Change the decode_data default in smtpd to False

New submission from Serhiy Storchaka: Proposed patch changes the default value of the decode_data parameter for smtpd.SMTPChannel and smtpd.SMTPServer constructors. The default value True was deprecated since adding this parameter in issue19662. -- components: Library (Lib) files: smtp