[issue27105] cgi.__all__ is incomplete

Jacek Kołodziej added the comment: Thank you, Martin. :) -- ___ Python tracker ___ ___ Python-bugs-list

[issue27105] cgi.__all__ is incomplete

Martin Panter added the comment: Thanks for the patches Jacek. This one I committed after moving the test into CgiTests. -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker

[issue27105] cgi.__all__ is incomplete

Roundup Robot added the comment: New changeset 74ed6f3fb8d2 by Martin Panter in branch 'default': Issue #27105: Add cgi.test() to __all__, based on Jacek Kołodziej’s patch https://hg.python.org/cpython/rev/74ed6f3fb8d2 -- nosy: +python-dev ___ Python

[issue27105] cgi.__all__ is incomplete

Martin Panter added the comment: For this particular case, there is only one existing test class called CgiTests, without any special setup or handling. It seems too arbitrary to have a second class called MiscTestCase, so I would prefer the new test be added to CgiTests. --

[issue27105] cgi.__all__ is incomplete

Serhiy Storchaka added the comment: OK. This is unusual name for public function and looks rather as internal function for manual module testing, but since it is documented, we perhaps should add its name to __all__. The patch LGTM. -- ___ Python

[issue27105] cgi.__all__ is incomplete

Jacek Kołodziej added the comment: Martin: > Is there any advantage to having the test case in a separate MiscTestCase > class, as opposed to the existing CgiTests class? Other than "the first test [well, that I know of] for __all__ list was in separate class called MiscTestCase so each next

[issue27105] cgi.__all__ is incomplete

Martin Panter added the comment: I don’t see why test() should be a special case. A few of the other functions seem to be just for debugging and testing too, e.g. print_environ(). Is there any advantage to having the test case in a separate MiscTestCase class, as opposed to the existing

[issue27105] cgi.__all__ is incomplete

Jacek Kołodziej added the comment: Well, but it is documented in public docs: cgi.test() Robust test CGI script, usable as main program. Writes minimal HTTP headers and formats all information provided to the script in HTML form. Should I remove it from __all__ and probably from the

[issue27105] cgi.__all__ is incomplete

Serhiy Storchaka added the comment: I don't think test() should be exposed as public API. -- nosy: +serhiy.storchaka ___ Python tracker ___

[issue27105] cgi.__all__ is incomplete

New submission from Jacek Kołodziej: That's a child issue of #23883, created to propose a patch fixing cgi module's __all__ list. -- components: Library (Lib) files: cgi_all.patch keywords: patch messages: 266265 nosy: Unit03 priority: normal severity: normal status: open title: