[issue27348] traceback (and threading) drops exception message

Changes by Donald Stufft : -- pull_requests: +1064 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail

[issue27348] traceback (and threading) drops exception message

Changes by Martin Panter : -- resolution: -> fixed stage: commit review -> resolved status: open -> closed ___ Python tracker ___ ___

[issue27348] traceback (and threading) drops exception message

Roundup Robot added the comment: New changeset 5859a9e8b214 by Martin Panter in branch '3.5': Issue #27348: Restore “Exception: None” formatting in traceback module https://hg.python.org/cpython/rev/5859a9e8b214 New changeset d1455d14accd by Martin Panter in branch '3.6': Issue #27348: Merge exc

[issue27348] traceback (and threading) drops exception message

Martin Panter added the comment: Yes, a bug fix for 3.5+. -- ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: ht

[issue27348] traceback (and threading) drops exception message

STINNER Victor added the comment: "Issue #27348: In the traceback module, restore the formatting of exception messages like "Exception: None". This fixes a regression introduced in 3.5a2." Humn, if it is described as a regression, it means that it's a bug no? You plan to push the change into

[issue27348] traceback (and threading) drops exception message

Martin Panter added the comment: I plan to commit this soon, in time for the next release. -- stage: patch review -> commit review versions: +Python 3.7 ___ Python tracker ___ __

[issue27348] traceback (and threading) drops exception message

Martin Panter added the comment: Have you had any luck reviewing this Robert? -- ___ Python tracker ___ ___ Python-bugs-list mailing l

[issue27348] traceback (and threading) drops exception message

Martin Panter added the comment: Yeah sure I can give you a chance to consider this (I assume you meant “chance” :). But neither of the tests I mentioned were added by you as far as I know. Maybe you are thinking of some other test. -- ___ Python tr

[issue27348] traceback (and threading) drops exception message

STINNER Victor added the comment: I agree that ignoring the exception message if str(exc) == 'None' is wrong. -- nosy: +haypo ___ Python tracker ___ _

[issue27348] traceback (and threading) drops exception message

Robert Collins added the comment: hmm, can you give me a change to page this in? I'm pretty sure I saw breakage in external libraries prompting me to add the test and fix. I'd rather not recause that. -- ___ Python tracker

[issue27348] traceback (and threading) drops exception message

Martin Panter added the comment: If I remove the value == 'None' check, there are two failures in the test suite: 1. test_decimal fails, but only because the test was changed in revision 5f3dd0a2b1ab to accommodate the very bug I am complaining about. IMO this was a case of “fixing” the test i

[issue27348] traceback (and threading) drops exception message

Martin Panter added the comment: I traced this back to revision 73afda5a4e4c (Issue 17911), which includes this change to traceback._format_final_exc_line(): -if value is None or not valuestr: +if value == 'None' or value is None or not valuestr: -- components: +Library (Lib) keywords: