[issue27425] Tests fail because of git's newline preferences on Windows

2017-07-01 Thread Ned Deily

Ned Deily added the comment:

OK, based on Steve's response, I am closing this again as it sounds like it 
should not be an issue going forward with releases and also not for dev builds 
as long as people do a fresh clone if necessary. Further discussion on 
hardening the tests can take place over on bpo-30716.

--
priority: release blocker -> 
resolution:  -> fixed
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue27425] Tests fail because of git's newline preferences on Windows

2017-07-01 Thread Terry J. Reedy

Terry J. Reedy added the comment:

There is still the problem with test_winreg freezing CommandPrompt, #30715.  
For me, this is the worst test bug ever.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue27425] Tests fail because of git's newline preferences on Windows

2017-06-30 Thread Steve Dower

Steve Dower added the comment:

There's nothing that needs to block the release as far as I'm concerned. The 
main fix was that I needed a fresh clone on my build machine to pick up the 
gitattribute changes.

The other bug is still open to enhance some tests and skip one in the release 
tree, but nothing release blocking. I don't see why this one is now either.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue27425] Tests fail because of git's newline preferences on Windows

2017-06-30 Thread Ned Deily

Ned Deily added the comment:

So do we have a resolution or resolutions for this yet?  And is bpo-30716 truly 
a duplicate?  If so, let's use one or the other.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue27425] Tests fail because of git's newline preferences on Windows

2017-06-21 Thread STINNER Victor

STINNER Victor added the comment:

I reproduce the bug after installing Python 3.6.2rc1 on Windows. I reopen the 
issue and set the priority to release blocker.

--
nosy: +benjamin.peterson, larry, ned.deily
priority: normal -> release blocker
resolution: fixed -> 
status: closed -> open

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue27425] Tests fail because of git's newline preferences on Windows

2017-06-20 Thread Terry J. Reedy

Terry J. Reedy added the comment:

Installed 3.6.2rc1 is showing the same errors for test_random and test_sax.  
#30716.

--
nosy: +terry.reedy

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue27425] Tests fail because of git's newline preferences on Windows

2017-06-20 Thread Terry J. Reedy

Terry J. Reedy added the comment:

Why de we would 'want' /r/n on Windows?  What beside Notepad can't handle /n?

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue27425] Tests fail because of git's newline preferences on Windows

2017-06-12 Thread STINNER Victor

STINNER Victor added the comment:

I'm happy to see this "old" issue now fixed :-)

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue27425] Tests fail because of git's newline preferences on Windows

2017-06-11 Thread Zachary Ware

Zachary Ware added the comment:

It still might be nice to adjust some of the tests to not care about how line 
endings are checked in, but I think we're in a good enough place now with 
.gitattributes that we can close this issue.  Any other changes can be done in 
a new issue.

--
resolution:  -> fixed
stage: patch review -> resolved
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue27425] Tests fail because of git's newline preferences on Windows

2017-06-11 Thread Zachary Ware

Zachary Ware added the comment:


New changeset 5fe8ac69f99d58232a5234cfca78f05f7223a782 by Zachary Ware in 
branch '2.7':
[2.7] bpo-27425: Be more explicit in .gitattributes (GH-840) (GH-2086)
https://github.com/python/cpython/commit/5fe8ac69f99d58232a5234cfca78f05f7223a782


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue27425] Tests fail because of git's newline preferences on Windows

2017-06-10 Thread Zachary Ware

Zachary Ware added the comment:

> Zach, do you want to update Python 2.7 for your latest change as well?

PR 2086 is in for that, but it's a huge diff due to line endings changing.  As 
noted on the PR, I want Benjamin to give his OK before I merge it.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue27425] Tests fail because of git's newline preferences on Windows

2017-06-10 Thread STINNER Victor

STINNER Victor added the comment:

Zach, do you want to update Python 2.7 for your latest change as well?

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue27425] Tests fail because of git's newline preferences on Windows

2017-06-10 Thread Zachary Ware

Zachary Ware added the comment:


New changeset afa6a389606402779c5048a7211edbf2678cecff by Zachary Ware in 
branch '3.5':
[3.5] bpo-27425: Be more explicit in .gitattributes (GH-840) (GH-2084)
https://github.com/python/cpython/commit/afa6a389606402779c5048a7211edbf2678cecff


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue27425] Tests fail because of git's newline preferences on Windows

2017-06-10 Thread Zachary Ware

Zachary Ware added the comment:


New changeset 964c261dc9a6a901f50d5596d88248bfc4251a55 by Zachary Ware in 
branch '3.6':
[3.6] bpo-27425: Be more explicit in .gitattributes (GH-840) (GH-2083)
https://github.com/python/cpython/commit/964c261dc9a6a901f50d5596d88248bfc4251a55


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue27425] Tests fail because of git's newline preferences on Windows

2017-06-10 Thread Zachary Ware

Changes by Zachary Ware :


--
pull_requests: +2150

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue27425] Tests fail because of git's newline preferences on Windows

2017-06-10 Thread Zachary Ware

Changes by Zachary Ware :


--
pull_requests: +2148

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue27425] Tests fail because of git's newline preferences on Windows

2017-06-10 Thread Zachary Ware

Changes by Zachary Ware :


--
pull_requests: +2147

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue27425] Tests fail because of git's newline preferences on Windows

2017-06-10 Thread Zachary Ware

Zachary Ware added the comment:


New changeset 6b6e68776663c0dda04b6a36609297728da2ae9e by Zachary Ware in 
branch 'master':
bpo-27425: Be more explicit in .gitattributes (GH-840)
https://github.com/python/cpython/commit/6b6e68776663c0dda04b6a36609297728da2ae9e


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue27425] Tests fail because of git's newline preferences on Windows

2017-06-09 Thread STINNER Victor

STINNER Victor added the comment:

Wait, why is this issue still open? Tests now pass on Windows on all
branches. The issue can be closed, except if I missed something?

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue27425] Tests fail because of git's newline preferences on Windows

2017-06-09 Thread Mariatta Wijaya

Changes by Mariatta Wijaya :


--
versions: +Python 3.7

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue27425] Tests fail because of git's newline preferences on Windows

2017-03-27 Thread STINNER Victor

STINNER Victor added the comment:


New changeset cf57fe13b44e3994096ae79f32c11475f333a94f by Victor Stinner in 
branch '3.5':
bpo-27425: Add .gitattributes, fix Windows tests (#844)
https://github.com/python/cpython/commit/cf57fe13b44e3994096ae79f32c11475f333a94f


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue27425] Tests fail because of git's newline preferences on Windows

2017-03-27 Thread STINNER Victor

Changes by STINNER Victor :


--
pull_requests: +741

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue27425] Tests fail because of git's newline preferences on Windows

2017-03-26 Thread Zachary Ware

Changes by Zachary Ware :


--
pull_requests: +737

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue27425] Tests fail because of git's newline preferences on Windows

2017-03-24 Thread Steve Dower

Steve Dower added the comment:

More likely it needs a fresh clone to fix up those files, unless they've 
changed since the attributes file was added.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue27425] Tests fail because of git's newline preferences on Windows

2017-03-24 Thread STINNER Victor

STINNER Victor added the comment:

In the master branch, .gitattributes now contains:
---
*.pck binary
Lib/test/cjkencodings/* binary
Lib/test/decimaltestdata/*.decTest binary
Lib/test/sndhdrdata/sndhdr.* binary
Lib/test/test_email/data/msg_26.txt binary
Lib/test/xmltestdata/* binary
Lib/venv/scripts/nt/* binary
Lib/test/coding20731.py binary
---

History of the file:
---
$ git log --follow .gitattributes  
commit 060d2d776a29341c079cce37220324f9775140ba
Author: INADA Naoki 
Date:   Sun Mar 5 08:49:45 2017 +0900

remove merge=union attribute for Misc/NEWS (GH-460)

Github doesn't support it (ref. isaacs/github#487).  So it can't ease
conflict on Github.

Additionally, it can make trouble when cherry-pick. (ref. GH-212)

commit 2771304357607aa62801a67acc1e3c7c8ec489ce
Author: Benjamin Peterson 
Date:   Wed Feb 22 22:38:48 2017 -0800

mark various test data binary (#233)

commit 2c700af5a761f83f303cc7295b660ac31f7d4ed1
Author: INADA Naoki 
Date:   Tue Feb 21 18:39:41 2017 +0900

.gitattribute -> .gitattributes (GH-213)

commit 3f3d0364a91aa8b89e175a49f93ad04dd4676186
Author: INADA Naoki 
Date:   Tue Feb 21 18:17:06 2017 +0900

Reduce conflict on Misc/NEWS (GH-212)

use "union" merge strategy for Misc/NEWS.
---

test_random and test_sax now pass on my Windows VM... but still fail on the 
"AMD64 Windows8 3.x" buildbot :-(
http://buildbot.python.org/all/builders/AMD64%20Windows8%203.x/builds/461/steps/test/logs/stdio

Is it possible that Git on this buildbot ignores .gitattributes? Maybe the Git 
version is too old?

--
nosy: +haypo

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue27425] Tests fail because of git's newline preferences on Windows

2016-08-27 Thread Emanuel Barry

Emanuel Barry added the comment:

Martin: Indeed, seems like it's backwards for some reason. I'm not sure what 
happened when I regenerated the index; I removed the patches now anyway. I 
think the .gitattributes patch would be fine to go on its own.

It's my understanding that line endings don't matter for XML files, so it would 
probably be a better move to fix xml.sax instead of the test. I'll likely open 
a new issue if we decide to do that.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue27425] Tests fail because of git's newline preferences on Windows

2016-08-27 Thread Emanuel Barry

Changes by Emanuel Barry :


Removed file: https://bugs.python.org/file44220/fix_newlines_1.patch

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue27425] Tests fail because of git's newline preferences on Windows

2016-08-27 Thread Emanuel Barry

Changes by Emanuel Barry :


Removed file: https://bugs.python.org/file44225/fix_newlines_2.patch

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue27425] Tests fail because of git's newline preferences on Windows

2016-08-26 Thread Martin Panter

Martin Panter added the comment:

Emanuel: fix_newlines_2.patch seems to change the contents of batch from CRLF 
to LF newlines, undoing revision 640ccb924b5f. This seems like a step in the 
wrong direction. Notice $ means LF, and ^M$ means CRLF:

$ curl https://bugs.python.org/file44225/fix_newlines_2.patch | cat -A
. . .
diff --git a/Tools/unicode/genwincodecs.bat b/Tools/unicode/genwincodecs.bat$
. . .
-c:\python30\python genwincodec.py 720 > build/cp720.py^M$
. . .
+c:\python30\python genwincodec.py 720 > build/cp720.py$

However, the test_sax change may be sensible.

test_random_warning_1.patch looks okay.

--
versions: +Python 3.5

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue27425] Tests fail because of git's newline preferences on Windows

2016-08-25 Thread Jim Jewett

Jim Jewett added the comment:

I think if the test is ensuring one line-ending type, then there should be 
another test ensuring the other... but I think it would be best if there were a 
single test file that had both types of line-endings, just to ensure that the 
code doesn't cheat by reading only the first line and assuming that the rest of 
the data is consistent.

--
nosy: +Jim.Jewett

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue27425] Tests fail because of git's newline preferences on Windows

2016-08-25 Thread Emanuel Barry

Changes by Emanuel Barry :


Added file: https://bugs.python.org/file44225/fix_newlines_2.patch

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue27425] Tests fail because of git's newline preferences on Windows

2016-08-25 Thread Emanuel Barry

Emanuel Barry added the comment:

Whoops, turns out I was using the wrong approach for binary files. Here come 
add_gitattributes_2.patch and fix_newlines_2.patch (thanks Zachary for pointing 
this out).

--
Added file: https://bugs.python.org/file44224/add_gitattributes_2.patch

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue27425] Tests fail because of git's newline preferences on Windows

2016-08-25 Thread Emanuel Barry

Emanuel Barry added the comment:

Here are three patches for this:

- add_gitattributes_1.patch adds `.gitattributes`, with all the newline 
preferences in `.hgeol` (with the exception of the "native" rule at the end, 
which in git is the default newline preference).
- fix_newlines_1.patch fixes test_sax to properly handle CRLF (since *.xml 
files may have either LF or CRLF), as well as a single batch file which wasn't 
using CRLF line endings for some reason.
- test_random_warning_1.patch is somewhat unrelated, but it makes sure that 
failures in the `pickle.load` call no longer show ResourceWarnings on stderr.

The two tests which used to fail no longer do so. Maybe 
add_gitattributes_1.patch should be backported to 2.7, but probably not the 
other ones.

--
keywords: +patch
stage:  -> patch review
versions:  -Python 3.5
Added file: https://bugs.python.org/file44219/add_gitattributes_1.patch

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue27425] Tests fail because of git's newline preferences on Windows

2016-08-25 Thread Emanuel Barry

Changes by Emanuel Barry :


Added file: https://bugs.python.org/file44221/test_random_warning_1.patch

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue27425] Tests fail because of git's newline preferences on Windows

2016-08-25 Thread Emanuel Barry

Changes by Emanuel Barry :


Added file: https://bugs.python.org/file44220/fix_newlines_1.patch

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue27425] Tests fail because of git's newline preferences on Windows

2016-07-01 Thread R. David Murray

R. David Murray added the comment:

Yes .gitattributes looks like the correct solution.  The problem is that most 
of the text files we *want* git to transform per platform, it's just a few that 
we don't.  Mercurial actually added support for this for us when we switched to 
it.

--
nosy: +r.david.murray

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue27425] Tests fail because of git's newline preferences on Windows

2016-06-30 Thread Emanuel Barry

Emanuel Barry added the comment:

I agree, but I wouldn't expect my line ending preferences to make tests fail. I 
think that with the move to GitHub already underway, it's not unreasonable to 
(at least consider to) add a .gitattributes file. Added Brett to nosy since 
he's responsible for PEP 512.

(I think this should be changed before the final announcement that the cpython 
repo is on GitHub, but there's no rush until then; although I'm certainly not 
going to complain if it's done before ;)

--
nosy: +brett.cannon

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue27425] Tests fail because of git's newline preferences on Windows

2016-06-30 Thread Martin Panter

Martin Panter added the comment:

If it were me, I might try to use a version of Git that doesn’t mess with the 
files. But if this becomes a common problem (esp with the move from Mercurial 
to Git), maybe we can add a “.gitattributes” file 
. We aleady seem to have “.hgeol”.

I presume this is going to affect earlier versions too.

--
components: +Windows
nosy: +martin.panter, paul.moore, steve.dower, tim.golden, zach.ware
versions: +Python 2.7, Python 3.5

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue27425] Tests fail because of git's newline preferences on Windows

2016-06-30 Thread Emanuel Barry

New submission from Emanuel Barry:

Specifically, test_random and test_sax both fail because of git's newline 
preferences. Mine is set to convert \r\n to \n on push and the other way around 
on pull. Relevant output:

test_random:

EException ignored in: <_io.FileIO 
name='E:\\GitHub\\cpython\\lib\\test\\randv2_32.pck' mode='rb' closefd=True>
ResourceWarning: unclosed file <_io.BufferedReader 
name='E:\\GitHub\\cpython\\lib\\test\\randv2_32.pck'>
...EException ignored in: <_io.FileIO 
name='E:\\GitHub\\cpython\\lib\\test\\randv2_32.pck' mode='rb' closefd=True>
ResourceWarning: unclosed file <_io.BufferedReader 
name='E:\\GitHub\\cpython\\lib\\test\\randv2_32.pck'>

==
ERROR: test_bug_1727780 (__main__.MersenneTwister_TestBasicOps)
--
Traceback (most recent call last):
  File "E:\GitHub\cpython\lib\test\test_random.py", line 178, in 
test_bug_1727780
r = pickle.load(f)
ImportError: No module named 'random\r'

==
ERROR: test_bug_1727780 (__main__.SystemRandom_TestBasicOps)
--
Traceback (most recent call last):
  File "E:\GitHub\cpython\lib\test\test_random.py", line 178, in 
test_bug_1727780
r = pickle.load(f)
ImportError: No module named 'random\r'

--
Ran 61 tests in 1.480s

FAILED (errors=2)

test_sax:

(Passing tests omitted)

==
FAIL: test_expat_binary_file (__main__.ExpatReaderTest)
--
Traceback (most recent call last):
  File "E:\GitHub\cpython\lib\test\test_sax.py", line 836, in 
test_expat_binary_file
self.assertEqual(result.getvalue(), xml_test_out)
AssertionError: b'\nhttp://www.isogen.com/pa[1508 chars]TML>' != b'\r\nhttp://www.isogen.com/[1736 chars]TML>'

==
FAIL: test_expat_binary_file_bytes_name (__main__.ExpatReaderTest)
--
Traceback (most recent call last):
  File "E:\GitHub\cpython\lib\test\test_sax.py", line 874, in 
test_expat_binary_file_bytes_name
self.assertEqual(result.getvalue(), xml_test_out)
AssertionError: b'\nhttp://www.isogen.com/pa[1508 chars]TML>' != b'\r\nhttp://www.isogen.com/[1736 chars]TML>'

==
FAIL: test_expat_binary_file_int_name (__main__.ExpatReaderTest)
--
Traceback (most recent call last):
  File "E:\GitHub\cpython\lib\test\test_sax.py", line 886, in 
test_expat_binary_file_int_name
self.assertEqual(result.getvalue(), xml_test_out)
AssertionError: b'\nhttp://www.isogen.com/pa[1508 chars]TML>' != b'\r\nhttp://www.isogen.com/[1736 chars]TML>'

==
FAIL: test_expat_binary_file_nonascii (__main__.ExpatReaderTest)
--
Traceback (most recent call last):
  File "E:\GitHub\cpython\lib\test\test_sax.py", line 862, in 
test_expat_binary_file_nonascii
self.assertEqual(result.getvalue(), xml_test_out)
AssertionError: b'\nhttp://www.isogen.com/pa[1508 chars]TML>' != b'\r\nhttp://www.isogen.com/[1736 chars]TML>'

==
FAIL: test_expat_inpsource_byte_stream (__main__.ExpatReaderTest)
--
Traceback (most recent call last):
  File "E:\GitHub\cpython\lib\test\test_sax.py", line 1053, in 
test_expat_inpsource_byte_stream
self.assertEqual(result.getvalue(), xml_test_out)
AssertionError: b'\nhttp://www.isogen.com/pa[1508 chars]TML>' != b'\r\nhttp://www.isogen.com/[1736 chars]TML>'

==
FAIL: test_expat_inpsource_character_stream (__main__.ExpatReaderTest)
--
Traceback (most recent call last):
  File "E:\GitHub\cpython\lib\test\test_sax.py", line 1066, in 
test_expat_inpsource_character_stream
self.assertEqual(result.getvalue(), xml_test_out)
AssertionError: b'\nhttp://www.isogen.com/pa[1508 chars]TML>' != b'\r\nhttp://www.isogen.com/[1736 chars]TML>'

==
FAIL: test_expat_inpsource_filename (__main__.ExpatReaderTest)
--
Traceback (most recent call last):
  File "E:\GitHub\cpython\lib\test\test_sax.py", line 1015, in 
test_expat_inpsource