[issue27456] asyncio: set TCP_NODELAY flag by default

Марк Коренберг added the comment: Note, TCP_NODELAY can not be set on UNIX streaming socket. Do you have corresponding tests for UNIX sockets ? -- ___ Python tracker ___ _

[issue27456] asyncio: set TCP_NODELAY flag by default

STINNER Victor added the comment: Yury: thanks for fixing socket.socket.type. asyncio code now looks simpler and easier to follow without the helper functions just to test the socket type for equality. -- ___ Python tracker

[issue27456] asyncio: set TCP_NODELAY flag by default

Yury Selivanov added the comment: New changeset a7bd64c0c01379e9b82e86ad41a301329a0775d9 by Yury Selivanov in branch 'master': bpo-27456: Simplify sock type checks (#4922) https://github.com/python/cpython/commit/a7bd64c0c01379e9b82e86ad41a301329a0775d9 -- __

[issue27456] asyncio: set TCP_NODELAY flag by default

Change by Yury Selivanov : -- pull_requests: +4817 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mai

[issue27456] asyncio: set TCP_NODELAY flag by default

Change by Yury Selivanov : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker ___ ___

[issue27456] asyncio: set TCP_NODELAY flag by default

Yury Selivanov added the comment: New changeset 572636d42566da8eb6e85d5b8164e9ed8860a255 by Yury Selivanov in branch '3.6': bpo-27456: Ensure TCP_NODELAY is set on linux (#4231) (#4898) https://github.com/python/cpython/commit/572636d42566da8eb6e85d5b8164e9ed8860a255 --

[issue27456] asyncio: set TCP_NODELAY flag by default

Change by Yury Selivanov : -- pull_requests: +4792 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mai

[issue27456] asyncio: set TCP_NODELAY flag by default

Change by Yury Selivanov : -- pull_requests: +4791 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mai

[issue27456] asyncio: set TCP_NODELAY flag by default

Yury Selivanov added the comment: New changeset e796b2fe26f220107ac50667de6cc86c82b465e3 by Yury Selivanov in branch 'master': bpo-27456: Ensure TCP_NODELAY is set on linux (#4231) https://github.com/python/cpython/commit/e796b2fe26f220107ac50667de6cc86c82b465e3 -- _

[issue27456] asyncio: set TCP_NODELAY flag by default

STINNER Victor added the comment: _ipaddr_info() also uses "type == socket.SOCK_STREAM". Is it ok? -- ___ Python tracker ___ ___ Pyt

[issue27456] asyncio: set TCP_NODELAY flag by default

STINNER Victor added the comment: > sock.type == socket.SOCK_STREAM Oh, right. I wrote PR 4233 to fix the code. Yury: "Good catch. I made a PR to fix this." Oops. If you wrote a PR, would it mind to compare it with mine, please? -- ___ Python tra

[issue27456] asyncio: set TCP_NODELAY flag by default

Change by STINNER Victor : -- keywords: +patch pull_requests: +4201 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscr

[issue27456] asyncio: set TCP_NODELAY flag by default

Yury Selivanov added the comment: > Seems like this fix is incomplete. It contains this check: > >sock.type == socket.SOCK_STREAM > > But sock.type is not only a type Good catch. I made a PR to fix this. -- resolution: fixed -> stage: resolved -> patch review status: closed -> o

[issue27456] asyncio: set TCP_NODELAY flag by default

Change by Yury Selivanov : -- pull_requests: +4200 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mai

[issue27456] asyncio: set TCP_NODELAY flag by default

Vladimir Magamedov added the comment: Seems like this fix is incomplete. It contains this check: sock.type == socket.SOCK_STREAM But sock.type is not only a type (at least in Linux and FreeBSD), it also may contain SOCK_NONBLOCK and SOCK_CLOEXEC flags. So I'm hitting the same problem: on

[issue27456] asyncio: set TCP_NODELAY flag by default

Yury Selivanov added the comment: Committed, should be in 3.6 b1. -- resolution: -> fixed stage: -> resolved status: open -> closed ___ Python tracker ___ _

[issue27456] asyncio: set TCP_NODELAY flag by default

Roundup Robot added the comment: New changeset 3f7e4ae9eba3 by Yury Selivanov in branch '3.5': Issue #27456: asyncio: Set TCP_NODELAY by default. https://hg.python.org/cpython/rev/3f7e4ae9eba3 New changeset 10384c5c18f5 by Yury Selivanov in branch 'default': Merge 3.5 (issue #27456) https://hg.p

[issue27456] asyncio: set TCP_NODELAY flag by default

Марк Коренберг added the comment: vote +10 for that -- nosy: +mmarkk ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscr

[issue27456] asyncio: set TCP_NODELAY flag by default

Changes by STINNER Victor : -- title: TCP_NODELAY -> asyncio: set TCP_NODELAY flag by default ___ Python tracker ___ ___ Python-bugs-l