[issue27481] Replace TypeError with ValueError in doc regarding "embedded NUL character"

[Serhiy Storchaka]

Changes by Serhiy Storchaka :


--
resolution:  -> fixed
stage: commit review -> resolved
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue27481] Replace TypeError with ValueError in doc regarding "embedded NUL character"

[Roundup Robot]

Roundup Robot added the comment:

New changeset 420030a5e854 by Serhiy Storchaka in branch '3.5':
Issue #27481: Docummented that ValueError is now raised instead of TypeError
https://hg.python.org/cpython/rev/420030a5e854

New changeset 00b9c734af87 by Serhiy Storchaka in branch 'default':
Issue #27481: Docummented that ValueError is now raised instead of TypeError
https://hg.python.org/cpython/rev/00b9c734af87

--
nosy: +python-dev

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue27481] Replace TypeError with ValueError in doc regarding "embedded NUL character"

[Serhiy Storchaka]

Serhiy Storchaka added the comment:

LGTM. Thanks Xiang.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue27481] Replace TypeError with ValueError in doc regarding "embedded NUL character"

[Xiang Zhang]

Xiang Zhang added the comment:

Sorry, I didn't notice the difference.

--
Added file: http://bugs.python.org/file43690/null_characters_doc_v4.patch

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue27481] Replace TypeError with ValueError in doc regarding "embedded NUL character"

[Serhiy Storchaka]

Serhiy Storchaka added the comment:

Python strings contain characters, not bytes.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue27481] Replace TypeError with ValueError in doc regarding "embedded NUL character"

[Xiang Zhang]

Xiang Zhang added the comment:

Yes. I noticed the change but didn't change it. Now add it.

--
Added file: http://bugs.python.org/file43689/null_characters_doc_v3.patch

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue27481] Replace TypeError with ValueError in doc regarding "embedded NUL character"

[Serhiy Storchaka]

Serhiy Storchaka added the comment:

LGTM.

But while we are here, it would be worth to change "NUL character" and "NUL 
byte" to "null character" or "null byte" as most used in the documentation and 
the code.

--
assignee: docs@python -> serhiy.storchaka
stage:  -> commit review
versions: +Python 3.5

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue27481] Replace TypeError with ValueError in doc regarding "embedded NUL character"

[Xiang Zhang]

Xiang Zhang added the comment:

Just for a note, there has already been an issue26401 fixing the function.rst. 
Upload a new patch adding versionchanged tag.

--
Added file: http://bugs.python.org/file43686/null_characters_doc_v2.patch

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue27481] Replace TypeError with ValueError in doc regarding "embedded NUL character"

[Xiang Zhang]

New submission from Xiang Zhang:

Errors regarding "embedded NUL character" were changed from TypeError to 
ValueError, in r92365, issue22215, but the doc doesn't get updated. Add a patch 
to apply the change in doc.

--
assignee: docs@python
components: Documentation
files: null_characters_doc.patch
keywords: patch
messages: 270164
nosy: docs@python, serhiy.storchaka, xiang.zhang
priority: normal
severity: normal
status: open
title: Replace TypeError with ValueError in doc regarding "embedded NUL 
character"
versions: Python 3.6
Added file: http://bugs.python.org/file43685/null_characters_doc.patch

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com