[issue27584] New addition of vSockets to the python socket module

Changes by Christian Heimes : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker ___

[issue27584] New addition of vSockets to the python socket module

Christian Heimes added the comment: New changeset effc12f8e9e20d0951d2ba5883587666bd8218e3 by Christian Heimes (caavery) in branch 'master': bpo-27584: New addition of vSockets to the python socket module (#2489) https://github.com/python/cpython/commit/effc12f8e9e20d0951d2ba5883587666bd8218e3

[issue27584] New addition of vSockets to the python socket module

Cathy Avery added the comment: There is an outstanding review on my pull request at https://github.com/python/cpython/pull/2489 as there is an red X at changes requested by kushaldas and I believe I have made the necessary changes. Again please let me know if there is anything that I need to

[issue27584] New addition of vSockets to the python socket module

Cathy Avery added the comment: Hi, I believe I am waiting for a final review. Is there anything else I need to be doing at this point. Thanks, Cathy -- ___ Python tracker

[issue27584] New addition of vSockets to the python socket module

Gregory P. Smith added the comment: Everything compiles successfully on this host - configure detects the header has HAVE_LINUX_VM_SOCKETS_H set to 1. test_socket passes on this host. However since i'm not running with a /dev/vsock, the unittests (correctly) skip the new tests.

[issue27584] New addition of vSockets to the python socket module

Cathy Avery added the comment: That should do it. -- ___ Python tracker ___ ___ Python-bugs-list mailing list

[issue27584] New addition of vSockets to the python socket module

Gregory P. Smith added the comment: yep, linux/vm_sockets.h exists. I believe it's kernel headers are from 4.9. -- ___ Python tracker ___

[issue27584] New addition of vSockets to the python socket module

Cathy Avery added the comment: You will also need linux/vm_sockets.h in order to build. -- ___ Python tracker ___

[issue27584] New addition of vSockets to the python socket module

Gregory P. Smith added the comment: I updated my PGO buildbot to Debian 9 which should have them. http://buildbot.python.org/all/builders/AMD64%20Debian%20PGO%203.x ~$ grep AF_VSOCK /usr/include/*/*/* /usr/include/x86_64-linux-gnu/bits/socket.h:#define AF_VSOCKPF_VSOCK --

[issue27584] New addition of vSockets to the python socket module

Cathy Avery added the comment: OK thanks! -- ___ Python tracker ___ ___ Python-bugs-list mailing list

[issue27584] New addition of vSockets to the python socket module

R. David Murray added the comment: I think we are waiting on confirmation that we have a buildbot that has the necessary headers. -- ___ Python tracker

[issue27584] New addition of vSockets to the python socket module

Cathy Avery added the comment: So I revised my code based on the reviews and I passed all the checks ... now what? Thanks, Cathy -- ___ Python tracker

[issue27584] New addition of vSockets to the python socket module

Cathy Avery added the comment: Fedora 25 has the proper headers. -- ___ Python tracker ___ ___

[issue27584] New addition of vSockets to the python socket module

Nick Coghlan added the comment: I'm attempting to figure out whether or not we have a buildbot in the Buildbot fleet that will cover this test case. Based on the pre-merge CI run, it seems Ubuntu 14.04 is too old to include the required kernel headers. However, it looks like RHEL/CentOS are

[issue27584] New addition of vSockets to the python socket module

Cathy Avery added the comment: The build and test bots failed but I don't understand why. The build could not find module _socket but that is not new and other modules failed. The test could not import fcntl which I did add but should not fail as I have run this test many time and other tests

[issue27584] New addition of vSockets to the python socket module

Cathy Avery added the comment: I also issued a pull request https://github.com/python/cpython/pull/2489 Let me know if I screwed it up. Thanks, Cathy -- ___ Python tracker

[issue27584] New addition of vSockets to the python socket module

Changes by Roundup Robot : -- pull_requests: +2548 ___ Python tracker ___

[issue27584] New addition of vSockets to the python socket module

Cathy Avery added the comment: Help file. -- Added file: http://bugs.python.org/file46978/REAME.txt ___ Python tracker ___

[issue27584] New addition of vSockets to the python socket module

Cathy Avery added the comment: I've attached the third version of VSOCK patch addressing the concerns of the last rev. I've also included a README file that lists instructions on how to setup a test environment. Thanks -- Added file:

[issue27584] New addition of vSockets to the python socket module

Berker Peksag added the comment: You don't need a GitHub account for contributing to CPython, but the pull request workflow is the preferred way. You can still attach your patches to this issue. -- nosy: +berker.peksag ___ Python tracker

[issue27584] New addition of vSockets to the python socket module

Cathy Avery added the comment: The vsock code is now in the linux upstream kernel and qemu. I will be resubmitting my vsock patches for python. So from what I can tell the tip of the devel tree is for 3.7 and that the source control has switched to git. My question is do I need a github

[issue27584] New addition of vSockets to the python socket module

Cathy Avery added the comment: First make sure the driver is in your kernel. It will be with RHEL. Look in /lib/modeles/"your kernel name"/kernel/net/vmw_vsock/vmw_vsock_vmci_transport. I have never tried it on vmware fusion. I have tested it on ESX. See if there is a VMCI option to enable on

[issue27584] New addition of vSockets to the python socket module

R. David Murray added the comment: 'make patchcheck' will do whitespace checking because that's hard to eyeball (although many editors/IDEs do support making it visible nowadays). We don't use any other checking tools other than eyeballs, since not all of the existing code conforms to PEP7/8

[issue27584] New addition of vSockets to the python socket module

Cathy Avery added the comment: Sorry about the typo the drivers have been there for about 4 years. -- ___ Python tracker ___

[issue27584] New addition of vSockets to the python socket module

Cathy Avery added the comment: Is there a format checker I could use on the patch? VMCI and the vmw_vsock_vmci_transport kernel modules are located in the upstream linux tree at git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git They have been there for about years. These

[issue27584] New addition of vSockets to the python socket module

R. David Murray added the comment: Oh, I see, the ac changes are there, I was looking at the patch delta instead of the complete patch. -- ___ Python tracker

[issue27584] New addition of vSockets to the python socket module

R. David Murray added the comment: The second patch seems to be missing the configure changes. Also, the tests have some over-long lines (we limit line lengths to 79 characters). I realize there are other long lines in that file, but no need to add more :) There is trailing whitespace on a

[issue27584] New addition of vSockets to the python socket module

Cathy Avery added the comment: Is there anything else that is needed for this patch? Thanks! -- ___ Python tracker ___

[issue27584] New addition of vSockets to the python socket module

Cathy Avery added the comment: Please forgive the long delay in providing this update. I got a little sidetracked. Attached is the patch for Python 3.7. It includes fixes suggested in rev 1 plus VSOCK tests in test_socket.py. Thanks, Cathy -- versions: +Python 3.7 -Python 3.6 Added

[issue27584] New addition of vSockets to the python socket module

Kushal Das added the comment: The patch can be applied, and build successfully. I have ran the current test suite[1]. The two failed tests do not seem to be have anything to do with this patch (read the end of the consoleText output). I think the thing remaining is the new test cases, and

[issue27584] New addition of vSockets to the python socket module

R. David Murray added the comment: Ah, I see. No, the versionadded will be 3.6, and should go *after* the documentation of the new socket type. The existing socket tests are in Lib/test/test_socket.py. -- ___ Python tracker

[issue27584] New addition of vSockets to the python socket module

Cathy Avery added the comment: Sure I can add tests. I would like to base them on the existing socket tests. Where are those? I did add a version + .. versionadded:: 3.4 It just not may not be the right one. -- ___ Python tracker

[issue27584] New addition of vSockets to the python socket module

R. David Murray added the comment: Looks like there's a missing versionadded directive in the doc patch. Is it possible/sensible to add tests for the new feature? (I haven't reviewed the patch in detail, hopefully someone with more experience with C socket programming than I have will do

[issue27584] New addition of vSockets to the python socket module

New submission from Cathy Avery: I have added AF_VSOCK support to python's 3.6 socket module ( socketmodule.c socketmodule.h cloned from https://hg.python.org/cpython ). The implementation is very similar to AF_NETLINK. AF_VSOCK requires the VMware-specific VMCI transport which is currently