[issue27618] docs for threading.Lock claim it's a class (since 3.3), but it's not (and has never been, apparently)

Mariatta Wijaya added the comment: Thanks :) -- resolution: -> fixed stage: backport needed -> resolved status: open -> closed versions: -Python 2.7 ___ Python tracker

[issue27618] docs for threading.Lock claim it's a class (since 3.3), but it's not (and has never been, apparently)

Mariatta Wijaya added the comment: New changeset 9abd0bf68f73b3beb56954e22740f0efcf04bc79 by Mariatta (csabella) in branch '3.6': bpo-27618: Clarify that threading.Lock is a factory function (GH-1307) (GH-1894) https://github.com/python/cpython/commit/9abd0bf68f73b3beb56954e22740f0efcf04bc79

[issue27618] docs for threading.Lock claim it's a class (since 3.3), but it's not (and has never been, apparently)

Mariatta Wijaya added the comment: New changeset 958e815fe014e9a3c64f3568b883c2a7b32a4e2e by Mariatta (csabella) in branch '3.5': bpo-27618: Clarify that threading.Lock is a factory function (GH-1307) (GH-1895) https://github.com/python/cpython/commit/958e815fe014e9a3c64f3568b883c2a7b32a4e2e

[issue27618] docs for threading.Lock claim it's a class (since 3.3), but it's not (and has never been, apparently)

Cheryl Sabella added the comment: Thanks, Mariatta. I've backported to 3.5 and 3.6 with the new cherry_picker instructions. -- ___ Python tracker ___

[issue27618] docs for threading.Lock claim it's a class (since 3.3), but it's not (and has never been, apparently)

Changes by Cheryl Sabella : -- pull_requests: +1973 ___ Python tracker ___ ___

[issue27618] docs for threading.Lock claim it's a class (since 3.3), but it's not (and has never been, apparently)

Changes by Cheryl Sabella : -- pull_requests: +1972 ___ Python tracker ___ ___

[issue27618] docs for threading.Lock claim it's a class (since 3.3), but it's not (and has never been, apparently)

Mariatta Wijaya added the comment: Thanks for the PR Cheryl. You can backport using cherry_picker.py Note that there's a recent update to it: https://github.com/python/core-workflow/tree/master/cherry_picker -- stage: patch review -> backport needed

[issue27618] docs for threading.Lock claim it's a class (since 3.3), but it's not (and has never been, apparently)

Mariatta Wijaya added the comment: New changeset 56ddfd2eea4d98456a9a99bf2a718f21ee6b2be2 by Mariatta (csabella) in branch 'master': bpo-27618: Clarify that threading.Lock is a factory function (GH-1307) https://github.com/python/cpython/commit/56ddfd2eea4d98456a9a99bf2a718f21ee6b2be2

[issue27618] docs for threading.Lock claim it's a class (since 3.3), but it's not (and has never been, apparently)

Cheryl Sabella added the comment: *bump* The PR was approved by R. David Murray a while ago. I can backport once it's merged. Thanks! -- nosy: +csabella ___ Python tracker

[issue27618] docs for threading.Lock claim it's a class (since 3.3), but it's not (and has never been, apparently)

Changes by Mariatta Wijaya : -- stage: -> patch review versions: +Python 2.7, Python 3.7 -Python 3.3, Python 3.4 ___ Python tracker

[issue27618] docs for threading.Lock claim it's a class (since 3.3), but it's not (and has never been, apparently)

Changes by Cheryl Sabella : -- pull_requests: +1414 ___ Python tracker ___ ___

[issue27618] docs for threading.Lock claim it's a class (since 3.3), but it's not (and has never been, apparently)

Changes by Guido van Rossum : -- assignee: -> docs@python components: +Documentation nosy: +docs@python versions: +Python 3.3, Python 3.4, Python 3.5, Python 3.6 ___ Python tracker

[issue27618] docs for threading.Lock claim it's a class (since 3.3), but it's not (and has never been, apparently)

R. David Murray added the comment: The relevant issue is #10968. Apparently while editing the doc changes I caught the fact that RLock wasn't actually converted, but I missed the fact that Lock wasn't converted. So, it is a doc error and should be corrected. -- nosy: +r.david.murray

[issue27618] docs for threading.Lock claim it's a class (since 3.3), but it's not (and has never been, apparently)

New submission from Guido van Rossum: The docs for threading.Lock say 79534:.. versionchanged:: 3.3 79534: Changed from a factory function to a class. but the implementation in threading.py doesn't define a class named Lock, and in fact it is an alias for _thread.allocate_lock.