[issue27740] Fix doc of Py_CompileStringExFlags

2016-09-28 Thread Berker Peksag
Changes by Berker Peksag : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed versions: +Python 3.7 ___ Python tracker

[issue27740] Fix doc of Py_CompileStringExFlags

2016-09-28 Thread Roundup Robot
Roundup Robot added the comment: New changeset ee76e84f115f by Berker Peksag in branch '3.5': Issue #27740: Fix typo in Py_CompileStringExFlags https://hg.python.org/cpython/rev/ee76e84f115f New changeset 2ee939b314a2 by Berker Peksag in branch '3.6': Issue #27740: Merge from 3.5

[issue27740] Fix doc of Py_CompileStringExFlags

2016-08-27 Thread Xiang Zhang
Xiang Zhang added the comment: I am not a native speaker so I decide not to trap in the minor part. Could you just fix the first point if there is no doubt? I'm okay with the second part staying as now. -- Added file: https://bugs.python.org/file44242/issue27740.patch

[issue27740] Fix doc of Py_CompileStringExFlags

2016-08-19 Thread Xiang Zhang
Xiang Zhang added the comment: > filename is going to be decoded inside of Py_CompileStringExFlags Actually all I want to express is this, *filename* will be decoded inside. But now the wording looks to me is that *filename* is already a decoded string when passed. I don't want to document

[issue27740] Fix doc of Py_CompileStringExFlags

2016-08-19 Thread Berker Peksag
Berker Peksag added the comment: I don't understand the second part of the patch. *filename* is a filesystem encoding (:func:`os.fsdecode`) encoded string [...] Do you want to document that filename should be encoded by using PyUnicode_EncodeFSDefault *before* passing it to

[issue27740] Fix doc of Py_CompileStringExFlags

2016-08-19 Thread Xiang Zhang
Xiang Zhang added the comment: Ping. -- ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue27740] Fix doc of Py_CompileStringExFlags

2016-08-12 Thread Xiang Zhang
Changes by Xiang Zhang : Added file: http://bugs.python.org/file44085/Py_CompileStringExFlags_doc.patch ___ Python tracker ___

[issue27740] Fix doc of Py_CompileStringExFlags

2016-08-12 Thread Xiang Zhang
Changes by Xiang Zhang : Removed file: http://bugs.python.org/file44078/Py_CompileStringExFlags_doc.patch ___ Python tracker ___

[issue27740] Fix doc of Py_CompileStringExFlags

2016-08-11 Thread Xiang Zhang
New submission from Xiang Zhang: I think the doc of Py_CompileStringExFlags has two flaws: 1. Py_CompileStringExFlags should be replaced by Py_CompileStringObject from the context. Py_CompileStringExFlags in the context is meaningless. 2. *filename* is a byte string that should be decoded but