[issue27806] 2.7 32-bit builds fail on future releases of OS X due to dependency on deleted header file

2016-09-16 Thread Roundup Robot 

Roundup Robot added the comment:

New changeset 4030300fcb18 by sashk in branch '2.7':
Issue #27806: Fix 32-bit builds on macOS Sierra 10.12 broken by removal of
https://hg.python.org/cpython/rev/4030300fcb18

--
nosy: +python-dev

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue27806] 2.7 32-bit builds fail on future releases of OS X due to dependency on deleted header file

2016-09-16 Thread sashk 

sashk added the comment:

Ned, please see attached third version of the patch with workaround suggested 
by Jeremy for older versions of OS X.

--
Added file: http://bugs.python.org/file44699/issue27806_v3.patch

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue27806] 2.7 32-bit builds fail on future releases of OS X due to dependency on deleted header file

2016-09-16 Thread Jeremy Sequoia 

Jeremy Sequoia added the comment:

sys/cdefs.h (on new enough darwin) does this for such cases:

#ifndef __has_include
#define __has_include(x) 0
#endif

but of course that isn't present in sys/cdefs.h on older SDKs, so you can just 
shove that above the check and it should fallback the way you want.

Using gcc-4.2 on Sierra would end up with the wrong result, but that's not a 
supported configuration.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue27806] 2.7 32-bit builds fail on future releases of OS X due to dependency on deleted header file

2016-09-16 Thread Ned Deily 

Ned Deily added the comment:

sashk, thanks for the patches!  The general approach LGTM as well.  
Unfortunately, we need the fix to work with gcc-4.2 since the Python 2.7 
installers are still built and supported on OS X 10.5 and 10.6 and the 
__has_include preprocessor construct is not available in gcc-4.2.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue27806] 2.7 32-bit builds fail on future releases of OS X due to dependency on deleted header file

2016-09-16 Thread Jeremy Sequoia 

Jeremy Sequoia added the comment:

Thanks, yep that looks much nicer to me.  Containing the core logic at a 
central choke point makes maintenance much easier.  I'll work to get this into 
MacPorts.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue27806] 2.7 32-bit builds fail on future releases of OS X due to dependency on deleted header file

2016-09-16 Thread sashk 

sashk added the comment:

Thank you for feedback. Here is second version of the patch.

--
Added file: http://bugs.python.org/file44693/issue27806_v2.patch

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue27806] 2.7 32-bit builds fail on future releases of OS X due to dependency on deleted header file

2016-09-15 Thread Alexander Belopolsky 

Alexander Belopolsky added the comment:

> didn't find any existing place to put it into. Any suggestions?

I would put it in Include/pymacconfig.h.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue27806] 2.7 32-bit builds fail on future releases of OS X due to dependency on deleted header file

2016-09-15 Thread sashk 

sashk added the comment:

> You should really have a central config

I planned to, but didn't find any existing place to put it into. Any 
suggestions?  

I'll provide updated version of the patch sometime tomorrow.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue27806] 2.7 32-bit builds fail on future releases of OS X due to dependency on deleted header file

2016-09-15 Thread Jeremy Sequoia 

Jeremy Sequoia added the comment:

Correction (bugfix and Tiger-compat):

#if __has_include()
#include 
#define APPLE_SUPPORTS_QUICKTIME (__MAC_OS_X_VERSION_MAX_ALLOWED < 101200) && 
!__LP64__
#else
#define APPLE_SUPPORTS_QUICKTIME !__LP64__
#endif

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue27806] 2.7 32-bit builds fail on future releases of OS X due to dependency on deleted header file

2016-09-15 Thread ppperry 

Changes by ppperry :


--
type:  -> compile error

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue27806] 2.7 32-bit builds fail on future releases of OS X due to dependency on deleted header file

2016-09-15 Thread Jeremy Sequoia 

Jeremy Sequoia added the comment:

AvailabilityMacros.h is super deprecated and should not be used by anything 
current. Availability.h was added as replacement in 10.5.

__MAC_OS_X_VERSION_MAX_ALLOWED should be checked instead of defined 
(DEPRECATED_IN_MAC_OS_X_VERSION_10_12_AND_LATER)

You should really have a central config and use that instead. Eg:

#include 
#define APPLE_SUPPORTS_QUICKTIME (__MAC_OS_X_VERSION_MAX_ALLOWED < 101200) || 
!__LP64__

Then use APPLE_SUPPORTS_QUICKTIME throughout.  That avoids tons of churn 
whenever things change (as exemplified by this very bug)

--
nosy: +jeremyhu

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue27806] 2.7 32-bit builds fail on future releases of OS X due to dependency on deleted header file

2016-09-15 Thread Tim Smith 

Changes by Tim Smith :


--
nosy: +tdsmith

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue27806] 2.7 32-bit builds fail on future releases of OS X due to dependency on deleted header file

2016-09-12 Thread sashk 

sashk added the comment:

I've made attempt to make Python 2.7 compile 32-bit version on macOS 10.12 
Sierra. See attached patch. With this patch, I was able to compile universal 
(32-bit/64-bit) python binary on macOS 10.12 GM.

--
keywords: +patch
Added file: http://bugs.python.org/file44599/issue27806.patch

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue27806] 2.7 32-bit builds fail on future releases of OS X due to dependency on deleted header file

2016-09-12 Thread Alexander Belopolsky 

Changes by Alexander Belopolsky :


--
nosy: +belopolsky

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue27806] 2.7 32-bit builds fail on future releases of OS X due to dependency on deleted header file

2016-09-12 Thread sashk 

Changes by sashk :


--
nosy: +sashk

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue27806] 2.7 32-bit builds fail on future releases of OS X due to dependency on deleted header file

2016-08-19 Thread Ned Deily 

New submission from Ned Deily:

Attempts to build Python 2.7 using OS X/macOS public beta versions of the 
latest command-line tools can fail due to the removal of the system header file 
for QuickTime/QuickTime.h, one of the long deprecated Carbon APIs.  Currently, 
Python only attempts to build modules dependent on this file when building for 
32-bit archs so this problem typically only affects builds with 
--with-universal-archs= configure options like "intel" or "intel-32".  It would 
be nice to preserve the ability to make use of QuickTime on older systems where 
the header file is still available.  Since the old Python mac modules don't 
exist in Python 3.x, this is only a 2.7 issue.

--
assignee: ned.deily
components: Build, Macintosh
messages: 273159
nosy: ned.deily, ronaldoussoren
priority: normal
severity: normal
stage: needs patch
status: open
title: 2.7 32-bit builds fail on future releases of OS X due to dependency on 
deleted header file
versions: Python 2.7

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com