[issue28082] re: convert re flags to (much friendlier) IntFlag constants

[Roundup Robot]

Roundup Robot added the comment:

New changeset 493359386360 by Ethan Furman in branch '3.6':
issue28082: actually include NEWS entry
https://hg.python.org/cpython/rev/493359386360

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue28082] re: convert re flags to (much friendlier) IntFlag constants

[Roundup Robot]

Roundup Robot added the comment:

New changeset 176fc21f8430 by Ethan Furman in branch '3.6':
closes issue28082: doc update and NEWS entry
https://hg.python.org/cpython/rev/176fc21f8430

--
resolution:  -> fixed
stage: commit review -> resolved
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue28082] re: convert re flags to (much friendlier) IntFlag constants

[STINNER Victor]

STINNER Victor added the comment:

The change 5fd69d4a93e0 (use IntFlag for re constants) made the "regex_compile" 
benchmark slower:

Median +- std dev: [71c1970f27b6] 388 ms +- 3 ms -> [3cf248d10bed] 470 ms +- 4 
ms: 1.21x slower

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue28082] re: convert re flags to (much friendlier) IntFlag constants

[Roundup Robot]

Roundup Robot added the comment:

New changeset 5fd69d4a93e0 by Victor Stinner in branch '3.6':
Issue #28637: Reapply changeset 223731925d06
https://hg.python.org/cpython/rev/5fd69d4a93e0

New changeset be66786e95de by Victor Stinner in branch '3.6':
Issue #28082: Add basic unit tests on re enums
https://hg.python.org/cpython/rev/be66786e95de

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue28082] re: convert re flags to (much friendlier) IntFlag constants

[Roundup Robot]

Roundup Robot added the comment:

New changeset d903a243c281 by Victor Stinner in branch '3.6':
Issue #28637: Revert issue #28082, don't import enum in re
https://hg.python.org/cpython/rev/d903a243c281

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue28082] re: convert re flags to (much friendlier) IntFlag constants

[STINNER Victor]

STINNER Victor added the comment:

The changeset 223731925d06 caused a performance regression: see issue #28637.

--
nosy: +haypo

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue28082] re: convert re flags to (much friendlier) IntFlag constants

[Ethan Furman]

Ethan Furman added the comment:

I did, immediately after your first post -- it's now RegexFlag.  Thank you for 
the suggestion!  Naming things can be hard, especially when trying to beat a 
deadline.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue28082] re: convert re flags to (much friendlier) IntFlag constants

[Raymond Hettinger]

Raymond Hettinger added the comment:

Ethan, can you give this class a better name than "Flags"?  Perhaps something 
like "RegexFlags" or somesuch?

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue28082] re: convert re flags to (much friendlier) IntFlag constants

[Raymond Hettinger]

Changes by Raymond Hettinger :


--
assignee: gvanrossum -> ethan.furman

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue28082] re: convert re flags to (much friendlier) IntFlag constants

[Guido van Rossum]

Guido van Rossum added the comment:

Yeah, I am generally in favor of this. Just yesterday there was a bug report 
(#28070) where someone claimed that the flags from r'(ix)A' were incorrect. 
They were 96 and should be 98. (He was right, and it was fixed already.) The 
way he had to prove that was rather indirect. If the flags had printed like 
with this proposal it would have been much more straightforward.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue28082] re: convert re flags to (much friendlier) IntFlag constants

[Ethan Furman]

Ethan Furman added the comment:

Note: still need to update docs.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue28082] re: convert re flags to (much friendlier) IntFlag constants

[Serhiy Storchaka]

Serhiy Storchaka added the comment:

re flags was the primary motive of introducing general IntFlags. This would 
help to handle frequent user error. Original issue is issue11957.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue28082] re: convert re flags to (much friendlier) IntFlag constants

[Ethan Furman]

Ethan Furman added the comment:

The patch was initially from Serhiy as part of issue23591.  So it's safe to say 
at least one person requested it, and a core dev at that.

I will happily make it two people: as an occasional user of re having the 
constants be named makes it much easier for me to use; I daresay that is true 
for other occasional users.  IIRC giving names to numbers was one of the 
motivating factors in having Enum in the first place.

I do agree that RegexFlag is a better name -- I wasn't real happy with Flag but 
didn't want to miss the cutoff.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue28082] re: convert re flags to (much friendlier) IntFlag constants

[Roundup Robot]

Roundup Robot added the comment:

New changeset 7369ec91d0f7 by Ethan Furman in branch 'default':
issue28082: better name for Flag
https://hg.python.org/cpython/rev/7369ec91d0f7

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue28082] re: convert re flags to (much friendlier) IntFlag constants

[Raymond Hettinger]

Raymond Hettinger added the comment:

Guido, is this something you wanted to happen?  I thought you had objected to 
propagating the four flavors of enum throughout the standard library, 
particularly for long standing, stable APIs.

AFAICT, no one has ever requested this for the re module, nor is there any 
demonstrated need.  As a heavy user of regexes, I've have never looked at the 
flag values (and if I had, it wouldn't have been helpful to hide that these are 
integer values rather than giving them both a new type and an unattractive 
appearance:  .  Also,  prior to this change, the re 
module and its sre components had no external dependencies and did not require 
any other modules to be loaded in memory to run.

If changes like this do go in, it needs better names (i.e. Flag -> RegexFlag) 
so that someone using typing doesn't end-up many distinct kinds of integer 
flags all being called Flag.

--
assignee:  -> gvanrossum
nosy: +gvanrossum, rhettinger

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue28082] re: convert re flags to (much friendlier) IntFlag constants

[Roundup Robot]

Roundup Robot added the comment:

New changeset 223731925d06 by Ethan Furman in branch 'default':
issue28082: use IntFlag for re constants
https://hg.python.org/cpython/rev/223731925d06

--
nosy: +python-dev

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue28082] re: convert re flags to (much friendlier) IntFlag constants

[Ethan Furman]

New submission from Ethan Furman:

Split from issue23591.

--
files: issue-re.stoneleaf.02.patch
keywords: patch
messages: 275848
nosy: ethan.furman, serhiy.storchaka
priority: normal
severity: normal
stage: commit review
status: open
title: re: convert re flags to (much friendlier) IntFlag constants
type: enhancement
versions: Python 3.6
Added file: http://bugs.python.org/file44566/issue-re.stoneleaf.02.patch

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com