[issue28091] Document PEP 525 & 530

Ned Deily added the comment: [cherrypicked for 3.6.0rc2] -- priority: deferred blocker -> ___ Python tracker ___

[issue28091] Document PEP 525 & 530

Roundup Robot added the comment: New changeset 5a11263bb612 by Yury Selivanov in branch '3.6': Issue #28091: Document PEP 525 & PEP 530. https://hg.python.org/cpython/rev/5a11263bb612 -- ___ Python tracker

[issue28091] Document PEP 525 & 530

Changes by Yury Selivanov : -- title: Document PEP 525 -> Document PEP 525 & 530 ___ Python tracker ___

[issue28091] Document PEP 525

Yury Selivanov added the comment: Pushed. Thanks a lot, Eric, very good job! (BTW, please enable trailing whitespace trimming in your editor) Ned, maybe you want to cherry-pick this commit to 3.6.0, but I guess most people just use docs.python.org, so it's not that important. --

[issue28091] Document PEP 525

Roundup Robot added the comment: New changeset 78c8f450b84c by Yury Selivanov in branch '3.6': Issue #28091: Document PEP 525 & PEP 530. https://hg.python.org/cpython/rev/78c8f450b84c New changeset 6bf84e661e69 by Yury Selivanov in branch 'default': Merge 3.6 (issue #28091)

[issue28091] Document PEP 525

Eric Appelt added the comment: Thanks for the explanations and example code in the review! Working on this issue is really helping to improve my understanding of a number of tricky things like finalization. I *think* that I have all the comments implemented in the attached patch. I also

[issue28091] Document PEP 525

Yury Selivanov added the comment: > I believe that I addressed all the comments in the previous review (although > its always possible I missed something), and have a new patch with the > improvements and fixes. Thanks Eric! I've left a few more comments in the review. Almost there! > I

[issue28091] Document PEP 525

Eric Appelt added the comment: I believe that I addressed all the comments in the previous review (although its always possible I missed something), and have a new patch with the improvements and fixes. I also noticed that in asyncio, loop.shutdown_asyncgens() is a coroutinemethod and fixed

[issue28091] Document PEP 525

Eric Appelt added the comment: Yes - I'll work on the patch tonight. -- ___ Python tracker ___ ___

[issue28091] Document PEP 525

Yury Selivanov added the comment: Guido, Nick, OK, let's keep using the current terminology. Eric, Will you have time to make a new version of the patch (addressing the review comments)? -- ___ Python tracker

[issue28091] Document PEP 525

Nick Coghlan added the comment: I agree with Guido that the in-practice terminology for synchronous generators is: "generator" = infer from context (and/or the ambiguity doesn't matter) "generator function" = generator iterator factory defined with "def" "generator iterator" = result of

[issue28091] Document PEP 525

Guido van Rossum added the comment: I think that most documentation uses "generator" to refer to both functions and objects. So whenever you want to be clear you have to write the long form. -- ___ Python tracker

[issue28091] Document PEP 525

Yury Selivanov added the comment: > It sounds particularly confusing that an "[XXX] generator" is the function in one case and the object in the other case. Right, this is the biggest argument against having slightly different terminology between async generators and sync generators. Maybe we

[issue28091] Document PEP 525

Guido van Rossum added the comment: It sounds particularly confusing that an "[XXX] generator" is the function in one case and the object in the other case. There's of course also Nathaniel Smith's opinion that we should switch away from the term coroutine and call those "async def". Is that

[issue28091] Document PEP 525

Yury Selivanov added the comment: Eric, I've left you some review comments. Guido, Nick, I have a question I hope you have an opinion on: for synchronous generators we define the following (sometimes confusing) terminology: - "generator" = generator function - "generator iterator" = generator

[issue28091] Document PEP 525

Yury Selivanov added the comment: > 1. In PEP525 the documentation for aclose() is a bit terse and unclear to me. > It appeared to suggest that you could catch GeneratorExit and yield, but I > found this to result in a RuntimeError like a normal generator. I tried to > document this as it

[issue28091] Document PEP 525

Eric Appelt added the comment: I think this needs considerable checking and polishing, but I am submitting this "Work In Progress" patch for the PEP525 and PEP530 documentation so that I can get some general feedback since I am new to this, and to ensure that if this is not generally what was

[issue28091] Document PEP 525

Yury Selivanov added the comment: Friday is good, take your time! -- ___ Python tracker ___ ___

[issue28091] Document PEP 525

Eric Appelt added the comment: Hi Yury - Yes, I am excited about doing this and getting to work on it. Today was pretty busy but I have some time blocked out tomorrow to really dig in. I was planning to give myself a deadline of Friday afternoon if that works for the review/release schedule.

[issue28091] Document PEP 525

Yury Selivanov added the comment: Eric, are you working on a patch? If not, I'll be focusing on this myself in the next couple of days. -- ___ Python tracker

[issue28091] Document PEP 525

Yury Selivanov added the comment: Hi Eric, please feel free to go ahead and submit a patch, I'll review it! -- ___ Python tracker ___

[issue28091] Document PEP 525

Eric Appelt added the comment: Hi, I'm a new contributor trying to get started with documentation and testing. I have been following and testing PEP525 and PEP530 and feel familiar enough to try to work on adding this to the Python Language Reference if it would not be redundant with work

[issue28091] Document PEP 525

Changes by Ned Deily : -- versions: +Python 3.7 ___ Python tracker ___ ___ Python-bugs-list

[issue28091] Document PEP 525

Changes by Ned Deily : -- Removed message: http://bugs.python.org/msg282460 ___ Python tracker ___

[issue28091] Document PEP 525

Ned Deily added the comment: Yury, are you planning to do more for this for 3.6.0? This is marked as a release blocker but, since it's just a doc change, I'm not going to hold 3.6.0 for it. -- ___ Python tracker

[issue28091] Document PEP 525

New submission from Ned Deily: Yuri, are you planning to do more for this for 3.6.0? This is marked as a release blocker but, since it's just a doc change, I'm not going to hold 3.6.0 for it. -- priority: release blocker -> deferred blocker ___

[issue28091] Document PEP 525

Changes by Yury Selivanov : -- assignee: yselivanov components: Documentation nosy: ned.deily, yselivanov priority: release blocker severity: normal stage: needs patch status: open title: Document PEP 525 type: enhancement versions: Python 3.6