[issue28176] Fix callbacks race in asyncio.SelectorLoop.sock_connect

[Donald Stufft]

Changes by Donald Stufft :


--
pull_requests: +1018

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue28176] Fix callbacks race in asyncio.SelectorLoop.sock_connect

[Berker Peksag]

Berker Peksag added the comment:

test_sock_connect_sock_write_race failure is being discussed in issue 28283. 
Closing this again.

--
resolution:  -> fixed
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue28176] Fix callbacks race in asyncio.SelectorLoop.sock_connect

[Roundup Robot]

Roundup Robot added the comment:

New changeset 06efc625578a by Victor Stinner in branch '3.5':
test_asynico: fix test_sock_connect_sock_write_race()
https://hg.python.org/cpython/rev/06efc625578a

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue28176] Fix callbacks race in asyncio.SelectorLoop.sock_connect

[Berker Peksag]

Berker Peksag added the comment:

For some reason, some tests fail randomly on FreeBSD buildbots. See also 
issue27784. I'm planning to apply the attached patch.

--
keywords: +patch
nosy: +koobs
Added file: http://bugs.python.org/file44736/issue28176_skip_tests.diff

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue28176] Fix callbacks race in asyncio.SelectorLoop.sock_connect

[Roundup Robot]

Roundup Robot added the comment:

New changeset 8417873f2eac by Berker Peksag in branch '3.5':
Issue #28176: Increase timeout for test_sock_connect_sock_write_race
https://hg.python.org/cpython/rev/8417873f2eac

New changeset b5a08d5db05b by Berker Peksag in branch '3.6':
Issue #28176: Merge from 3.5
https://hg.python.org/cpython/rev/b5a08d5db05b

New changeset eb306c20de20 by Berker Peksag in branch 'default':
Issue #28176: Merge from 3.6
https://hg.python.org/cpython/rev/eb306c20de20

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue28176] Fix callbacks race in asyncio.SelectorLoop.sock_connect

[Berker Peksag]

Berker Peksag added the comment:

Would increasing timeout to 10.0 be sufficient? Should we wrap the test with 
@support.reap_threads?

--
nosy: +berker.peksag
status: pending -> open
versions: +Python 3.5, Python 3.7

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue28176] Fix callbacks race in asyncio.SelectorLoop.sock_connect

[STINNER Victor]

STINNER Victor added the comment:

The timeout of 3 seconds seem to be too short for some buildbots like "AMD64 
FreeBSD CURRENT Non-Debug 3.x".

http://buildbot.python.org/all/builders/AMD64%20FreeBSD%20CURRENT%20Non-Debug%203.x/builds/295/steps/test/logs/stdio

test.test_asyncio.test_windows_utils (unittest.loader.ModuleSkipped) ... 
Exception in thread Thread-50:
Traceback (most recent call last):
  File 
"/usr/home/buildbot/python/3.x.koobs-freebsd-current.nondebug/build/Lib/threading.py",
 line 916, in _bootstrap_inner
self.run()
  File 
"/usr/home/buildbot/python/3.x.koobs-freebsd-current.nondebug/build/Lib/test/test_asyncio/test_selector_events.py",
 line 1819, in run
sock, addr = self.srv_sock.accept()
  File 
"/usr/home/buildbot/python/3.x.koobs-freebsd-current.nondebug/build/Lib/socket.py",
 line 205, in accept
fd, addr = self._accept()
socket.timeout: timed out

test test_asyncio failed
skipped 'Windows only'

==
ERROR: test_sock_connect_sock_write_race 
(test.test_asyncio.test_selector_events.SelectorLoopFunctionalTests)
--
Traceback (most recent call last):
  File 
"/usr/home/buildbot/python/3.x.koobs-freebsd-current.nondebug/build/Lib/test/test_asyncio/test_selector_events.py",
 line 1868, in test_sock_connect_sock_write_race
timeout=TIMEOUT))
  File 
"/usr/home/buildbot/python/3.x.koobs-freebsd-current.nondebug/build/Lib/asyncio/base_events.py",
 line 457, in run_until_complete
return future.result()
  File 
"/usr/home/buildbot/python/3.x.koobs-freebsd-current.nondebug/build/Lib/asyncio/futures.py",
 line 292, in result
raise self._exception
  File 
"/usr/home/buildbot/python/3.x.koobs-freebsd-current.nondebug/build/Lib/asyncio/tasks.py",
 line 239, in _step
result = coro.send(None)
  File 
"/usr/home/buildbot/python/3.x.koobs-freebsd-current.nondebug/build/Lib/asyncio/tasks.py",
 line 397, in wait_for
raise futures.TimeoutError()
concurrent.futures._base.TimeoutError

--
nosy: +haypo
resolution: fixed -> 
status: closed -> pending

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue28176] Fix callbacks race in asyncio.SelectorLoop.sock_connect

[Berker Peksag]

Changes by Berker Peksag :


--
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue28176] Fix callbacks race in asyncio.SelectorLoop.sock_connect

[Roundup Robot]

Roundup Robot added the comment:

New changeset 8550ab528a31 by Yury Selivanov in branch '3.5':
Issue #28176: Fix callbacks race in asyncio.SelectorLoop.sock_connect.
https://hg.python.org/cpython/rev/8550ab528a31

New changeset 3d8ba65a0054 by Yury Selivanov in branch '3.6':
Merge 3.5 (issue #28176)
https://hg.python.org/cpython/rev/3d8ba65a0054

New changeset 5024e2a82181 by Yury Selivanov in branch 'default':
Merge 3.6 (issue #28176)
https://hg.python.org/cpython/rev/5024e2a82181

--
nosy: +python-dev

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue28176] Fix callbacks race in asyncio.SelectorLoop.sock_connect

[Yury Selivanov]

Changes by Yury Selivanov :


--
resolution:  -> fixed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue28176] Fix callbacks race in asyncio.SelectorLoop.sock_connect

[Yury Selivanov]

New submission from Yury Selivanov:

Proxy issue for https://github.com/python/asyncio/pull/366

--
assignee: yselivanov
components: asyncio
messages: 276628
nosy: gvanrossum, yselivanov
priority: normal
severity: normal
stage: resolved
status: open
title: Fix callbacks race in asyncio.SelectorLoop.sock_connect
type: behavior
versions: Python 3.6

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com