[issue28194] Clean up some checks in dict implementation

2016-09-26 Thread Serhiy Storchaka
Changes by Serhiy Storchaka : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker

[issue28194] Clean up some checks in dict implementation

2016-09-26 Thread Roundup Robot
Roundup Robot added the comment: New changeset 1d41d741bb5b by Serhiy Storchaka in branch '3.6': Issue #28194: Clean up some checks in dict implementation. https://hg.python.org/cpython/rev/1d41d741bb5b New changeset b83a70afca39 by Serhiy Storchaka in branch 'default': Issue #28194: Clean up

[issue28194] Clean up some checks in dict implementation

2016-09-26 Thread Serhiy Storchaka
Changes by Serhiy Storchaka : -- assignee: -> serhiy.storchaka ___ Python tracker ___

[issue28194] Clean up some checks in dict implementation

2016-09-18 Thread Xiang Zhang
Xiang Zhang added the comment: Apply methane's comment, preserving the comment. -- Added file: http://bugs.python.org/file44738/dict_clean_up_v2.patch ___ Python tracker

[issue28194] Clean up some checks in dict implementation

2016-09-18 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: LGTM if address methane's comment. -- ___ Python tracker ___ ___

[issue28194] Clean up some checks in dict implementation

2016-09-18 Thread Xiang Zhang
New submission from Xiang Zhang: The proposed patch cleans up some unnecessary parts in dict implementation especially NULL checks in lookup functions. There are four states a DictKeyEntry can be. Only in unused(empty) and dummy states me_key can be NULL. So NULL checks in used and pending