[issue28228] imghdr does not support pathlib

Changes by Donald Stufft : -- pull_requests: +888 ___ Python tracker ___ ___

[issue28228] imghdr does not support pathlib

Changes by Raul : Removed file: http://bugs.python.org/file45320/imghdr27.patch ___ Python tracker ___

[issue28228] imghdr does not support pathlib

Raul added the comment: patch for python 2.7 -- nosy: +4simple-org Added file: http://bugs.python.org/file45320/imghdr27.patch ___ Python tracker ___

[issue28228] imghdr does not support pathlib

Berker Peksag added the comment: Thanks for the review, Brett! The next target is gzip module. Thanks for the all patches Ethan :) -- resolution: -> fixed stage: patch review -> resolved status: open -> closed type: enhancement -> behavior ___

[issue28228] imghdr does not support pathlib

Roundup Robot added the comment: New changeset 929e3adefe7a by Berker Peksag in branch '3.6': Issue #28228: imghdr now supports pathlib https://hg.python.org/cpython/rev/929e3adefe7a New changeset 013b3b5d3b6c by Berker Peksag in branch 'default': Issue #28228: Merge from 3.6

[issue28228] imghdr does not support pathlib

Brett Cannon added the comment: Berker, your patch LGTM -- assignee: -> berker.peksag ___ Python tracker ___

[issue28228] imghdr does not support pathlib

Ethan Furman added the comment: Berker, yes please. I just got back from vacation. -- ___ Python tracker ___

[issue28228] imghdr does not support pathlib

Berker Peksag added the comment: Here's a new patch that addresses Serhiy's comments. Let me know if you need a hand with review and commit these patches this weekend :) -- nosy: +berker.peksag Added file: http://bugs.python.org/file44884/issue28228_v2.diff

[issue28228] imghdr does not support pathlib

Brett Cannon added the comment: According to https://www.python.org/dev/peps/pep-0494/#schedule, 2.6.0b2 is due on Sunday. Do you think you will be able to commit this and the other patches for PathLike support by then, Ethan? -- ___ Python tracker

[issue28228] imghdr does not support pathlib

Changes by Ned Deily : -- Removed message: http://bugs.python.org/msg277300 ___ Python tracker ___

[issue28228] imghdr does not support pathlib

Ned Deily added the comment: Since better pathlib support in standard library modules has been a focus of 3.6, I'm willing to allow this and the related changes for gzip, tarfile, zipfile, bz2, lzma, and compilall (Issue28225 through Issue28231) if thay introduce no backward

[issue28228] imghdr does not support pathlib

Ned Deily added the comment: Since better pathlib support in standard library modules has been a focus of 3.6, I'm willing to allow this and the related changes for gzip, tarfile, zipfile, bz2, lzma, and compilall (Issue28226 through Issue28321) if thay introduce no backward

[issue28228] imghdr does not support pathlib

Brett Cannon added the comment: "Removing the provisional status" of what? Pathlib? If so, have you asked Ned if adding support during the beta period is acceptable? This open question is probably why Serhiy changed the type as without Ned's sign-off it means changing something in the stdlib

[issue28228] imghdr does not support pathlib

New submission from Ethan Furman: Supporting pathlib was one of the requirements of removing the provisional status. Why have you changed the type to enhancement? -- ___ Python tracker

[issue28228] imghdr does not support pathlib

Changes by Serhiy Storchaka : -- nosy: +serhiy.storchaka ___ Python tracker ___

[issue28228] imghdr does not support pathlib

Changes by Serhiy Storchaka : -- components: +Library (Lib) type: behavior -> enhancement ___ Python tracker ___

[issue28228] imghdr does not support pathlib

Changes by Ethan Furman : -- files: open-imghdr.stoneleaf.patch keywords: patch nosy: brett.cannon, ethan.furman priority: normal severity: normal stage: patch review status: open title: imghdr does not support pathlib type: behavior versions: Python 3.6 Added file: