[issue28331] "CPython implementation detail:" is removed when contents is translated

Changes by INADA Naoki : Added file: http://bugs.python.org/file44969/impl-detail2.patch ___ Python tracker ___

[issue28331] "CPython implementation detail:" is removed when contents is translated

INADA Naoki added the comment: Ah, I misunderstood your comment is about Sphinx's internal DOM. Sphinx has own pot and po files. In case of custom extension, `sphinx-build -b gettext` doesn't extract messages from Python code. That's why I used dummy html template. Another way is adding

[issue28331] "CPython implementation detail:" is removed when contents is translated

Berker Peksag added the comment: I couldn't find any dummy HTML in the Sphinx codebase. Wouldn't something like work without a dummy HTML? from sphinx.locale import versionlabels, l_ versionlabels['cpythonimpldetail'] = l_('CPython implementation detail') Then use it in

[issue28331] "CPython implementation detail:" is removed when contents is translated

INADA Naoki added the comment: Yes. Actually speaking, this patch is almost copy from VersionChanged directive. See here: https://github.com/sphinx-doc/sphinx/blob/master/sphinx/directives/other.py#L216-L221 -- ___ Python tracker

[issue28331] "CPython implementation detail:" is removed when contents is translated

Berker Peksag added the comment: Does Sphinx use a dummy HTML file like you did in the patch? -- nosy: +berker.peksag ___ Python tracker ___

[issue28331] "CPython implementation detail:" is removed when contents is translated

Changes by Ned Deily : -- nosy: +georg.brandl ___ Python tracker ___ ___ Python-bugs-list

[issue28331] "CPython implementation detail:" is removed when contents is translated

New submission from INADA Naoki: "CPython implementation detail:" label is removed when contents of impl-detail directive is translated. This is very bad for people reading translated documents. Attached patch fixes this, with enabling translating the label, like versionchanged directive.