[issue28491] Remove bundled libffi for OSX

[Ronald Oussoren]

Ronald Oussoren  added the comment:

This was implemented in bpo-41100

--
dependencies:  -Build failure on macOS 11 (beta)
resolution:  -> fixed
stage: test needed -> resolved
status: open -> closed
superseder:  -> Build failure on macOS 11 (beta)

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue28491] Remove bundled libffi for OSX

[Ronald Oussoren]

Ronald Oussoren  added the comment:

added 41100 as a dependency because that switches to the system libffi (as a 
side effect of larger changes)

--
dependencies: +Build failure on macOS 11 (beta)

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue28491] Remove bundled libffi for OSX

[Chi Hsuan Yen]

Chi Hsuan Yen added the comment:

Update: my pull request at https://github.com/libffi/libffi/pull/288 is merged. 
Future libffi releases don't need pkg-config anymore. However, I guess the 
system copy won't be updated in near future.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue28491] Remove bundled libffi for OSX

[Kubilay Kocak]

Changes by Kubilay Kocak :


--
nosy: +koobs

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue28491] Remove bundled libffi for OSX

[Stéphane Wirtel]

Stéphane Wirtel added the comment:

Hi Ronald,

As you can see in my message #msg279069 I have tested with the last version of 
libffi (installed with HomeBrew), so in this case, I think we can say "Yes" to 
your question, the current release of libffi works fine with OSX. Now, I can 
check more deeply and give you a feedback.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue28491] Remove bundled libffi for OSX

[Ronald Oussoren]

Ronald Oussoren added the comment:

Does the upstream libffi work reliably on OSX by this time?  

The bundled version of libffi was extracted from PyObjC, and that copy is 
itself a patched version of the system libffi on OSX. The reason I don't use 
the system libffi is both that I don't want to rely on older version of libffi, 
and because the system libffi causes crashes in PyObjC's testsuite (which 
contains a lot of edge cases). 

I haven't looked into using the upstream version of libffi yet. PyObjC's 
version of libffi is a fairly old fork of upstream libffi where support for 
other systems was removed and support for darwin/x86 (and later darwin/x86-64) 
as added. The former at a time that the upstream libffi didn't support 
darwin/x86 at all (and at a time that darwin/x86 itself wasn't available on 
consumer devices).

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue28491] Remove bundled libffi for OSX

[Stéphane Wirtel]

Stéphane Wirtel added the comment:

On my OSX with El Capitan and HomeBrew

Configuration:

env PKG_CONFIG_PATH=/usr/local/opt/libffi/lib/pkgconfig ./configure 
--prefix=$PWD-build

Compilation:

make

Tests:

./python.exe -c 'import ctypes'

Results:
* No SIGSEGV
* Add a new dependency to pkg-config :/

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue28491] Remove bundled libffi for OSX

[Ned Deily]

Ned Deily added the comment:

Yes, we shouldn't be depending on pkg-config being available.  I am not at all 
keen on adding a dependency on a third-party library supplied by another 
distributor. What I would like to see is: (1) add libffi to the third-party 
libs built and used for the macOS installer build, which also means on all 
supported versions; (2) then, more generally, refactor the third-party lib 
builds (e.g. OpenSSL, SQLite, xz, ncurses, et al, and then libffi) out of the 
installer build script and provide an option to ./configure to allow the 
third-party libs to be built and used in a regular developer build as the 
absence of or lack of updates to them in macOS releases is a growing problem.  
At that point we can get rid of the bundled libffi source.  At the moment, 
AFAIK, the presence of the bundled libffi source is not causing any problems so 
this isn't a critical problem, unlike the case with OpenSSL.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue28491] Remove bundled libffi for OSX

[Chi Hsuan Yen]

Chi Hsuan Yen added the comment:

With this change pkg-config becomes mandatory on macOS, too. As Ned has 
mentioned in issue28207, pkg-config is not pre-installed with macOS.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue28491] Remove bundled libffi for OSX

[Stéphane Wirtel]

Stéphane Wirtel added the comment:

I will test on my OSX (El Capitan)

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue28491] Remove bundled libffi for OSX

[Zachary Ware]

New submission from Zachary Ware:

Here's a patch that at least allows _ctypes to be built against a Homebrew 
libffi and pass the test_ctypes.  It is almost certainly not a complete patch, 
but may serve as a basis for something that will actually work.

--
components: Build, ctypes, macOS
files: remove_libffi_osx.diff
keywords: patch
messages: 279063
nosy: Chi Hsuan Yen, matrixise, ned.deily, r.david.murray, ronaldoussoren, 
zach.ware
priority: normal
severity: normal
stage: test needed
status: open
title: Remove bundled libffi for OSX
type: enhancement
versions: Python 3.7
Added file: http://bugs.python.org/file45157/remove_libffi_osx.diff

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com