[issue28533] Remove asyncore, asynchat and smtpd modules

STINNER Victor added the comment: Follow-up: PEP 594 schedules the removal of these 4 modules in Python 3.12, but the PEP remains a draft. -- ___ Python tracker ___

[issue28533] Remove asyncore, asynchat and smtpd modules

STINNER Victor added the comment: New changeset cf7eaa4617295747ee5646c4e2b7e7a16d7c64ab by Victor Stinner in branch 'main': Revert "bpo-28533: Remove asyncore, asynchat, smtpd modules (GH-29521)" (GH-29951) https://github.com/python/cpython/commit/cf7eaa4617295747ee5646c4e2b7e7a16d7c64ab

[issue28533] Remove asyncore, asynchat and smtpd modules

STINNER Victor added the comment: https://github.com/python/steering-council/issues/86 -- ___ Python tracker ___ ___

[issue28533] Remove asyncore, asynchat and smtpd modules

STINNER Victor added the comment: I reopen the issue: the Steering Council asked to revert the change removing the 3 modules, since the DeprecationWarning was only emitted in a single Python release (Python 3.10) and so the PEP 387 process was not respected. I created the PR 29951 to add

[issue28533] Remove asyncore, asynchat and smtpd modules

Change by STINNER Victor : -- pull_requests: +28176 pull_request: https://github.com/python/cpython/pull/29951 ___ Python tracker ___

[issue28533] Remove asyncore, asynchat and smtpd modules

STINNER Victor added the comment: > ansible-5.0.0 Reported upstream (it's a single file, used for tests): https://github.com/ansible/ansible/issues/76452 > gevent-21.8.0 It's https://github.com/gevent/gevent/tree/master/src/greentest directory which contains subsets of the Python test

[issue28533] Remove asyncore, asynchat and smtpd modules

STINNER Victor added the comment: According to a code search in the PyPI top 5000 projects: the source code of 21 projects contains "import asyncore", "import asynchat" or "import smtpd": * ansible-5.0.0 * cassandra-driver-3.25.0 * django-extensions-3.1.5 * eth_abi-2.1.1 * eth-account-0.5.6

[issue28533] Remove asyncore, asynchat and smtpd modules

STINNER Victor added the comment: About the PEP 387 process, Brett wrote on python-dev that "the modules got yanked prematurely", so I formally requested a SC exception: https://github.com/python/steering-council/issues/86 -- ___ Python tracker

[issue28533] Remove asyncore, asynchat and smtpd modules

STINNER Victor added the comment: asyncore, asynchat, smtpd modules have been removed. I close this issue. > asyncore is still used in several tests and should be replaced This issue is not solved. My PR only copied asyncore as a private module in test.support (test.support._asyncore). If

[issue28533] Remove asyncore, asynchat and smtpd modules

STINNER Victor added the comment: New changeset 9bf2cbc4c498812e14f20d86acb61c53928a5a57 by Victor Stinner in branch 'main': bpo-28533: Remove asyncore, asynchat, smtpd modules (GH-29521) https://github.com/python/cpython/commit/9bf2cbc4c498812e14f20d86acb61c53928a5a57 --

[issue28533] Remove asyncore, asynchat and smtpd modules

STINNER Victor added the comment: See also the (dfaft) PEP 594: "Removing dead batteries from the standard library" https://www.python.org/dev/peps/pep-0594/ -- ___ Python tracker

[issue28533] Remove asyncore, asynchat and smtpd modules

STINNER Victor added the comment: For example, what *if* aiosmtpd deprecated a function -- ___ Python tracker ___ ___

[issue28533] Remove asyncore, asynchat and smtpd modules

STINNER Victor added the comment: > One concern I have is when users follow internet examples and look out for > these modules or examples. Well, we cannot modify printed books :-) > What is the best way to show them the modern usage? Buy new books? :-) > Should Python docs show some

[issue28533] Remove asyncore, asynchat and smtpd modules

STINNER Victor added the comment: Senthil: "+1 to these modules removal" Would you mind to formally approve the PR https://github.com/python/cpython/pull/29521 ? -- ___ Python tracker

[issue28533] Remove asyncore, asynchat and smtpd modules

STINNER Victor added the comment: > There is an option: keep removed modules but replace each module content > with 'raise ImportError("Please use instead")' stub. > The actual module removal can be postponed for years until most internet > resources reflect this fact. That prevents someone

[issue28533] Remove asyncore, asynchat and smtpd modules

Andrew Svetlov added the comment: > One concern I have is when users follow internet examples and look out for these modules or examples. There is an option: keep removed modules but replace each module content with 'raise ImportError("Please use instead")' stub. The actual module removal

[issue28533] Remove asyncore, asynchat and smtpd modules

Senthil Kumaran added the comment: +1 to these modules removal. One concern I have is when users follow internet examples and look out for these modules or examples. What is the best way to show them the modern usage? - Should Python docs show some example snippet of the most common usage

[issue28533] Remove asyncore, asynchat and smtpd modules

STINNER Victor added the comment: I announced my plan to remove the 3 modules on python-dev: https://mail.python.org/archives/list/python-...@python.org/thread/LZOOLX5EKOITW55TW7JQYKLXJUPCAJB4/ -- ___ Python tracker

[issue28533] Remove asyncore, asynchat and smtpd modules

STINNER Victor added the comment: Since Christian Heimes decided to mark my issue bpo-45785 "Remove asyncore, asynchat and smtpd modules" as a duplicate of this issue, I changed this issue title to "Remove asyncore, asynchat and smtpd modules". -- title: Replace