[issue28572] IDLE: add tests for config dialog.

[Terry J. Reedy]

Terry J. Reedy added the comment:

The macOS issue appears to be fixed.

--
resolution:  -> fixed
stage: needs patch -> resolved
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue28572] IDLE: add tests for config dialog.

[Terry J. Reedy]

Changes by Terry J. Reedy :


--
components: +IDLE

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue28572] IDLE: add tests for config dialog.

[Roundup Robot]

Roundup Robot added the comment:

New changeset f604b6ebd802 by Terry Jan Reedy in branch '3.6':
Issue #28572: Use system-specific values for configdialog font test
https://hg.python.org/cpython/rev/f604b6ebd802

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue28572] IDLE: add tests for config dialog.

[Ned Deily]

Ned Deily added the comment:

test_idle now fails (macOS 10.12, Tcl/Tk 8.6):

test test_idle failed -- Traceback (most recent call last):
  File "./lib/python3.7/idlelib/idle_test/test_configdialog.py", line 62, in 
test_font
self.assertEqual(changes, expected)
AssertionError: Lists differ: [('ma[70 chars]ont-size', '11'), ('main', 
'EditorWindow', 'font-bold', False)] != [('ma[70 chars]ont-size', '10'), 
('main', 'EditorWindow', 'font-bold', False)]

First differing element 1:
('main', 'EditorWindow', 'font-size', '11')
('main', 'EditorWindow', 'font-size', '10')

  [('main', 'EditorWindow', 'font', 'Test Font'),
-  ('main', 'EditorWindow', 'font-size', '11'),
?  ^

+  ('main', 'EditorWindow', 'font-size', '10'),
?  ^

   ('main', 'EditorWindow', 'font-bold', False)]

--
nosy: +ned.deily

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue28572] IDLE: add tests for config dialog.

[Roundup Robot]

Roundup Robot added the comment:

New changeset d6440718eb30 by Terry Jan Reedy in branch '3.6':
Issue #28572: Add 10% to coverage of IDLE's test_configdialog.
https://hg.python.org/cpython/rev/d6440718eb30

--
nosy: +python-dev

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue28572] IDLE: add tests for config dialog.

[Terry J. Reedy]

Terry J. Reedy added the comment:

msg279176 of #27755 describe experiments with ttk.combobox.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue28572] IDLE: add tests for config dialog.

[Terry J. Reedy]

Terry J. Reedy added the comment:

Patch makes two types of change to configdialog.  1. Make tested widgets 
visible to their methods can be called.  2. Delete an erroneous command 
argument for General tab radiobutton.  Calling SetKeysType on the General tab 
just redid adjustments on the Keys tab that were already done.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue28572] IDLE: add tests for config dialog.

[Terry J. Reedy]

New submission from Terry J. Reedy:

The current test_configdialog creates an instance of ConfigDialog.  Time to add 
some real tests so I can comfortably work on multiple other configdialog issues.

  The challenge is to do it so tests run without a blocking mainloop call and 
without IDLE's tcl update calls.  Explicit root.update call can be added if 
needed.  I also want to test without making the dialog visible.  This is a 
problem for at least some event_generate calls, but their seem to be (mostly) 
better options.  Buttons and Radiobuttons for both tk and ttk have an invoke 
method that works fine.  Entry widget insert seems to work also to trigger that 
test action.

Attached are partial tests for two of the four main tabs.

--
assignee: terry.reedy
files: config_dialog_test.diff
keywords: patch
messages: 279829
nosy: terry.reedy
priority: normal
severity: normal
stage: needs patch
status: open
title: IDLE: add tests for config dialog.
type: enhancement
versions: Python 3.6, Python 3.7
Added file: http://bugs.python.org/file45297/config_dialog_test.diff

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com