[issue28598] RHS not consulted in `str % subclass_of_str` case.

2017-03-31 Thread Donald Stufft 

Changes by Donald Stufft :


--
pull_requests: +1103

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue28598] RHS not consulted in `str % subclass_of_str` case.

2017-03-24 Thread Serhiy Storchaka 

Serhiy Storchaka added the comment:


New changeset d7e64337ef45085792b382a09f5b3a45d3687c8c by Serhiy Storchaka 
(Martijn Pieters) in branch 'master':
bpo-28598: Support __rmod__ for RHS subclasses of str in % string formatting 
operations (#51)
https://github.com/python/cpython/commit/d7e64337ef45085792b382a09f5b3a45d3687c8c


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue28598] RHS not consulted in `str % subclass_of_str` case.

2017-03-24 Thread Berker Peksag 

Berker Peksag added the comment:


New changeset 53039ad3814a8918c5311f37bd654428b9843fcc by Berker Peksag 
(Martijn Pieters) in branch '3.6':
bpo-28598: Support __rmod__ for RHS subclasses of str in % string formatting 
operations (#95)
https://github.com/python/cpython/commit/53039ad3814a8918c5311f37bd654428b9843fcc


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue28598] RHS not consulted in `str % subclass_of_str` case.

2017-03-24 Thread Berker Peksag 

Berker Peksag added the comment:


New changeset bc144f0abff2b36595171377ee847c0266596ab2 by Berker Peksag 
(Martijn Pieters) in branch '3.5':
bpo-28598: Support __rmod__ for RHS subclasses of str in % string formatting 
operations (#94)
https://github.com/python/cpython/commit/bc144f0abff2b36595171377ee847c0266596ab2


--
nosy: +berker.peksag

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue28598] RHS not consulted in `str % subclass_of_str` case.

2017-03-24 Thread Xiang Zhang 

Xiang Zhang added the comment:


New changeset b4f0e980b6084e9a994e3f069269fac2471e0d78 by Xiang Zhang in branch 
'2.7':
bpo-28598: Support __rmod__ for RHS subclasses of str in % string formatting 
operations (GH-366)
https://github.com/python/cpython/commit/b4f0e980b6084e9a994e3f069269fac2471e0d78


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue28598] RHS not consulted in `str % subclass_of_str` case.

2017-03-17 Thread Larry Hastings 

Changes by Larry Hastings :


--
pull_requests: +619

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue28598] RHS not consulted in `str % subclass_of_str` case.

2017-03-01 Thread Martijn Pieters 

Changes by Martijn Pieters :


--
pull_requests: +318

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue28598] RHS not consulted in `str % subclass_of_str` case.

2017-02-28 Thread Xiang Zhang 

Changes by Xiang Zhang :


--
resolution:  -> fixed
stage: needs patch -> resolved
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue28598] RHS not consulted in `str % subclass_of_str` case.

2017-02-28 Thread Xiang Zhang 

Changes by Xiang Zhang :


--
pull_requests: +310

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue28598] RHS not consulted in `str % subclass_of_str` case.

2017-02-28 Thread Serhiy Storchaka 

Changes by Serhiy Storchaka :


--
resolution: fixed -> 
stage: resolved -> needs patch
status: closed -> open
versions: +Python 2.7 -Python 3.5, Python 3.6, Python 3.7

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue28598] RHS not consulted in `str % subclass_of_str` case.

2017-02-28 Thread Martijn Pieters 

Martijn Pieters added the comment:

> Is 2.7 free from this bug?

No, 2.7 is affected too:

>>> class SubclassedStr(str):
... def __rmod__(self, other):
... return 'Success, self.__rmod__({!r}) was called'.format(other)
...
>>> 'lhs %% %r' % SubclassedStr('rhs')
"lhs % 'rhs'"

Expected output is "Success, self.__rmod__('lhs %% %r') was called"

On the plus side, unicode is not affected:

>>> class SubclassedUnicode(unicode):
... def __rmod__(self, other):
... return u'Success, self.__rmod__({!r}) was called'.format(other)
...
>>> u'lhs %% %r' % SubclassedUnicode(u'rhs')
u"Success, self.__rmod__(u'lhs %% %r') was called"

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue28598] RHS not consulted in `str % subclass_of_str` case.

2017-02-27 Thread Serhiy Storchaka 

Serhiy Storchaka added the comment:

Is 2.7 free from this bug?

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue28598] RHS not consulted in `str % subclass_of_str` case.

2017-02-27 Thread Berker Peksag 

Changes by Berker Peksag :


--
versions:  -Python 2.7

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue28598] RHS not consulted in `str % subclass_of_str` case.

2017-02-27 Thread Berker Peksag 

Changes by Berker Peksag :


--
resolution:  -> fixed
stage: patch review -> resolved
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue28598] RHS not consulted in `str % subclass_of_str` case.

2017-02-27 Thread Martijn Pieters 

Changes by Martijn Pieters :


--
pull_requests: +299

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue28598] RHS not consulted in `str % subclass_of_str` case.

2017-02-27 Thread Martijn Pieters 

Changes by Martijn Pieters :


--
pull_requests: +294

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue28598] RHS not consulted in `str % subclass_of_str` case.

2017-02-23 Thread Serhiy Storchaka 

Changes by Serhiy Storchaka :


--
pull_requests: +218

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue28598] RHS not consulted in `str % subclass_of_str` case.

2017-02-23 Thread Serhiy Storchaka 

Changes by Serhiy Storchaka :


--
pull_requests:  -57

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue28598] RHS not consulted in `str % subclass_of_str` case.

2017-02-14 Thread Martijn Pieters 

Changes by Martijn Pieters :


--
pull_requests: +57

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue28598] RHS not consulted in `str % subclass_of_str` case.

2017-02-12 Thread Serhiy Storchaka 

Changes by Serhiy Storchaka :


--
nosy: +serhiy.storchaka
stage:  -> patch review
versions: +Python 3.7 -Python 3.3, Python 3.4

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue28598] RHS not consulted in `str % subclass_of_str` case.

2017-02-12 Thread Martijn Pieters 

Martijn Pieters added the comment:

I'm not sure if issues are linked automatically yet. I put the patch up as a 
pull request on GitHub: https://github.com/python/cpython/pull/51

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue28598] RHS not consulted in `str % subclass_of_str` case.

2016-11-03 Thread Martijn Pieters 

Martijn Pieters added the comment:

Here's a proposed patch for tip; what versions would it be worth backporting 
this to?

(Note, there's no NEWS update in this patch).

--
keywords: +patch
Added file: http://bugs.python.org/file45338/issue28598.patch

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue28598] RHS not consulted in `str % subclass_of_str` case.

2016-11-03 Thread Xiang Zhang 

Changes by Xiang Zhang :


--
nosy: +xiang.zhang

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue28598] RHS not consulted in `str % subclass_of_str` case.

2016-11-03 Thread Martijn Pieters 

New submission from Martijn Pieters:

The `BINARY_MODULO` operator hardcodes a test for `PyUnicode`:

TARGET(BINARY_MODULO) {
PyObject *divisor = POP();
PyObject *dividend = TOP();
PyObject *res = PyUnicode_CheckExact(dividend) ?
PyUnicode_Format(dividend, divisor) :
PyNumber_Remainder(dividend, divisor);

This means that a RHS subclass of str can't override the operator:

>>> class Foo(str):
... def __rmod__(self, other):
... return self % other
...
>>> "Bar: %s" % Foo("Foo: %s")
'Bar: Foo %s'

The expected output there is "Foo: Bar %s".

This works correctly for `bytes`:

>>> class FooBytes(bytes):
... def __rmod__(self, other):
... return self % other
...
>>> b"Bar: %s" % FooBytes(b"Foo: %s")
b'Foo: Bar: %s'

and for all other types where the RHS is a subclass.

Perhaps there should be a test to see if `divisor` is a subclass, and in that 
case take the slow path?

--
components: Interpreter Core
messages: 279993
nosy: mjpieters
priority: normal
severity: normal
status: open
title: RHS not consulted in `str % subclass_of_str` case.
type: behavior
versions: Python 2.7, Python 3.3, Python 3.4, Python 3.5, Python 3.6

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com