[issue28749] Fixed the documentation of the mapping codec APIs

Serhiy Storchaka added the comment: New changeset c85a26628ceb9624c96c3064e8b99033c026d8a3 by Serhiy Storchaka in branch 'master': bpo-28749: Fixed the documentation of the mapping codec APIs. (#487) https://github.com/python/cpython/commit/c85a26628ceb9624c96c3064e8b99033c026d8a3 --

[issue28749] Fixed the documentation of the mapping codec APIs

Serhiy Storchaka added the comment: New changeset 69eab3123ed1de4bed4b7dedecabe415f6139bb6 by Serhiy Storchaka in branch '3.6': bpo-28749: Fixed the documentation of the mapping codec APIs. (#487) (#714) https://github.com/python/cpython/commit/69eab3123ed1de4bed4b7dedecabe415f6139bb6

[issue28749] Fixed the documentation of the mapping codec APIs

Serhiy Storchaka added the comment: New changeset 88b32eb7b317dd7c7943433f980e17e34e50f8f8 by Serhiy Storchaka in branch '3.5': bpo-28749: Fixed the documentation of the mapping codec APIs. (#487) (#715) https://github.com/python/cpython/commit/88b32eb7b317dd7c7943433f980e17e34e50f8f8

[issue28749] Fixed the documentation of the mapping codec APIs

Changes by Serhiy Storchaka : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker

[issue28749] Fixed the documentation of the mapping codec APIs

Changes by Serhiy Storchaka : -- pull_requests: +635 ___ Python tracker ___ ___

[issue28749] Fixed the documentation of the mapping codec APIs

Changes by Serhiy Storchaka : -- pull_requests: +634 ___ Python tracker ___ ___

[issue28749] Fixed the documentation of the mapping codec APIs

Serhiy Storchaka added the comment: Do you still have objections Marc-Andre? -- ___ Python tracker ___ ___

[issue28749] Fixed the documentation of the mapping codec APIs

Changes by Serhiy Storchaka : -- pull_requests: +400 ___ Python tracker ___ ___

[issue28749] Fixed the documentation of the mapping codec APIs

Changes by Serhiy Storchaka : -- assignee: docs@python -> serhiy.storchaka ___ Python tracker ___

[issue28749] Fixed the documentation of the mapping codec APIs

Serhiy Storchaka added the comment: "bytes ordinals" is good term. Thank you. Here is an updated patch. > No, I'd prefer this deprecation to be undone as long as we > don't have a proper alternative for the API. This is different issue. -- Added file:

[issue28749] Fixed the documentation of the mapping codec APIs

Marc-Andre Lemburg added the comment: >> The only part that is not correct is "single string characters". >> This should read "single bytes" or "bytes strings of length 1". > > This is not correct. Decoding mappings map not bytes strings, but integers. Looking at the implementation, you're

[issue28749] Fixed the documentation of the mapping codec APIs

Serhiy Storchaka added the comment: How can we move this issue forward? Marc-Andre, have I answered to your objections? -- ___ Python tracker ___

[issue28749] Fixed the documentation of the mapping codec APIs

Serhiy Storchaka added the comment: > The only part that is not correct is "single string characters". > This should read "single bytes" or "bytes strings of length 1". This is not correct. Decoding mappings map not bytes strings, but integers. And this is not the only incorrect part. Decoding

[issue28749] Fixed the documentation of the mapping codec APIs

Marc-Andre Lemburg added the comment: On 28.11.2016 12:24, Serhiy Storchaka wrote: >> Why are you removing the introductory section on how mappings work ? > > Because it is not correct. I copied it to descriptions of concrete functions > with correcting it according to the peculiarity of

[issue28749] Fixed the documentation of the mapping codec APIs

Changes by Serhiy Storchaka : Added file: http://bugs.python.org/file45669/docs-PyUnicode_Translate-3.patch ___ Python tracker ___

[issue28749] Fixed the documentation of the mapping codec APIs

Serhiy Storchaka added the comment: Thanks Xiang. I forgot about comments in headers, the updated path updates them too. > Why are you removing the introductory section on how mappings work ? Because it is not correct. I copied it to descriptions of concrete functions with correcting it

[issue28749] Fixed the documentation of the mapping codec APIs

Marc-Andre Lemburg added the comment: Why are you removing the introductory section on how mappings work ? Also, this wording needs to be corrected: "bytes (integers in the range from 0 to 255)". Bytes are not integers. I'd suggest to use the more correct wording "bytes strings of length 1".

[issue28749] Fixed the documentation of the mapping codec APIs

Xiang Zhang added the comment: v2 LGTM. -- nosy: +xiang.zhang ___ Python tracker ___ ___ Python-bugs-list

[issue28749] Fixed the documentation of the mapping codec APIs

Serhiy Storchaka added the comment: Updated patch addresses Xiang's and Victor's comments. -- Added file: http://bugs.python.org/file45623/docs-PyUnicode_Translate-2.patch ___ Python tracker

[issue28749] Fixed the documentation of the mapping codec APIs

New submission from Serhiy Storchaka: Proposed patch adds the documentation of PyUnicode_Translate() and fixes the documentation of other mapping codec APIs (it is incorrect in Python 3): PyUnicode_DecodeCharmap(), PyUnicode_AsCharmapString(), PyUnicode_EncodeCharmap(), and