[issue28897] Python 3.6.0rc1 breaks NumPy tests.

[STINNER Victor]

STINNER Victor added the comment:

Charles: "OK, you fixed what broke us before. If I revert our fixes
the problem goes away. So, thanks I guess ;) You can close this."

Cool, happy to read that the issue was fixed :-)

If you missed it, the whole mess were backward compatibility when I
extended the warnings API (only internally currently) to implement a
new feature:
https://docs.python.org/dev/whatsnew/3.6.html#warnings

ResourceWarning are now displayed with a traceback where the object
was allocated when tracemalloc is enabled.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue28897] Python 3.6.0rc1 breaks NumPy tests.

[Ned Deily]

Ned Deily added the comment:

Yes, thanks, Charles, and thanks everyone else. Sorry about the confusion with 
the changes in rc1.

--
priority: release blocker -> 

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue28897] Python 3.6.0rc1 breaks NumPy tests.

[Nick Coghlan]

Nick Coghlan added the comment:

Closing as not a bug as Charles suggested, since the problem was due to a 
workaround NumPy introduced for a regression in the beta releases that was 
fixed for rc1.

--
nosy: +ncoghlan
resolution:  -> not a bug
stage:  -> resolved
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue28897] Python 3.6.0rc1 breaks NumPy tests.

[Charles Harris]

Charles Harris added the comment:

OK, you fixed what broke us before. If I revert our fixes the problem goes 
away. So, thanks I guess ;)

You can close this.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue28897] Python 3.6.0rc1 breaks NumPy tests.

[Ned Deily]

Ned Deily added the comment:

Charles, these are the two changes that went into Lib/warnings.py between b4 
and rc1:

changeset:   105490:aaee06743c61
branch:  3.6
parent:  105488:c0f59410ccfc
user:Ned Deily 
date:Tue Dec 06 17:12:47 2016 -0500
files:   Lib/warnings.py
description:
Issue #28835: Tidy previous showwarning changes based on review comments.
Patch by Serhiy Storchaka.


changeset:   105474:726308cfe3b5
branch:  3.6
parent:  105472:ab66423c3581
user:Victor Stinner 
date:Tue Dec 06 10:53:52 2016 +0100
files:   Lib/test/test_warnings/__init__.py Lib/warnings.py Misc/NEWS
description:
catch_warnings() calls showwarning() if overriden

Issue #28089: Fix a regression introduced in warnings.catch_warnings(): call
warnings.showwarning() if it was overriden inside the context manager.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue28897] Python 3.6.0rc1 breaks NumPy tests.

[Charles Harris]

Charles Harris added the comment:

I ran with Python 3.6.0rc1 (default, Dec  7 2016, 14:00:51) and get the same 
errors in both NumPy 1.13.0-dev and 1.12. But I gave you a wrong suggestion, we 
disable some test errors for releases, which is what is on PyPI, and that is 
doubtless why you don't see them. My fault, and I apologize. You will probably 
need to clone the github repo (https://github.com/numpy/numpy) and do a 
`python3.6 runtests.py` in the master branch to see the problem. 

I'm suspecting the problem needs to be fixed on the numpy end, but need to know 
what the changes were made to get an idea of a fix. We do some odd stuff with 
the warnings queue in order to make sure no warnings are inadvertently disabled 
in the tests.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue28897] Python 3.6.0rc1 breaks NumPy tests.

[Julien Palard]

Julien Palard added the comment:

Tried to run the test_nanfunctions.py on tip and Python 3.6.0b4+, on numpy 1.11 
and 1.12.0b1, can't make it fail.

Installed numpy 1.12.0b1 using: ./python -m pip install --user numpy==1.12.0b1

I suspect Charles tested using Python 3.6.0b3 (can you confirm?), which was 
released before the latest patches (commited yesterday) from 
http://bugs.python.org/issue28835.

--
nosy: +mdk

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue28897] Python 3.6.0rc1 breaks NumPy tests.

[Charles Harris]

Charles Harris added the comment:

The NumPy 1.12.0b1 tarball is available on PyPI if you want to download it.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue28897] Python 3.6.0rc1 breaks NumPy tests.

[Charles Harris]

Charles Harris added the comment:

You probably need to run NumPy 1.12 to see the problem. Tt looks like the new 
suppress_warnings context manager is what has been broken. Note that is was 
broken by 3.6 before, fixed, and now seems to be broken again.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue28897] Python 3.6.0rc1 breaks NumPy tests.

[Charles Harris]

Charles Harris added the comment:

I downloaded the tarball and installed the release here and got the same 
errors. We setup the tests in developement mode by turning some warnings into 
errors, in particular DeprecationWarnings and RuntimeWarnings, and suppressing 
others. The tests that are failing are checking for warnings turn the errors 
back into warnings. The latter seems to be failing.

There could be an interaction between the setup and recent changes in Python 
3.6.0rc1. What exactly was changed in the warnings module after the last beta?

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue28897] Python 3.6.0rc1 breaks NumPy tests.

[Serhiy Storchaka]

Serhiy Storchaka added the comment:

I have installed NumPy 1.11.2 and ran tests. Tests are passes successfully.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue28897] Python 3.6.0rc1 breaks NumPy tests.

[Antoine Pitrou]

Antoine Pitrou added the comment:

What is Numpy doing that is breaking it?

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue28897] Python 3.6.0rc1 breaks NumPy tests.

[Serhiy Storchaka]

Serhiy Storchaka added the comment:

It works in usual circumstances.

>>> import warnings
>>> with warnings.catch_warnings(record=True) as w:
... warnings.simplefilter('always')
... warnings.warn('a test warning', DeprecationWarning)
... print(w)
... 
[]

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue28897] Python 3.6.0rc1 breaks NumPy tests.

[Antoine Pitrou]

Antoine Pitrou added the comment:

So `warnings.catch_warnings` doesn't work anymore in 3.6?

--
nosy: +pitrou

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue28897] Python 3.6.0rc1 breaks NumPy tests.

[Ned Deily]

Changes by Ned Deily :


--
keywords: +3.6regression

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue28897] Python 3.6.0rc1 breaks NumPy tests.

[Charles Harris]

Charles Harris added the comment:

The failing tests don't use the context manager mentioned in msg278976 and 
which was fixed. In any case, the failures are new an appeared today. A failing 
test may be viewed at: 
https://github.com/numpy/numpy/blob/master/numpy/lib/tests/test_nanfunctions.py#L546

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue28897] Python 3.6.0rc1 breaks NumPy tests.

[Serhiy Storchaka]

Serhiy Storchaka added the comment:

See also msg278976.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue28897] Python 3.6.0rc1 breaks NumPy tests.

[Serhiy Storchaka]

Serhiy Storchaka added the comment:

Could you please show an example of failing test?

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue28897] Python 3.6.0rc1 breaks NumPy tests.

[Charles Harris]

Charles Harris added the comment:

Probably this commit: https://hg.python.org/cpython/rev/aaee06743c61 .

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue28897] Python 3.6.0rc1 breaks NumPy tests.

[Ned Deily]

Ned Deily added the comment:

Serhiy, Victor, can you look at this please?

--
nosy: +haypo, ned.deily, serhiy.storchaka
priority: normal -> release blocker

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue28897] Python 3.6.0rc1 breaks NumPy tests.

[Charles Harris]

New submission from Charles Harris:

The lastest Python 3.6 pre-release broke a number of NumPy tests. The failing 
tests are of the sort

with warnings.catch_warnings(record=True) as w:
warnings.simplefilter('always')
...

And the failure seems to be that nothing is recorded in w. None of the beta 
releases caused problems. It is possible that the testing environment (Travis 
CI) messed up, but reporting this here just in case.

--
components: Library (Lib)
messages: 282633
nosy: charris44
priority: normal
severity: normal
status: open
title: Python 3.6.0rc1 breaks NumPy tests.
type: behavior
versions: Python 3.6

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com