[issue29020] collapse_rfc2231_value has inconsistent unquoting

[bpoaugust]

bpoaugust added the comment:

If there are concerns about 3rd party code relying on the current behaviour of 
the function, then just create a new function without the unquoting, and 
deprecate the original function.

The existing function does not always unquote, so any code which relies on it 
is liable to break.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue29020] collapse_rfc2231_value has inconsistent unquoting

[Eric Lafontaine]

Eric Lafontaine added the comment:

Hi all,

The fix is already provided in issue28945 .  Please review it and I would like 
to flag it as needing more test on more version of python...

The patch would just require more Test Case that would check for the 
filename for preventing re-occurence in the future on the file-name.

Thanks for the analysis bpoaugust :).  I'm hoping no client relied on this 
function for the unquote though...

Regards,
Eric Lafontaine

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue29020] collapse_rfc2231_value has inconsistent unquoting

[Eric Lafontaine]

Changes by Eric Lafontaine :


--
nosy: +Eric Lafontaine

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue29020] collapse_rfc2231_value has inconsistent unquoting

[bpoaugust]

bpoaugust added the comment:

I have just checked and AFAICT collapse_rfc2231_value is only called by 
get_filename and get_boundary in message.py.

Both of these call get_param and default to unquote=True.

So in all cases the parameter value passed to collapse_rfc2231_value will 
already have been unquoted. Calling unquote again is a bug.

The obvious fix is to remove the calls to unquote from collapse_rfc2231_value.

This will also fix issue28945.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue29020] collapse_rfc2231_value has inconsistent unquoting

[bpoaugust]

bpoaugust added the comment:

Another case is get_filename.

The second call to unquote will only change the incoming parameter if the 
original value was enclosed in <> or "". This is not a common scenario, and was 
only discovered because a mailer used the form <<>> as a boundary marker 
(yes, this is invalid). So existing tests are unlikely to notice any difference.

Note that it is wrong to unquote more times than the original value has been 
quoted. So the only possible reason for keeping unquote in the function is if 
unquote has not already been called on a quoted value. (It is not possible to 
tell from the parameter whether or not it is currently quoted).

The two sample callers are get_boundary and get_filename.
Both pass the value already unquoted.

This method should be fixed to remove the unquote calls.
If there is a caller (is there one?) that does not unquote the value first, 
then that needs to be fixed as well.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue29020] collapse_rfc2231_value has inconsistent unquoting

[bpoaugust]

New submission from bpoaugust:

collapse_rfc2231_value unquotes the value before returning it except here:

rawbytes = bytes(text, 'raw-unicode-escape')
return str(rawbytes, charset, errors)

Why is the text not unquoted in this case?

Actually I wonder whether the function should do any unquoting at all.
There is at least one case where it is called with an already unquoted value 
(get_boundary, see issue28945).

But if it is intended to do unquoting, it should be consistent.

--
components: email
messages: 283658
nosy: barry, bpoaugust, r.david.murray
priority: normal
severity: normal
status: open
title: collapse_rfc2231_value has inconsistent unquoting
versions: Python 3.5

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue29020] collapse_rfc2231_value has inconsistent unquoting

[bpoaugust]

Changes by bpoaugust :


--
type:  -> behavior

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com