[issue29063] Fixed timemodule compile warnings (gmtoff).

[STINNER Victor]

STINNER Victor added the comment:

I backported the fix to 3.6. So all warnings on timemodule.c should now be 
fixed. Thanks for the bug report and the patch Decorater! 

commit 69f3a5ac28041fac86897e0c90d98ad9fd6fa3f7
Author: Victor Stinner 
Date:   Wed May 17 14:45:45 2017 -0700

--
resolution:  -> fixed
stage:  -> resolved
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue29063] Fixed timemodule compile warnings (gmtoff).

[STINNER Victor]

Changes by STINNER Victor :


--
pull_requests: +1731

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue29063] Fixed timemodule compile warnings (gmtoff).

[STINNER Victor]

Changes by STINNER Victor :


--
title: Fixed timemodule compile warnings. -> Fixed timemodule compile warnings 
(gmtoff).

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue29063] Fixed timemodule compile warnings.

[STINNER Victor]

STINNER Victor added the comment:

commit 0d659e5614cad512a1940125135b443b3eecb5d7
Author: Victor Stinner 
Date:   Tue Apr 25 01:22:42 2017 +0200

--
pull_requests: +1726

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue29063] Fixed timemodule compile warnings.

[Decorater]

Decorater added the comment:

I think the patch that haypo added should help take care of the warning. It 
does however only warned when building for 64 bit.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue29063] Fixed timemodule compile warnings.

[STINNER Victor]

STINNER Victor added the comment:

Not checking for integer overflow is more likely to hide bugs. Handling time is 
an hard problem, see a recent funny (or not) story from Cloudfare with the 
latest leap second added at midnight the 2016-12-31:
https://blog.cloudflare.com/how-and-why-the-leap-second-affected-cloudflare-dns/

Extract: "RRDNS is written in Go and uses Go’s time.Now() function to get the 
time. Unfortunately, this function does not guarantee monotonicity. Go 
currently doesn’t offer a monotonic time source (see issue 12914 for 
discussion)."

Hopefully, Python has time.monotonic() since Python 3.3 ;-)

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue29063] Fixed timemodule compile warnings.

[STINNER Victor]

STINNER Victor added the comment:

The warning was introduced by a recent change:

changeset:   103680:a96101dd105c
user:Alexander Belopolsky 
date:Sun Sep 11 22:55:16 2016 -0400
files:   Doc/library/time.rst Misc/NEWS Modules/timemodule.c
description:
Closes #25283: Make tm_gmtoff and tm_zone available on all platforms.

--
nosy: +belopolsky
versions: +Python 3.6

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue29063] Fixed timemodule compile warnings.

[STINNER Victor]

STINNER Victor added the comment:

Downcasting to int doesn't seem good to me.

gmtoff_time_t.patch uses time_t instead of an int to store gmtoff. It raises an 
OverflowError if the value doesn't fit into a C long (at least max is at least 
2^31).

I guess that the issue only impacts Windows, I expect that most platforms have 
a tm_zone field in the "tm" structure?

/* Define to 1 if `tm_zone' is a member of `struct tm'. */
#define HAVE_STRUCT_TM_TM_ZONE 1

--
nosy: +haypo
Added file: http://bugs.python.org/file46122/gmtoff_time_t.patch

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue29063] Fixed timemodule compile warnings.

[Steve Dower]

Steve Dower added the comment:

Any reason we can't make gmtoff a time_t instead of an int?

If we're going to truncate values to get rid of the warnings, I'd like to also 
see either proof that it will never exceed the size of an int (which may be a 
simple comment, but it's not obvious that this is the case from what appears in 
the patch), or an assertion when it does overflow.

But since we're presumably passing the value back into Python as an int, 
expanding the destination variable to fit all possible values is best.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue29063] Fixed timemodule compile warnings.

[Decorater]

Changes by Decorater :


--
title: Fix timemodule compile warnings. -> Fixed timemodule compile warnings.

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com