[issue29084] C API of OrderedDict

[Serhiy Storchaka]

Change by Serhiy Storchaka :


--
resolution:  -> fixed
stage: patch review -> resolved
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue29084] C API of OrderedDict

[Serhiy Storchaka]

Serhiy Storchaka  added the comment:


New changeset d62b7412c18bd5dfa6d7346abfaf8a922818e6db by Serhiy Storchaka 
(Miss Islington (bot)) in branch '3.6':
bpo-29084: Exclude C API for OrderedDict from the limited C API. (GH-4900) 
(#5007)
https://github.com/python/cpython/commit/d62b7412c18bd5dfa6d7346abfaf8a922818e6db


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue29084] C API of OrderedDict

[Roundup Robot]

Change by Roundup Robot :


--
pull_requests: +4896

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue29084] C API of OrderedDict

[Serhiy Storchaka]

Serhiy Storchaka  added the comment:


New changeset 1b3029ac8370ac76fa9571aef540e10aed0667ff by Serhiy Storchaka in 
branch 'master':
bpo-29084: Exclude C API for OrderedDict from the limited C API. (#4900)
https://github.com/python/cpython/commit/1b3029ac8370ac76fa9571aef540e10aed0667ff


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue29084] C API of OrderedDict

[Raymond Hettinger]

Raymond Hettinger  added the comment:

With today's announcement of guaranteed ordering for regular dicts, OrderedDict 
just became much less important (almost insignificant).  Also, the original 
reason for having this C API no longer applies.

There is a reasonable case to be made for removing the API entirely (given that 
it was never documented, that it is buggy, and that it is no longer of any 
significance).

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue29084] C API of OrderedDict

[Serhiy Storchaka]

Change by Serhiy Storchaka :


--
keywords: +patch
pull_requests: +4795
stage:  -> patch review

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue29084] C API of OrderedDict

[Serhiy Storchaka]

Change by Serhiy Storchaka :


--
assignee:  -> serhiy.storchaka

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue29084] C API of OrderedDict

[Serhiy Storchaka]

Serhiy Storchaka added the comment:

Eric, what are your thoughts?

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue29084] C API of OrderedDict

[Raymond Hettinger]

Raymond Hettinger added the comment:

+1 for privatizing

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue29084] C API of OrderedDict

[Brett Cannon]

Brett Cannon added the comment:

If the API is broken in the limited API then I definitely think we should  
consistently make it not part of the limited API. As for removing it I don't 
have an opinion without knowing how many people are using it.

--
nosy: +brett.cannon

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue29084] C API of OrderedDict

[Serhiy Storchaka]

New submission from Serhiy Storchaka:

C API of the C implementation of OrderedDict was added in 3.5 together with the 
C implementation of OrderedDict. But it was never announced nor documented. 
Some macros contain bugs. PyODict_Check() and PyODict_CheckExact() are declared 
in the limited API, but don't work since use PyODict_Type not available in the 
limited API. PyODict_SIZE() is expanded to syntactically incorrect code and 
it's name is not consistent with similar macros: PyTuple_GET_SIZE, 
PyList_GET_SIZE and just added PyDict_GET_SIZE. Many names are just transparent 
wrappers around PyDict API (and they can't be different).

Since PyODict C API is not documented, partially not working and partially 
redundant, and the C implementation of OrderedDict is optional (other Python 
implementations can provide just Python implementation of OrderedDict), I think 
this C API should be made private if not removed.

--
components: Interpreter Core
messages: 284098
nosy: eric.snow, rhettinger, serhiy.storchaka
priority: normal
severity: normal
status: open
title: C API of OrderedDict

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com