[issue29091] Python 3.5+ socket.socketpair fallback incorrectly implemented

2016-12-28 Thread Seth Michael Larson

Seth Michael Larson added the comment:

Sorry for making noise, yes I was using the implementation in Python 2.x. I 
will do better investigation in the future.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue29091] Python 3.5+ socket.socketpair fallback incorrectly implemented

2016-12-28 Thread Benjamin Peterson

Benjamin Peterson added the comment:

Are you using that implementation on Python 2? Python 3's socket.listen has one 
optional backlog argument.

--
nosy: +benjamin.peterson
resolution:  -> not a bug
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue29091] Python 3.5+ socket.socketpair fallback incorrectly implemented

2016-12-27 Thread Seth Michael Larson

New submission from Seth Michael Larson:

The socket.socketpair() fallback for Python 3.5+ is incorrectly implemented 
from the original source. The fallback doesn't provide a backlog argument to 
the lsock.listen() function call.

When running the function it gives the following error:
`TypeError: listen() takes exactly one argument (0 given)`

Issue can be seen here on line 514: 
https://hg.python.org/cpython/file/3.6/Lib/socket.py

Should add 1 as the argument to listen() to bring the implementation in line 
with the source implementation at: https://gist.github.com/geertj/4325783

--
components: Library (Lib)
messages: 284158
nosy: SethMichaelLarson
priority: normal
severity: normal
status: open
title: Python 3.5+ socket.socketpair fallback incorrectly implemented
type: behavior
versions: Python 3.5, Python 3.6, Python 3.7

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com