[issue29110] [patch] Fix file object leak in `aifc.open` when given invalid AIFF file.

2017-03-31 Thread Donald Stufft
Changes by Donald Stufft : -- pull_requests: +959 ___ Python tracker ___ ___

[issue29110] [patch] Fix file object leak in `aifc.open` when given invalid AIFF file.

2017-03-24 Thread INADA Naoki
INADA Naoki added the comment: New changeset 5dc33eea538361f8a218255f83db2e9298dd8c53 by INADA Naoki in branch 'master': bpo-29110: add test for Aifc_write. (GH-293) https://github.com/python/cpython/commit/5dc33eea538361f8a218255f83db2e9298dd8c53 --

[issue29110] [patch] Fix file object leak in `aifc.open` when given invalid AIFF file.

2017-03-24 Thread INADA Naoki
INADA Naoki added the comment: New changeset b7fb1e25c89a9eb85b95027f4167bc0977687c43 by INADA Naoki in branch '3.5': bpo-29110: Fix file object leak in `aifc.open` (GH-311) https://github.com/python/cpython/commit/b7fb1e25c89a9eb85b95027f4167bc0977687c43 --

[issue29110] [patch] Fix file object leak in `aifc.open` when given invalid AIFF file.

2017-03-24 Thread INADA Naoki
INADA Naoki added the comment: New changeset c9131b61fa060a51ec181053cade9f0a7ee91e4f by INADA Naoki in branch '3.6': [3.6] bpo-29110: Fix file object leak in `aifc.open` (#310) https://github.com/python/cpython/commit/c9131b61fa060a51ec181053cade9f0a7ee91e4f --

[issue29110] [patch] Fix file object leak in `aifc.open` when given invalid AIFF file.

2017-03-24 Thread INADA Naoki
INADA Naoki added the comment: New changeset 02eb4b0bd4a7d86cf5e40567aaa8710b00e079a4 by INADA Naoki in branch '2.7': bpo-29110: Fix file object leak in aifc.open (GH-356) https://github.com/python/cpython/commit/02eb4b0bd4a7d86cf5e40567aaa8710b00e079a4 --

[issue29110] [patch] Fix file object leak in `aifc.open` when given invalid AIFF file.

2017-03-17 Thread Larry Hastings
Changes by Larry Hastings : -- pull_requests: +597 ___ Python tracker ___ ___

[issue29110] [patch] Fix file object leak in `aifc.open` when given invalid AIFF file.

2017-02-28 Thread INADA Naoki
Changes by INADA Naoki : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker ___

[issue29110] [patch] Fix file object leak in `aifc.open` when given invalid AIFF file.

2017-02-28 Thread INADA Naoki
INADA Naoki added the comment: OK, since Aifc_write is harder to test, and the exception is very unlikely happens, I fixed only Aifc_read. -- ___ Python tracker

[issue29110] [patch] Fix file object leak in `aifc.open` when given invalid AIFF file.

2017-02-28 Thread INADA Naoki
Changes by INADA Naoki : -- pull_requests: +303 ___ Python tracker ___ ___

[issue29110] [patch] Fix file object leak in `aifc.open` when given invalid AIFF file.

2017-02-27 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: test.support.swap_attr() provides the functionality similar to mock. check_no_resource_warning() can be backported to 2.7. But if there are problems with testing in 2.7 you can backport without tests. -- ___

[issue29110] [patch] Fix file object leak in `aifc.open` when given invalid AIFF file.

2017-02-26 Thread INADA Naoki
INADA Naoki added the comment: Anyone mind Python 2.7? Since Python 2.7 doesn't have mock and check_no_resource_warning context manager, I can't cherry-pick easily. Backporting is bother to me, and the issue doesn't seem so critical. Can I just close this issue? --

[issue29110] [patch] Fix file object leak in `aifc.open` when given invalid AIFF file.

2017-02-26 Thread INADA Naoki
Changes by INADA Naoki : -- pull_requests: +272 ___ Python tracker ___ ___

[issue29110] [patch] Fix file object leak in `aifc.open` when given invalid AIFF file.

2017-02-26 Thread INADA Naoki
Changes by INADA Naoki : -- pull_requests: +271 ___ Python tracker ___ ___

[issue29110] [patch] Fix file object leak in `aifc.open` when given invalid AIFF file.

2017-02-26 Thread Serhiy Storchaka
Changes by Serhiy Storchaka : -- assignee: serhiy.storchaka -> inada.naoki ___ Python tracker ___

[issue29110] [patch] Fix file object leak in `aifc.open` when given invalid AIFF file.

2017-02-25 Thread INADA Naoki
Changes by INADA Naoki : -- pull_requests: +263 ___ Python tracker ___ ___

[issue29110] [patch] Fix file object leak in `aifc.open` when given invalid AIFF file.

2017-02-21 Thread INADA Naoki
INADA Naoki added the comment: New changeset 03f68b60e17b57f6f13729ff73245dbb37b30a4c by INADA Naoki in branch 'master': bpo-29110: Fix file object leak in `aifc.open` when given invalid AIFF file. (GH-162) https://github.com/python/cpython/commit/03f68b60e17b57f6f13729ff73245dbb37b30a4c

[issue29110] [patch] Fix file object leak in `aifc.open` when given invalid AIFF file.

2017-02-18 Thread Anthony Zhang
Changes by Anthony Zhang : -- pull_requests: +127 ___ Python tracker ___ ___

[issue29110] [patch] Fix file object leak in `aifc.open` when given invalid AIFF file.

2016-12-30 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: Thank you for your patches Anthony. Could you please create a unittest for the first issue? The second issue is well known. Since the behavior is documented, I think it can be changed only in Python 3.7. The patch needs the "versionchanged" directives in

[issue29110] [patch] Fix file object leak in `aifc.open` when given invalid AIFF file.

2016-12-29 Thread Serhiy Storchaka
Changes by Serhiy Storchaka : -- assignee: -> serhiy.storchaka nosy: +serhiy.storchaka stage: -> patch review versions: -Python 3.3, Python 3.4 ___ Python tracker

[issue29110] [patch] Fix file object leak in `aifc.open` when given invalid AIFF file.

2016-12-29 Thread Anthony Zhang
Changes by Anthony Zhang : Added file: http://bugs.python.org/file46088/fix_aifc_leak_and_file_object_close.patch ___ Python tracker ___

[issue29110] [patch] Fix file object leak in `aifc.open` when given invalid AIFF file.

2016-12-29 Thread Anthony Zhang
New submission from Anthony Zhang: Summary --- This shows up as two closely-related issues: * ``aifc.open`` leaks file object when invalid AIFF file encountered. This is probably a bug. * ``aifc.close`` closes file object even when it didn't open the file object to begin with. While this