[issue29121] sqlite3 Controlling Transactions documentation not updated

2017-03-24 Thread Berker Peksag 

Berker Peksag added the comment:


New changeset fe70d924bb6106d4c21eb414f4a1ba1324e8f46a by Berker Peksag in 
branch 'master':
bpo-29121: Remove outdated documentation about transactions (#313)
https://github.com/python/cpython/commit/fe70d924bb6106d4c21eb414f4a1ba1324e8f46a


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue29121] sqlite3 Controlling Transactions documentation not updated

2017-03-24 Thread Berker Peksag 

Berker Peksag added the comment:


New changeset fe70d924bb6106d4c21eb414f4a1ba1324e8f46a by Berker Peksag in 
branch 'master':
bpo-29121: Remove outdated documentation about transactions (#313)
https://github.com/python/cpython/commit/fe70d924bb6106d4c21eb414f4a1ba1324e8f46a


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue29121] sqlite3 Controlling Transactions documentation not updated

2017-03-24 Thread Berker Peksag 

Berker Peksag added the comment:


New changeset 893e86e9d3c0caeb878ccb1120c7259e022f3b68 by Berker Peksag in 
branch '3.6':
bpo-29121: Remove outdated documentation about transactions (#313) (#319)
https://github.com/python/cpython/commit/893e86e9d3c0caeb878ccb1120c7259e022f3b68


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue29121] sqlite3 Controlling Transactions documentation not updated

2017-02-26 Thread Berker Peksag 

Berker Peksag added the comment:

Thanks for the patch, Aviv!

--
assignee:  -> docs@python
components: +Documentation
nosy: +docs@python
resolution:  -> fixed
stage:  -> resolved
status: open -> closed
type:  -> behavior

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue29121] sqlite3 Controlling Transactions documentation not updated

2017-02-26 Thread Berker Peksag 

Changes by Berker Peksag :


--
pull_requests: +280

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue29121] sqlite3 Controlling Transactions documentation not updated

2017-02-26 Thread Berker Peksag 

Changes by Berker Peksag :


--
pull_requests: +274

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue29121] sqlite3 Controlling Transactions documentation not updated

2017-01-25 Thread Ma Lin 

Ma Lin added the comment:

After read some issues, there are two major concerns:
1, backward compatibility.
2, implicit commit is bad, tolerates bug-prone codes.

However they are not contradictory if we print a warning when doing an implicit 
commit. Some messages like this:
Warning: sqlite3 module issued an implicit commit before executing VACUUM, 
you should commit this transaction by yourself, that's a good habit, etc..

Then we can keep backward compatibility, and no longer commit implicitly.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue29121] sqlite3 Controlling Transactions documentation not updated

2017-01-24 Thread Ma Lin 

Changes by Ma Lin :


--
nosy: +Ma Lin

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue29121] sqlite3 Controlling Transactions documentation not updated

2017-01-24 Thread Aviv Palivoda 

Aviv Palivoda added the comment:

I would just like to note that I think that the correct solution is to do an 
implicit commit before:
1. VACUUM
2. ATTACH
3. DETACH
4. BEGIN

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue29121] sqlite3 Controlling Transactions documentation not updated

2016-12-31 Thread Aviv Palivoda 

New submission from Aviv Palivoda:

commit 284676cf2ac8 changed the sqlite3 module so it will no longer implicitly 
commit an open transaction before DDL statements. The docs have been updated 
but there is still an incorrect paragraph that has not been removed. 
Attached is a patch that remove the old paragraph.

--
files: sqlite-transaction-doc.patch
keywords: patch
messages: 284396
nosy: berker.peksag, ghaering, palaviv, serhiy.storchaka
priority: normal
severity: normal
status: open
title: sqlite3 Controlling Transactions documentation not updated
versions: Python 3.6, Python 3.7
Added file: http://bugs.python.org/file46101/sqlite-transaction-doc.patch

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com