[issue29182] Remove the warning in urllib docs that it doesn't do certificate validate by default.

[Senthil Kumaran]

Senthil Kumaran added the comment:

Thank you for the review, Julian.
Addressed it and the change is committed at changeset b5125e971fdd

--
resolution:  -> fixed
stage: commit review -> resolved
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue29182] Remove the warning in urllib docs that it doesn't do certificate validate by default.

[Julian Berman]

Julian Berman added the comment:

Cool! If I can nitpick one last time, in the versionchanged block, you have 
`HTTPS URIs` but in the warning you use `HTTPS Urls` -- probably best to use 
consistent casing and URL vs URI.

Other than that, lgtm to merge.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue29182] Remove the warning in urllib docs that it doesn't do certificate validate by default.

[Senthil Kumaran]

Senthil Kumaran added the comment:

Hi Julian, here is the patch that addresses you comments. Thanks

--
Added file: http://bugs.python.org/file46430/issue29182-patch3.diff

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue29182] Remove the warning in urllib docs that it doesn't do certificate validate by default.

[Julian Berman]

Julian Berman added the comment:

The change note belongs outside the seealso.

I think also that wasn't exactly what Martin had in mind, I think he meant a 
`.. versionchanged` directive -- and given that this was originally a warning, 
personally I'd leave the warning but reword it, it's still relevant for 
pre-2.7.9 users.

E.g. something like:

.. seealso::

   

.. versionchanged:: 2.7.9

HTTPS certificates now have hostname verification enabled by default.

.. warning::

Versions prior to 2.7.9 do not safely verify hostnames. It is not 
recommended to use this module on these versions -- the aformentioned requests 
module can be used instead.

Or the like.

--
nosy: +Julian

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue29182] Remove the warning in urllib docs that it doesn't do certificate validate by default.

[Senthil Kumaran]

Senthil Kumaran added the comment:

Here is the updated patch that addresses the comment.

--
Added file: http://bugs.python.org/file46401/issue29182_docs_fix.patch

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue29182] Remove the warning in urllib docs that it doesn't do certificate validate by default.

[Senthil Kumaran]

Senthil Kumaran added the comment:

@Martin, that's a sound advice. I agree to it. I'll change it to a note 
(instead of warning) which mentions about certificate verification since 2.7.9.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue29182] Remove the warning in urllib docs that it doesn't do certificate validate by default.

[Martin Panter]

Martin Panter added the comment:

The warning for urllib2.urlopen() was removed in revision 1882157b298a. 
However, a couple other warnings were converted to “Changed in version 2.7.9” 
in revision fb83916c3ea1, which seems safer to me.

Removing documentation almost seems like a step backwards. The usual approach 
for new features is to document the new behaviour, and when it changed. This 
has also been done for the “context” etc parameters added in a bug fix release. 
So I suggest to document that the certificate is verified since 2.7.9, but not 
beforehand.

--
nosy: +martin.panter

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue29182] Remove the warning in urllib docs that it doesn't do certificate validate by default.

[Berker Peksag]

Changes by Berker Peksag :


--
stage: patch review -> commit review

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue29182] Remove the warning in urllib docs that it doesn't do certificate validate by default.

[Senthil Kumaran]

New submission from Senthil Kumaran:

It started as a discussion in this issue: 
http://bugs.python.org/issue22417#msg284604

I think, that warning can be removed.  If no one has any objections, I will 
commit this attached patch.

--
assignee: orsenthil
components: Documentation
files: remove_warning.patch
keywords: patch
messages: 284836
nosy: benjamin.peterson, christian.heimes, clopez, orsenthil
priority: normal
severity: normal
stage: patch review
status: open
title: Remove the warning in urllib docs that it doesn't do certificate 
validate by default.
type: behavior
versions: Python 2.7
Added file: http://bugs.python.org/file46176/remove_warning.patch

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com