[issue29386] select.epoll.poll may behave differently if timeout = -1 vs timeout = None

Change by Berker Peksag : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed versions: -Python 3.6, Python 3.7 ___ Python tracker ___

[issue29386] select.epoll.poll may behave differently if timeout = -1 vs timeout = None

Berker Peksag added the comment: New changeset b690b9b04729ba3d91c59bff1bb11c3dcc1b50fc by Berker Peksag in branch 'master': bpo-29386: Pass -1 to epoll_wait() when timeout is < -1 (GH-9040) https://github.com/python/cpython/commit/b690b9b04729ba3d91c59bff1bb11c3dcc1b50fc --

[issue29386] select.epoll.poll may behave differently if timeout = -1 vs timeout = None

Change by Berker Peksag : -- keywords: +patch pull_requests: +8502 stage: -> patch review ___ Python tracker ___ ___

[issue29386] select.epoll.poll may behave differently if timeout = -1 vs timeout = None

Serhiy Storchaka added the comment: See similar issue31334. It may be worth to make the code similar. Only -1 is documented as a special timeout value for epoll_wait(). -- nosy: +serhiy.storchaka ___ Python tracker

[issue29386] select.epoll.poll may behave differently if timeout = -1 vs timeout = None

Gabriel McManus added the comment: I don't know of any other OS that implements epoll, so this is issue is likely no longer a problem. Although it is strange to convert -1 to -1000 (as though from seconds to milliseconds), it may not be worth changing. --

[issue29386] select.epoll.poll may behave differently if timeout = -1 vs timeout = None

Berker Peksag added the comment: Thanks for the report. Looking at the Kernel source code, there doesn't seem to be any difference between -1, -100, or -255: https://github.com/torvalds/linux/blob/9bd553929f68921be0f2014dd06561e0c8249a0d/fs/eventpoll.c#L1747-L1761 Do you know any other OS

[issue29386] select.epoll.poll may behave differently if timeout = -1 vs timeout = None

Gabriel McManus added the comment: As mentioned in [1], Illumos will be fixed to match Linux's behaviour, so this problem will go away. It may still be worth changing epoll to just send -1 though, in case this causes similar issues in other operating systems. [1]

[issue29386] select.epoll.poll may behave differently if timeout = -1 vs timeout = None

New submission from Gabriel McManus: The select module epoll.poll method takes a "timeout" parameter which is documented as having a default value of -1 [1]. If no timeout (or None) is passed to epoll.poll, then a value of -1 is passed to the epoll_wait system call. But if a timeout of -1 is