[issue29442] Replace optparse with argparse in setup.py

[STINNER Victor]

STINNER Victor  added the comment:

> bpo-29442: Replace optparse with argparse in setup.py (GH-139)

I'm surprised that it works, but I tested manually and I confirm that it works 
:-)

$ git clean -fdx
$ ./configure --with-pydebug
$ make
$ ./python -c "import select"

No compilation error ;-)

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue29442] Replace optparse with argparse in setup.py

[INADA Naoki]

Change by INADA Naoki :


--
nosy:  -inada.naoki
resolution:  -> fixed
stage: patch review -> resolved
status: open -> closed
versions: +Python 3.8 -Python 3.7

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue29442] Replace optparse with argparse in setup.py

[INADA Naoki]

INADA Naoki  added the comment:


New changeset 09b2bece78f62c3d363236dce593ecfe130afd2f by INADA Naoki 
(Chih-Hsuan Yen) in branch 'master':
bpo-29442: Replace optparse with argparse in setup.py (GH-139)
https://github.com/python/cpython/commit/09b2bece78f62c3d363236dce593ecfe130afd2f


--
nosy: +inada.naoki

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue29442] Replace optparse with argparse in setup.py

[Chi Hsuan Yen]

Chi Hsuan Yen added the comment:

Thanks to Serhiy Storchaka's work in issue 30152, this patch can be simplified. 
I've rebased my branch and updated the pull request.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue29442] Replace optparse with argparse in setup.py

[STINNER Victor]

STINNER Victor added the comment:

I consider that the issue #30152 is now a dependency of this change.

--
dependencies: +Reduce the number of imports for argparse

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue29442] Replace optparse with argparse in setup.py

[Serhiy Storchaka]

Serhiy Storchaka added the comment:

See also issue30152. It includes Chi's change for argparse (actually it was 
inspired by Chi's change) and much more.

--
stage: resolved -> patch review

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue29442] Replace optparse with argparse in setup.py

[Chi Hsuan Yen]

Chi Hsuan Yen added the comment:

I guess you were asking whether the newly compiled Python binary is able to 
build extension modules or not? I rebased PR 139 against the latest git master 
and seems it's fine. Running `make distclean`, `./configure` and then `make` 
builds all modules as expected. The result is the same on Travis CI and 
Appveyor.

About "elegant": I guess the only issue regarding elegancy in my patch is the 
local import in  GNUTranslations._parse(). For me moving setup.py away from 
deprecated modules is a good reason for introducing local imports. Does it 
sound OK?

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue29442] Replace optparse with argparse in setup.py

[STINNER Victor]

STINNER Victor added the comment:

Did someone test the patch? Does Python still bootstrap after a distclean or 
not? If not, I suggest to close the issue, except if Chi Hsuan Yen finf an 
elegant way to fix them :-)

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue29442] Replace optparse with argparse in setup.py

[Brett Cannon]

Brett Cannon added the comment:

I just wanted to acknowledge that I read this thread. I accept Chi's 
acknowledgement of his actions and I hope there aren't future missteps, but 
please also realize that there has been a warning about how you communicate 
here, Chi.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue29442] Replace optparse with argparse in setup.py

[Serhiy Storchaka]

Serhiy Storchaka added the comment:

> (example: usage of os.system() in some places)

See similar issue7438.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue29442] Replace optparse with argparse in setup.py

[Chi Hsuan Yen]

Chi Hsuan Yen added the comment:

I see your points. Indeed in many times I didn't think carefully before leaving 
a comment, and not even noticing that my comments can be offensive afterwards. 
I apologize for all those cases and I'll be more careful when interacting with 
others in the future.

@Xavier: I'm gratitude for your patience on taking so much time explaining what 
I've done wrong. It's an invaluable course.

Let me change the title of this issue first. That will make it more moderate 
and also clearer.

--
title: Use argparse and drop dirty optparse hacks in setup.py -> Replace 
optparse with argparse in setup.py

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com