[issue29649] struct.pack_into check boundary error message ignores offset

Serhiy Storchaka added the comment: Thank you for your contribution Andrew. -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker ___

[issue29649] struct.pack_into check boundary error message ignores offset

Serhiy Storchaka added the comment: New changeset f78b119364b521307237a1484ba5f43f42300898 by Serhiy Storchaka (Andrew Nester) in branch 'master': bpo-29649: Improve struct.pack_into() boundary error messages (#424) https://github.com/python/cpython/commit/f78b119364b521307237a1484ba5f43f423008

[issue29649] struct.pack_into check boundary error message ignores offset

Andrew Nester added the comment: any updates on this issue? looks like PR is ready to go -- ___ Python tracker ___ ___ Python-bugs-lis

[issue29649] struct.pack_into check boundary error message ignores offset

Andrew Nester added the comment: Thanks Serhiy! Just implemented new error messages in my PR for case you mentioned. -- ___ Python tracker ___ __

[issue29649] struct.pack_into check boundary error message ignores offset

Serhiy Storchaka added the comment: Different error messages are needed if original offset < 0. For example packing 4 bytes with offset -2 always fails, not depending of the size of the buffer. Packing into buffer of size 10 with offset -11 always fails, not depending of the size of packed dat

[issue29649] struct.pack_into check boundary error message ignores offset

Changes by Terry J. Reedy : -- stage: -> patch review title: struct.pack_into check boundary error message didn't respect offset -> struct.pack_into check boundary error message ignores offset type: -> enhancement ___ Python tracker