[issue29677] clarify docs about 'round()' accepting a negative integer for ndigits

[Mariatta Wijaya]

Mariatta Wijaya added the comment:

Gerrit, Cheryl, thanks and congrats for your first contributions to CPython!

They've been merged and backported to 3.5 and 3.6.
So I'm closing this now.

Thanks all :)

--
resolution:  -> fixed
stage: backport needed -> resolved
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue29677] clarify docs about 'round()' accepting a negative integer for ndigits

[Mariatta Wijaya]

Mariatta Wijaya added the comment:


New changeset eef6e11f9883f54de491121b8c49fdadd3e3506d by Mariatta in branch 
'3.5':
bpo-29677: DOC: clarify documentation for `round` (GH-877) (GH-893)
https://github.com/python/cpython/commit/eef6e11f9883f54de491121b8c49fdadd3e3506d


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue29677] clarify docs about 'round()' accepting a negative integer for ndigits

[Mariatta Wijaya]

Mariatta Wijaya added the comment:


New changeset 2609c9ee78c53d501914a5a90dbe094d9a8c3c97 by Mariatta in branch 
'3.6':
bpo-29677: DOC: clarify documentation for `round` (GH-877) (GH-892)
https://github.com/python/cpython/commit/2609c9ee78c53d501914a5a90dbe094d9a8c3c97


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue29677] clarify docs about 'round()' accepting a negative integer for ndigits

[Mariatta Wijaya]

Changes by Mariatta Wijaya :


--
pull_requests: +796

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue29677] clarify docs about 'round()' accepting a negative integer for ndigits

[Mariatta Wijaya]

Changes by Mariatta Wijaya :


--
pull_requests: +795

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue29677] clarify docs about 'round()' accepting a negative integer for ndigits

[Cheryl Sabella]

Cheryl Sabella added the comment:

Mariatta,

Thank you so much for your support and encouragement while I worked on my first 
PR.  You've made this an awesome experience!

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue29677] clarify docs about 'round()' accepting a negative integer for ndigits

[Mariatta Wijaya]

Changes by Mariatta Wijaya :


--
stage: needs patch -> backport needed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue29677] clarify docs about 'round()' accepting a negative integer for ndigits

[Mariatta Wijaya]

Mariatta Wijaya added the comment:


New changeset 85deefcf61d3cc192846f41a4ccc6df17da60c98 by Mariatta (csabella) 
in branch 'master':
bpo-29677: DOC: clarify documentation for `round` (GH-877)
https://github.com/python/cpython/commit/85deefcf61d3cc192846f41a4ccc6df17da60c98


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue29677] clarify docs about 'round()' accepting a negative integer for ndigits

[Cheryl Sabella]

Changes by Cheryl Sabella :


--
pull_requests: +776

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue29677] clarify docs about 'round()' accepting a negative integer for ndigits

[Cheryl Sabella]

Cheryl Sabella added the comment:

Mariatta,

Yes, thank you, I will work on a pull request to address Victor's comment.  
Since it's my first time, I hope to read through the contributing docs and get 
this done today or tomorrow.

Thank you!

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue29677] clarify docs about 'round()' accepting a negative integer for ndigits

[Mariatta Wijaya]

Mariatta Wijaya added the comment:

GH-357 is:
https://github.com/python/cpython/pull/357/files

:)

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue29677] clarify docs about 'round()' accepting a negative integer for ndigits

[Mariatta Wijaya]

Mariatta Wijaya added the comment:

Cheryl, thank you for your interest in working on this issue.

The original issue has been addressed in Gerrit Holl's PR. But it seems like 
the docs can be further improved.

Here is Victor's comment about it: (copied from GH-357)

```
while we are modifying the doc, I dislike the start: "Return the floating point 
value number": number can be an integer. round(123, -2) doesn't use floating 
point numbers. Maybe rephrase to following text?

Return number rounded to (...). number can be an integer or a floating point 
number.

Or just remove "floating pointer number"?
```

Will you be interested in preparing a PR to address Victor's comment above?

Thanks :)

--
stage:  -> needs patch
versions:  -Python 2.7

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue29677] clarify docs about 'round()' accepting a negative integer for ndigits

[Mariatta Wijaya]

Mariatta Wijaya added the comment:


New changeset 8994f36287b068e8ea9a9230fc90eda72bf5fff0 by Mariatta in branch 
'3.5':
bpo-29677: DOC: clarify documentation for `round` (GH-357) (GH-863)
https://github.com/python/cpython/commit/8994f36287b068e8ea9a9230fc90eda72bf5fff0


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue29677] clarify docs about 'round()' accepting a negative integer for ndigits

[Mariatta Wijaya]

Mariatta Wijaya added the comment:


New changeset 596506216104613591218c2896cdb49fa0b7e5bb by Mariatta in branch 
'3.6':
bpo-29677: DOC: clarify documentation for `round` (GH-357) (GH-862)
https://github.com/python/cpython/commit/596506216104613591218c2896cdb49fa0b7e5bb


--
nosy: +Mariatta

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue29677] clarify docs about 'round()' accepting a negative integer for ndigits

[Mariatta Wijaya]

Changes by Mariatta Wijaya :


--
pull_requests: +763

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue29677] clarify docs about 'round()' accepting a negative integer for ndigits

[Mariatta Wijaya]

Changes by Mariatta Wijaya :


--
pull_requests: +762

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue29677] clarify docs about 'round()' accepting a negative integer for ndigits

[STINNER Victor]

STINNER Victor added the comment:


New changeset 6003db7db5fec545c01923c198a5fdfca5a91538 by Victor Stinner 
(Gerrit Holl) in branch 'master':
bpo-29677: DOC: clarify documentation for `round` (#357)
https://github.com/python/cpython/commit/6003db7db5fec545c01923c198a5fdfca5a91538


--
nosy: +haypo

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue29677] clarify docs about 'round()' accepting a negative integer for ndigits

[Mariatta Wijaya]

Changes by Mariatta Wijaya :


--
versions: +Python 2.7, Python 3.5, Python 3.6, Python 3.7

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue29677] clarify docs about 'round()' accepting a negative integer for ndigits

[Cheryl Sabella]

Cheryl Sabella added the comment:

I'm new to contributing.  Can I work on this one?

--
nosy: +csabella

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue29677] clarify docs about 'round()' accepting a negative integer for ndigits

[Brett Cannon]

Changes by Brett Cannon :


--
title: 'round()' accepts a negative integer for ndigits -> clarify docs about 
'round()' accepting a negative integer for ndigits

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com