[issue29832] Don't refer to getsockaddrarg in error messages

2018-09-11 Thread Benjamin Peterson
Benjamin Peterson added the comment: New changeset 735171e33486131d93865cf851c0c3d63fffd364 by Benjamin Peterson (Oren Milman) in branch 'master': closes bpo-29832: Remove "getsockaddrarg" from error messages. (GH-3163)

[issue29832] Don't refer to getsockaddrarg in error messages

2017-10-02 Thread Oren Milman
Oren Milman added the comment: Should i remove the code that i wasn't able to test from the PR, and leave such changes to someone that is able to test it? (of course, if there is some way i can do it using a VM, please point that out, and i would try to set up this VM.)

[issue29832] Don't refer to getsockaddrarg in error messages

2017-08-20 Thread Oren Milman
Oren Milman added the comment: here is a dirty script to test my PR. the script contains tests to anything I managed to test using my Windows 10 and Ubuntu 16.04 VM, i.e. all of the changes, except for the 'unsupported CAN protocol' message, and the changes of the code that handles the

[issue29832] Don't refer to getsockaddrarg in error messages

2017-08-20 Thread Oren Milman
Changes by Oren Milman : -- pull_requests: +3199 ___ Python tracker ___ ___

[issue29832] Don't refer to getsockaddrarg in error messages

2017-03-17 Thread Oren Milman
Oren Milman added the comment: note that #15988 also left 3 changes for this issue to fix, as can be seen by searching for '29832' in the comments of PR 668. for example, this issue should also fix the following inconsistent error messages: >>> socket.socket(family=socket.AF_INET6).bind(('::1',

[issue29832] Don't refer to getsockaddrarg in error messages

2017-03-17 Thread Serhiy Storchaka
New submission from Serhiy Storchaka: getsockaddrarg() is an internal C function in the socket module implementation used in a number of socket methods (bind(), connect(), connect_ex(), sendto(), sendmsg()) for creating C structure sock_addr_t from Python tuple. Error messages raised when

[issue29832] Don't refer to getsockaddrarg in error messages

2017-03-17 Thread Serhiy Storchaka
Changes by Serhiy Storchaka : -- pull_requests: +564 ___ Python tracker ___ ___