[issue2990] type cache updates might run cleanup code in an inconsistent state

Georg Brandl <[EMAIL PROTECTED]> added the comment: Reverted in r63787. ___ Python tracker <[EMAIL PROTECTED]> ___ ___ Python-bugs-list mailing l

[issue2990] type cache updates might run cleanup code in an inconsistent state

Stefan Behnel <[EMAIL PROTECTED]> added the comment: Ok, I buy that argument. The patch may be considered a code uglification then. ___ Python tracker <[EMAIL PROTECTED]> ___ __

[issue2990] type cache updates might run cleanup code in an inconsistent state

Armin Rigo <[EMAIL PROTECTED]> added the comment: This was actually not a bug because the object being decref'ed is guaranteed to be exactly a string or None, as told in the comment about the 'name' field. So no user code could possibly run during this Py_DECREF() call. -- nosy: +arigo

[issue2990] type cache updates might run cleanup code in an inconsistent state

Georg Brandl <[EMAIL PROTECTED]> added the comment: Thanks, committed in r63760. -- nosy: +georg.brandl resolution: -> accepted status: open -> closed ___ Python tracker <[EMAIL PROTECTED]> _

[issue2990] type cache updates might run cleanup code in an inconsistent state

New submission from Stefan Behnel <[EMAIL PROTECTED]>: Similar to the "decref before set" issue solved by Py_CLEAR(), the code in typeobject.c calls DECREF in the middle of a cache update. This leaves one cache entry in an invalid state during the DECREF call, which might result in running cleanu