[issue29933] asyncio: set_write_buffer_limits() doc doesn't specify unit of the parameters

Berker Peksag added the comment: PR 2262 has been merged and backported to bugfix branches so I think this issue can be closed now. -- nosy: +berker.peksag resolution: -> fixed stage: needs patch -> resolved status: open -> closed type: -> enhancement

[issue29933] asyncio: set_write_buffer_limits() doc doesn't specify unit of the parameters

Mariatta Wijaya added the comment: New changeset 03af4282423b1c287a194664f90496cfc9cf20c7 by Mariatta (Kojo Idrissa) in branch '3.6': [3.6] bpo-29933: Improve set_write_buffer_limits description (GH-2262) (GH-2532)

[issue29933] asyncio: set_write_buffer_limits() doc doesn't specify unit of the parameters

Mariatta Wijaya added the comment: New changeset 4685e56596f9f332e402c79c913a73b19f4411e1 by Mariatta (Kojo Idrissa) in branch '3.5': [3.5] bpo-29933: Improve set_write_buffer_limits description (GH-2262) (GH-2533)

[issue29933] asyncio: set_write_buffer_limits() doc doesn't specify unit of the parameters

Changes by Kojo Idrissa : -- pull_requests: +2599 ___ Python tracker ___ ___

[issue29933] asyncio: set_write_buffer_limits() doc doesn't specify unit of the parameters

Changes by Kojo Idrissa : -- pull_requests: +2600 ___ Python tracker ___ ___

[issue29933] asyncio: set_write_buffer_limits() doc doesn't specify unit of the parameters

STINNER Victor added the comment: Oh, thanks for the documentation! Now the change should just be backported to other branches. -- ___ Python tracker

[issue29933] asyncio: set_write_buffer_limits() doc doesn't specify unit of the parameters

Mariatta Wijaya added the comment: New changeset 5200a7c7f9ea65a96330c5f276f4acc6ec70854e by Mariatta (Kojo Idrissa) in branch 'master': bpo-29933: Improve set_write_buffer_limits description (GH-2262) https://github.com/python/cpython/commit/5200a7c7f9ea65a96330c5f276f4acc6ec70854e

[issue29933] asyncio: set_write_buffer_limits() doc doesn't specify unit of the parameters

Changes by Mariatta Wijaya : -- versions: +Python 3.5, Python 3.6 ___ Python tracker ___

[issue29933] asyncio: set_write_buffer_limits() doc doesn't specify unit of the parameters

Changes by Kojo Idrissa : -- pull_requests: +2312 ___ Python tracker ___ ___

[issue29933] asyncio: set_write_buffer_limits() doc doesn't specify unit of the parameters

Changes by Mariatta Wijaya : -- assignee: docs@python -> Mariatta nosy: +Mariatta ___ Python tracker ___

[issue29933] asyncio: set_write_buffer_limits() doc doesn't specify unit of the parameters

Changes by Mariatta Wijaya : -- stage: -> needs patch ___ Python tracker ___ ___

[issue29933] asyncio: set_write_buffer_limits() doc doesn't specify unit of the parameters

STINNER Victor added the comment: It would also be nice to: * link to set_write_buffer_limits() from drain() * link to set_write_buffer_limits() from pause_writing() / resume_writing() * mention asyncio default values for set_write_buffer_limits(): low=16 kB, high=64 kB (kb? kib? i never know

[issue29933] asyncio: set_write_buffer_limits() doc doesn't specify unit of the parameters

STINNER Victor added the comment: See also https://github.com/asyncio-doc/asyncio-doc/issues/17 for a more general documentation request on asyncio parameters (on the external asyncio doc). -- ___ Python tracker

[issue29933] asyncio: set_write_buffer_limits() doc doesn't specify unit of the parameters

New submission from STINNER Victor: The asyncio set_write_buffer_limits() documentation doesn't specify unit of high and low parameters. Moreover, it would to explain better the effect of high and low: * pause_writing() is called when the buffer size becomes larger or equal to high * (if