[issue29999] repr() of ImportError misses keyword arguments name and path

[Rémi Lapeyre]

Rémi Lapeyre  added the comment:

I think the issue steems from the more general #27015 for which a PR is ready 
that fixes the repr not only for ImportError but all other BaseException 
subclasses that override __init__.

--
keywords: +patch
nosy: +remi.lapeyre
pull_requests: +11554

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue29999] repr() of ImportError misses keyword arguments name and path

[Berker Peksag]

Berker Peksag added the comment:

Including 'path' may make the repr less readable in some cases. +1 for 'name', 
though.

--
nosy: +berker.peksag

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue29999] repr() of ImportError misses keyword arguments name and path

[Serhiy Storchaka]

Serhiy Storchaka added the comment:

The patch also changes the repr of BaseException with a single argument. It no 
longer contains a trailing comma.

--
assignee:  -> serhiy.storchaka

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue29999] repr() of ImportError misses keyword arguments name and path

[Brett Cannon]

Brett Cannon added the comment:

I consider it an enhancement, especially if someone was slopping with their 
tests and explicitly checks the repr of ImportError.

--
type:  -> enhancement

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue29999] repr() of ImportError misses keyword arguments name and path

[Serhiy Storchaka]

Changes by Serhiy Storchaka :


--
pull_requests: +1179

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue29999] repr() of ImportError misses keyword arguments name and path

[Serhiy Storchaka]

New submission from Serhiy Storchaka:

The repr of standard exceptions usually looks as exception constructor used for 
creating that exception. But the repr of ImportError misses keyword arguments 
name and path.

>>> ImportError('test', name='somename', path='somepath')
ImportError('test',)

Proposed patch make the repr of ImportError containing keyword arguments.

>>> ImportError('test', name='somename', path='somepath')
ImportError('test', name='somename', path='somepath')

I don't know how to classify this issue and whether the patch should be 
backported.

--
components: Interpreter Core
messages: 291200
nosy: brett.cannon, eric.snow, ncoghlan, serhiy.storchaka
priority: normal
severity: normal
stage: patch review
status: open
title: repr() of ImportError misses keyword arguments name and path
versions: Python 3.7

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com